Skip to content

Commit 8e25b41

Browse files
committed
Auto merge of #158379 - JonathanBrouwer:i686-workaround, r=Mark-Simulacrum
Workaround: Skip rustc book on i686 Workaround for #158378 so we can get CI going again r? @ghost
2 parents f28ac76 + c36caac commit 8e25b41

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/bootstrap/mk/Makefile.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@ TEST_SET2 := --skip=tests --skip=coverage-map --skip=coverage-run --skip=library
112112

113113
# this intentionally doesn't use `$(BOOTSTRAP)` so we can test the shebang on Windows
114114
ci-msvc-py:
115-
$(Q)$(CFG_SRC_DIR)/x.py test --stage 2 $(TEST_SET1)
115+
$(Q)$(CFG_SRC_DIR)/x.py test --stage 2 $(TEST_SET1) --skip=src/tools/linkchecker
116116
ci-msvc-ps1:
117-
$(Q)$(CFG_SRC_DIR)/x.ps1 test --stage 2 $(TEST_SET2)
117+
$(Q)$(CFG_SRC_DIR)/x.ps1 test --stage 2 $(TEST_SET2) --skip=src/tools/linkchecker
118118
ci-msvc: ci-msvc-py ci-msvc-ps1
119119

120120
## MingW native builders

src/bootstrap/src/core/build_steps/doc.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,6 +1392,13 @@ impl Step for RustcBook {
13921392
/// in the "md-doc" directory in the build output directory. Then
13931393
/// "rustbook" is used to convert it to HTML.
13941394
fn run(self, builder: &Builder<'_>) {
1395+
// FIXME: Temporary workaround for https://github.com/rust-lang/rust/issues/158378
1396+
#[cfg(not(test))] // So this check doesn't affect the bootstrap tests
1397+
if self.target == "i686-pc-windows-msvc" {
1398+
eprintln!("WARNING: Skipping rustc book build to work around #158378");
1399+
return;
1400+
}
1401+
13951402
let out_base = builder.md_doc_out(self.target).join("rustc");
13961403
t!(fs::create_dir_all(&out_base));
13971404
let out_listing = out_base.join("src/lints");

src/ci/github-actions/jobs.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ pr:
161161
env:
162162
CODEGEN_BACKENDS: gcc
163163
<<: *job-linux-4c
164-
164+
165165
# This job tests features we want to stabilize soon, to ensure they don't
166166
# regress.
167167
- name: x86_64-gnu-next-trait-solver-polonius
@@ -720,6 +720,7 @@ auto:
720720
--target=i686-pc-windows-msvc
721721
--enable-full-tools
722722
--enable-profiler
723+
--disable-docs
723724
SCRIPT: python x.py dist bootstrap --include-default-paths
724725
DIST_REQUIRE_ALL_TOOLS: 1
725726
CODEGEN_BACKENDS: llvm,cranelift

src/tools/build-manifest/src/main.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ static DOCS_FALLBACK: &[(&str, &str)] = &[
2626
("-apple-", "aarch64-apple-darwin"),
2727
("aarch64", "aarch64-unknown-linux-gnu"),
2828
("arm-", "aarch64-unknown-linux-gnu"),
29+
("i686-pc-windows", "x86_64-pc-windows-msvc"),
2930
("", "x86_64-unknown-linux-gnu"),
3031
];
3132

0 commit comments

Comments
 (0)