Skip to content

Commit a214ed1

Browse files
authored
Rollup merge of #155739 - Voultapher:add-tmp-scope-to-assert-macros, r=Amanieu
Add temporary scope to assert_eq and assert_ne This is a follow-up to #155431
2 parents 986dcd7 + 51f42d6 commit a214ed1

2 files changed

Lines changed: 21 additions & 9 deletions

File tree

library/core/src/macros/mod.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ macro_rules! panic {
4040
#[rustc_diagnostic_item = "assert_eq_macro"]
4141
#[allow_internal_unstable(panic_internals)]
4242
macro_rules! assert_eq {
43-
($left:expr, $right:expr $(,)?) => {
43+
($left:expr, $right:expr $(,)?) => {{
4444
match (&$left, &$right) {
4545
(left_val, right_val) => {
4646
if !(*left_val == *right_val) {
@@ -52,8 +52,8 @@ macro_rules! assert_eq {
5252
}
5353
}
5454
}
55-
};
56-
($left:expr, $right:expr, $($arg:tt)+) => {
55+
}};
56+
($left:expr, $right:expr, $($arg:tt)+) => {{
5757
match (&$left, &$right) {
5858
(left_val, right_val) => {
5959
if !(*left_val == *right_val) {
@@ -65,7 +65,7 @@ macro_rules! assert_eq {
6565
}
6666
}
6767
}
68-
};
68+
}};
6969
}
7070

7171
/// Asserts that two expressions are not equal to each other (using [`PartialEq`]).
@@ -96,7 +96,7 @@ macro_rules! assert_eq {
9696
#[rustc_diagnostic_item = "assert_ne_macro"]
9797
#[allow_internal_unstable(panic_internals)]
9898
macro_rules! assert_ne {
99-
($left:expr, $right:expr $(,)?) => {
99+
($left:expr, $right:expr $(,)?) => {{
100100
match (&$left, &$right) {
101101
(left_val, right_val) => {
102102
if *left_val == *right_val {
@@ -108,8 +108,8 @@ macro_rules! assert_ne {
108108
}
109109
}
110110
}
111-
};
112-
($left:expr, $right:expr, $($arg:tt)+) => {
111+
}};
112+
($left:expr, $right:expr, $($arg:tt)+) => {{
113113
match (&($left), &($right)) {
114114
(left_val, right_val) => {
115115
if *left_val == *right_val {
@@ -121,7 +121,7 @@ macro_rules! assert_ne {
121121
}
122122
}
123123
}
124-
};
124+
}};
125125
}
126126

127127
/// Asserts that an expression matches the provided pattern.

library/coretests/tests/macros.rs

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,19 @@ fn temporary_scope_introduction() {
241241

242242
(assert_matches!(*MutRefWithDrop(&mut val).0, 0), std::mem::take(&mut val));
243243
(assert_matches!(*MutRefWithDrop(&mut val).0, 0, "msg"), std::mem::take(&mut val));
244-
245244
(debug_assert_matches!(*MutRefWithDrop(&mut val).0, 0), std::mem::take(&mut val));
246245
(debug_assert_matches!(*MutRefWithDrop(&mut val).0, 0, "msg"), std::mem::take(&mut val));
246+
247+
(assert_eq!(*MutRefWithDrop(&mut val).0, 0), std::mem::take(&mut val));
248+
(assert_eq!(*MutRefWithDrop(&mut val).0, 0, "msg"), std::mem::take(&mut val));
249+
(debug_assert_eq!(*MutRefWithDrop(&mut val).0, 0), std::mem::take(&mut val));
250+
(debug_assert_eq!(*MutRefWithDrop(&mut val).0, 0, "msg"), std::mem::take(&mut val));
251+
252+
(assert_ne!(*MutRefWithDrop(&mut val).0, 1), std::mem::take(&mut val));
253+
(assert_ne!(*MutRefWithDrop(&mut val).0, 1, "msg"), std::mem::take(&mut val));
254+
(debug_assert_ne!(*MutRefWithDrop(&mut val).0, 1), std::mem::take(&mut val));
255+
(debug_assert_ne!(*MutRefWithDrop(&mut val).0, 1, "msg"), std::mem::take(&mut val));
256+
257+
(assert!(*MutRefWithDrop(&mut val).0 == 0), std::mem::take(&mut val));
258+
(assert!(*MutRefWithDrop(&mut val).0 == 0, "msg"), std::mem::take(&mut val));
247259
}

0 commit comments

Comments
 (0)