use libm functions for acosh and asinh

Author: malezjaa

library/coretests/tests/num/floats.rs

@@ -1699,6 +1699,8 @@ float_test! {
         assert!(nan.asinh().is_nan());
         assert!(flt(-0.0).asinh().is_sign_negative());
 
+        assert_ne!(Float::MAX.asinh(), inf);
+
         // issue 63271
         assert_approx_eq!(flt(2.0).asinh(), 1.443635475178810342493276740273105, Float::ASINH_APPROX);
         assert_approx_eq!(flt(-2.0).asinh(), -1.443635475178810342493276740273105, Float::ASINH_APPROX);
@@ -1732,6 +1734,7 @@ float_test! {
         assert!(nan.acosh().is_nan());
         assert_approx_eq!(flt(2.0).acosh(), 1.31695789692481670862504634730796844, Float::ACOSH_APPROX);
         assert_approx_eq!(flt(3.0).acosh(), 1.76274717403908605046521864995958461, Float::ACOSH_APPROX);
+        assert_ne!(Float::MAX.acosh(), inf);
 
         #[allow(overflowing_literals)]
         if Float::MAX > flt(66000.0) {

library/std/src/num/f128.rs

@@ -868,6 +868,10 @@ impl f128 {
     #[must_use = "method returns a new number and does not mutate the original value"]
     pub fn asinh(self) -> f128 {
         let ax = self.abs();
+        if ax >= (1u128 << f128::MANTISSA_DIGITS / 2) as f128 {
+            return (ax.ln() + consts::LN_2).copysign(self);
+        }
+
         let ix = 1.0 / ax;
         (ax + (ax / (Self::hypot(1.0, ix) + ix))).ln_1p().copysign(self)
     }
@@ -902,6 +906,8 @@ impl f128 {
     pub fn acosh(self) -> f128 {
         if self < 1.0 {
             Self::NAN
+        } else if self >= (1u128 << f128::MANTISSA_DIGITS / 2) as f128 {
+            self.ln() + consts::LN_2
         } else {
             (self + ((self - 1.0).sqrt() * (self + 1.0).sqrt())).ln()
         }

library/std/src/num/f16.rs

@@ -832,9 +832,7 @@ impl f16 {
     #[unstable(feature = "f16", issue = "116909")]
     #[must_use = "method returns a new number and does not mutate the original value"]
     pub fn asinh(self) -> f16 {
-        let ax = self.abs();
-        let ix = 1.0 / ax;
-        (ax + (ax / (Self::hypot(1.0, ix) + ix))).ln_1p().copysign(self)
+        cmath::asinhf(self as f32) as f16
     }
 
     /// Inverse hyperbolic cosine function.
@@ -865,11 +863,7 @@ impl f16 {
     #[unstable(feature = "f16", issue = "116909")]
     #[must_use = "method returns a new number and does not mutate the original value"]
     pub fn acosh(self) -> f16 {
-        if self < 1.0 {
-            Self::NAN
-        } else {
-            (self + ((self - 1.0).sqrt() * (self + 1.0).sqrt())).ln()
-        }
+        cmath::acoshf(self as f32) as f16
     }
 
     /// Inverse hyperbolic tangent function.

library/std/src/num/f32.rs

@@ -1091,9 +1091,7 @@ impl f32 {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[inline]
     pub fn asinh(self) -> f32 {
-        let ax = self.abs();
-        let ix = 1.0 / ax;
-        (ax + (ax / (Self::hypot(1.0, ix) + ix))).ln_1p().copysign(self)
+        cmath::asinhf(self)
     }
 
     /// Inverse hyperbolic cosine function.
@@ -1119,11 +1117,7 @@ impl f32 {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[inline]
     pub fn acosh(self) -> f32 {
-        if self < 1.0 {
-            Self::NAN
-        } else {
-            (self + ((self - 1.0).sqrt() * (self + 1.0).sqrt())).ln()
-        }
+        cmath::acoshf(self)
     }
 
     /// Inverse hyperbolic tangent function.

library/std/src/num/f64.rs

@@ -1091,9 +1091,7 @@ impl f64 {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[inline]
     pub fn asinh(self) -> f64 {
-        let ax = self.abs();
-        let ix = 1.0 / ax;
-        (ax + (ax / (Self::hypot(1.0, ix) + ix))).ln_1p().copysign(self)
+        cmath::asinh(self)
     }
 
     /// Inverse hyperbolic cosine function.
@@ -1119,11 +1117,7 @@ impl f64 {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[inline]
     pub fn acosh(self) -> f64 {
-        if self < 1.0 {
-            Self::NAN
-        } else {
-            (self + ((self - 1.0).sqrt() * (self + 1.0).sqrt())).ln()
-        }
+        cmath::acosh(self)
     }
 
     /// Inverse hyperbolic tangent function.

library/std/src/sys/cmath.rs

@@ -4,7 +4,9 @@
 // or by `compiler-builtins` on unsupported platforms.
 unsafe extern "C" {
     pub safe fn acos(n: f64) -> f64;
+    pub safe fn acosh(n: f64) -> f64;
     pub safe fn asin(n: f64) -> f64;
+    pub safe fn asinh(n: f64) -> f64;
     pub safe fn atan(n: f64) -> f64;
     pub safe fn atan2(a: f64, b: f64) -> f64;
     pub safe fn cosh(n: f64) -> f64;
@@ -57,6 +59,16 @@ cfg_select! {
             f64::acos(n as f64) as f32
         }
 
+        #[inline]
+        pub fn acoshf(n: f32) -> f32 {
+            f64::acosh(n as f64) as f32
+        }
+
+        #[inline]
+        pub fn asinhf(n: f32) -> f32 {
+            f64::asinh(n as f64) as f32
+        }
+
         #[inline]
         pub fn asinf(n: f32) -> f32 {
             f64::asin(n as f64) as f32
@@ -95,7 +107,9 @@ cfg_select! {
     _ => {
         unsafe extern "C" {
             pub safe fn acosf(n: f32) -> f32;
+            pub safe fn acoshf(n: f32) -> f32;
             pub safe fn asinf(n: f32) -> f32;
+            pub safe fn asinhf(n: f32) -> f32;
             pub safe fn atan2f(a: f32, b: f32) -> f32;
             pub safe fn atanf(n: f32) -> f32;
             pub safe fn coshf(n: f32) -> f32;

src/tools/miri/src/shims/math.rs

@@ -30,6 +30,8 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
             | "acosf"
             | "asinf"
             | "atanf"
+            | "acoshf"
+            | "asinhf"
             | "log1pf"
             | "expm1f"
             | "tgammaf"
@@ -52,6 +54,8 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
                         "acosf" => f_host.acos(),
                         "asinf" => f_host.asin(),
                         "atanf" => f_host.atan(),
+                        "acoshf" => f_host.acosh(),
+                        "asinhf" => f_host.asinh(),
                         "log1pf" => f_host.ln_1p(),
                         "expm1f" => f_host.exp_m1(),
                         "tgammaf" => f_host.gamma(),
@@ -113,6 +117,8 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
             | "acos"
             | "asin"
             | "atan"
+            | "acosh"
+            | "asinh"
             | "log1p"
             | "expm1"
             | "tgamma"
@@ -135,6 +141,8 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
                         "acos" => f_host.acos(),
                         "asin" => f_host.asin(),
                         "atan" => f_host.atan(),
+                        "acosh" => f_host.acosh(),
+                        "asinh" => f_host.asinh(),
                         "log1p" => f_host.ln_1p(),
                         "expm1" => f_host.exp_m1(),
                         "tgamma" => f_host.gamma(),