TODO: Add to TEACH BOOTSTRAP

Author: jchlanda

src/bootstrap/src/core/build_steps/test.rs

@@ -3907,10 +3907,10 @@ impl Step for TestHelpers {
                 .arg(&so)
                 .arg(&src)
                 .status()
-                .expect("Failed to run pauthtest clang for librust_test_helpers.so");
+                .unwrap_or_else(|_| panic!("Failed to run clang for {} toolchain", target.triple));
 
             if !status.success() {
-                panic!("Linking of pauthtest librust_test_helpers.so failed");
+                panic!("Linking of librust_test_helpers.so failed (target: {})", target.triple);
             }
         }
     }

src/bootstrap/src/core/sanity.rs

@@ -37,7 +37,7 @@ pub struct Finder {
 /// when the newly-bumped stage 0 compiler now knows about the formerly-missing targets.
 const STAGE0_MISSING_TARGETS: &[&str] = &[
     // just a dummy comment so the list doesn't get onelined
-    "aarch64-unknown-linux-pauthtest", // Stage 0 compiler is not guaranteed to see pauthtest yet.
+    "aarch64-unknown-linux-pauthtest", // Stage 0 compiler is not guaranteed to see the target yet.
 ];
 
 /// Minimum version threshold for libstdc++ required when using prebuilt LLVM

tests/run-make/c-link-to-rust-va-list-fn/rmake.rs

@@ -6,8 +6,8 @@
 //@ needs-target-std
 //@ ignore-android: FIXME(#142855)
 //@ ignore-sgx: (x86 machine code cannot be directly executed)
-//@ ignore-aarch64-unknown-linux-pauthtest: (pauthtest requires non-trivial compilation of c
-//sources, ignore the test for now).
+//@ ignore-aarch64-unknown-linux-pauthtest: (it requires non-trivial compilation of c sources,
+// and only supports dynamic linking, ignore the test).
 
 use run_make_support::{cc, extra_c_flags, run, rustc, static_lib_name};
 

tests/run-make/pauth-quicksort-c-driver/rmake.rs

@@ -1,9 +1,8 @@
 // Test compilation flow using custom pauth-enabled toolchain and signing extern "C" function
-// pointers used from within rust. Note that in order for the test to work the location of the
-// toolchain's sysroot has to be provided via env variable (`PAUTHTEST_SYSROOT`). The test assumes
-// that pauthtest-enabled `clang` is available on the path.
-// In this test rust is the driver - providing the data and the comparison function; while c -
-// provides the implementation of quicksort algorithm and is the user of  the data and comparator.
+// pointers used from within rust. The test assumes that pointer-authentication-enabled `clang` is
+// available on the path. In this test rust is the driver - providing the data and the comparison
+// function; while c - provides the implementation of quicksort algorithm and is the user of  the
+// data and comparator.
 
 //@ only-aarch64-unknown-linux-pauthtest
 

tests/run-make/pauth-quicksort-rust-driver/rmake.rs

@@ -1,6 +1,6 @@
 // Test compilation flow using custom pauth-enabled toolchain and signing extern "C" function
-// pointers used from within rust. The test assumes that pauthtest-enabled `clang` is available on
-// the path.
+// pointers used from within rust. The test assumes that pointer-authentication-enabled `clang` is
+// available on the path.
 // In this test rust is the driver - providing the data and the comparison function; while c -
 // provides the implementation of quicksort algorithm and is the user of  the data and comparator.