Rename rustc_mir_transform/src/errors.rs into rustc_mir_transform/src/diagnostics.rs

GuillaumeGomez · GuillaumeGomez · commit bbd0e834c8db · 2026-06-14T10:59:40.000+02:00
diff --git a/compiler/rustc_mir_transform/src/check_call_recursion.rs b/compiler/rustc_mir_transform/src/check_call_recursion.rs
@@ -10,7 +10,7 @@ use rustc_middle::ty::{self, GenericArg, GenericArgs, Instance, Ty, TyCtxt, Unno
 use rustc_session::lint::builtin::UNCONDITIONAL_RECURSION;
 use rustc_span::Span;
 
-use crate::errors::UnconditionalRecursion;
+use crate::diagnostics::UnconditionalRecursion;
 use crate::pass_manager::MirLint;
 
 pub(super) struct CheckCallRecursion;
diff --git a/compiler/rustc_mir_transform/src/check_const_item_mutation.rs b/compiler/rustc_mir_transform/src/check_const_item_mutation.rs
@@ -6,7 +6,7 @@ use rustc_session::lint::builtin::CONST_ITEM_MUTATION;
 use rustc_span::Span;
 use rustc_span::def_id::DefId;
 
-use crate::errors;
+use crate::diagnostics;
 
 pub(super) struct CheckConstItemMutation;
 
@@ -108,7 +108,7 @@ impl<'tcx> Visitor<'tcx> for ConstMutationChecker<'_, 'tcx> {
                     CONST_ITEM_MUTATION,
                     lint_root,
                     span,
-                    errors::ConstMutate::Modify { konst: item },
+                    diagnostics::ConstMutate::Modify { konst: item },
                 );
             }
 
@@ -154,7 +154,7 @@ impl<'tcx> Visitor<'tcx> for ConstMutationChecker<'_, 'tcx> {
                         CONST_ITEM_MUTATION,
                         lint_root,
                         span,
-                        errors::ConstMutate::MutBorrow { method_call, konst: item },
+                        diagnostics::ConstMutate::MutBorrow { method_call, konst: item },
                     );
                 }
             }
diff --git a/compiler/rustc_mir_transform/src/check_inline.rs b/compiler/rustc_mir_transform/src/check_inline.rs
@@ -26,7 +26,7 @@ impl<'tcx> MirLint<'tcx> for CheckForceInline {
         if let Err(reason) =
             is_inline_valid_on_fn(tcx, def_id).and_then(|_| is_inline_valid_on_body(tcx, body))
         {
-            tcx.dcx().emit_err(crate::errors::InvalidForceInline {
+            tcx.dcx().emit_err(crate::diagnostics::InvalidForceInline {
                 attr_span,
                 callee_span: tcx.def_span(def_id),
                 callee: tcx.def_path_str(def_id),
diff --git a/compiler/rustc_mir_transform/src/check_packed_ref.rs b/compiler/rustc_mir_transform/src/check_packed_ref.rs
@@ -3,7 +3,7 @@ use rustc_middle::mir::*;
 use rustc_middle::span_bug;
 use rustc_middle::ty::{self, TyCtxt};
 
-use crate::{errors, util};
+use crate::{diagnostics, util};
 
 pub(super) struct CheckPackedRef;
 
@@ -50,7 +50,7 @@ impl<'tcx> Visitor<'tcx> for PackedRefChecker<'_, 'tcx> {
                 // shouldn't do.
                 span_bug!(self.source_info.span, "builtin derive created an unaligned reference");
             } else {
-                self.tcx.dcx().emit_err(errors::UnalignedPackedRef {
+                self.tcx.dcx().emit_err(diagnostics::UnalignedPackedRef {
                     span: self.source_info.span,
                     ty_descr: adt.descr(),
                     align: pack.bytes(),
diff --git a/compiler/rustc_mir_transform/src/coroutine/layout.rs b/compiler/rustc_mir_transform/src/coroutine/layout.rs
@@ -46,7 +46,7 @@ use rustc_trait_selection::infer::TyCtxtInferExt as _;
 use rustc_trait_selection::traits::{ObligationCause, ObligationCauseCode, ObligationCtxt};
 use tracing::{debug, instrument, trace};
 
-use crate::errors::{MustNotSupend, MustNotSuspendReason};
+use crate::diagnostics::{MustNotSupend, MustNotSuspendReason};
 
 const SELF_ARG: Local = Local::arg(0);
 
diff --git a/compiler/rustc_mir_transform/src/diagnostics.rs b/compiler/rustc_mir_transform/src/diagnostics.rs
diff --git a/compiler/rustc_mir_transform/src/ffi_unwind_calls.rs b/compiler/rustc_mir_transform/src/ffi_unwind_calls.rs
@@ -9,7 +9,7 @@ use rustc_session::lint::builtin::FFI_UNWIND_CALLS;
 use rustc_target::spec::PanicStrategy;
 use tracing::debug;
 
-use crate::errors;
+use crate::diagnostics;
 
 // Check if the body of this def_id can possibly leak a foreign unwind into Rust code.
 fn has_ffi_unwind_calls(tcx: TyCtxt<'_>, local_def_id: LocalDefId) -> bool {
@@ -67,7 +67,7 @@ fn has_ffi_unwind_calls(tcx: TyCtxt<'_>, local_def_id: LocalDefId) -> bool {
                     FFI_UNWIND_CALLS,
                     lint_root,
                     span,
-                    errors::AsmUnwindCall { span },
+                    diagnostics::AsmUnwindCall { span },
                 );
 
                 tainted = true;
@@ -119,7 +119,7 @@ fn has_ffi_unwind_calls(tcx: TyCtxt<'_>, local_def_id: LocalDefId) -> bool {
                 FFI_UNWIND_CALLS,
                 lint_root,
                 span,
-                errors::FfiUnwindCall { span, foreign },
+                diagnostics::FfiUnwindCall { span, foreign },
             );
 
             tainted = true;
diff --git a/compiler/rustc_mir_transform/src/function_item_references.rs b/compiler/rustc_mir_transform/src/function_item_references.rs
@@ -7,7 +7,7 @@ use rustc_middle::ty::{self, EarlyBinder, GenericArgsRef, Ty, TyCtxt};
 use rustc_session::lint::builtin::FUNCTION_ITEM_REFERENCES;
 use rustc_span::{Span, Spanned, sym};
 
-use crate::errors;
+use crate::diagnostics;
 
 pub(super) struct FunctionItemReferences;
 
@@ -179,7 +179,7 @@ impl<'tcx> FunctionItemRefChecker<'_, 'tcx> {
             FUNCTION_ITEM_REFERENCES,
             lint_root,
             span,
-            errors::FnItemRef { span, sugg, ident },
+            diagnostics::FnItemRef { span, sugg, ident },
         );
     }
 }
diff --git a/compiler/rustc_mir_transform/src/inline.rs b/compiler/rustc_mir_transform/src/inline.rs
@@ -253,7 +253,7 @@ impl<'tcx> Inliner<'tcx> for ForceInliner<'tcx> {
 
         let call_span = callsite.source_info.span;
         let callee = tcx.def_path_str(callsite.callee.def_id());
-        tcx.dcx().emit_err(crate::errors::ForceInlineFailure {
+        tcx.dcx().emit_err(crate::diagnostics::ForceInlineFailure {
             call_span,
             attr_span,
             caller_span: tcx.def_span(self.def_id),
@@ -262,7 +262,7 @@ impl<'tcx> Inliner<'tcx> for ForceInliner<'tcx> {
             callee: callee.clone(),
             reason,
             justification: justification
-                .map(|sym| crate::errors::ForceInlineJustification { sym, callee }),
+                .map(|sym| crate::diagnostics::ForceInlineJustification { sym, callee }),
         });
     }
 }
diff --git a/compiler/rustc_mir_transform/src/known_panics_lint.rs b/compiler/rustc_mir_transform/src/known_panics_lint.rs
@@ -22,7 +22,7 @@ use rustc_middle::ty::{self, ConstInt, ScalarInt, Ty, TyCtxt, TypeVisitableExt,
 use rustc_span::Span;
 use tracing::{debug, instrument, trace};
 
-use crate::errors::{AssertLint, AssertLintKind};
+use crate::diagnostics::{AssertLint, AssertLintKind};
 
 pub(super) struct KnownPanicsLint;
 
diff --git a/compiler/rustc_mir_transform/src/lib.rs b/compiler/rustc_mir_transform/src/lib.rs
@@ -40,8 +40,8 @@ mod check_pointers;
 mod cost_checker;
 mod cross_crate_inline;
 mod deduce_param_attrs;
+mod diagnostics;
 mod elaborate_drop;
-mod errors;
 mod ffi_unwind_calls;
 mod lint;
 mod lint_tail_expr_drop_order;
diff --git a/compiler/rustc_mir_transform/src/lint_and_remove_uninhabited.rs b/compiler/rustc_mir_transform/src/lint_and_remove_uninhabited.rs
@@ -3,7 +3,7 @@ use rustc_middle::mir::*;
 use rustc_middle::ty::TyCtxt;
 use rustc_session::lint::builtin::UNREACHABLE_CODE;
 
-use crate::errors::UnreachableDueToUninhabited;
+use crate::diagnostics::UnreachableDueToUninhabited;
 
 /// Lint unreachable code due to uninhabited values from function calls,
 /// and remove return edges from those calls.
diff --git a/compiler/rustc_mir_transform/src/liveness.rs b/compiler/rustc_mir_transform/src/liveness.rs
@@ -19,7 +19,7 @@ use rustc_span::Span;
 use rustc_span::edit_distance::find_best_match_for_name;
 use rustc_span::symbol::{Symbol, kw, sym};
 
-use crate::errors;
+use crate::diagnostics;
 
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 enum AccessKind {
@@ -175,7 +175,7 @@ fn maybe_suggest_unit_pattern_typo<'tcx>(
     name: Symbol,
     span: Span,
     ty: Ty<'tcx>,
-) -> Option<errors::PatternTypo> {
+) -> Option<diagnostics::PatternTypo> {
     if let ty::Adt(adt_def, _) = ty.peel_refs().kind() {
         let variant_names: Vec<_> = adt_def
             .variants()
@@ -189,7 +189,7 @@ fn maybe_suggest_unit_pattern_typo<'tcx>(
                 .iter()
                 .find(|v| v.name == name && matches!(v.ctor, Some((CtorKind::Const, _))))
         {
-            return Some(errors::PatternTypo {
+            return Some(diagnostics::PatternTypo {
                 span,
                 code: with_no_trimmed_paths!(tcx.def_path_str(variant.def_id)),
                 kind: tcx.def_descr(variant.def_id),
@@ -213,7 +213,7 @@ fn maybe_suggest_unit_pattern_typo<'tcx>(
         && let Some(position) = names.iter().position(|&n| n == item_name)
         && let Some(&def_id) = constants.get(position)
     {
-        return Some(errors::PatternTypo {
+        return Some(diagnostics::PatternTypo {
             span,
             code: with_no_trimmed_paths!(tcx.def_path_str(def_id)),
             kind: "constant",
@@ -275,7 +275,7 @@ fn annotate_mut_binding_to_immutable_binding<'tcx>(
     body_def_id: LocalDefId,
     assignment_span: Span,
     body: &Body<'tcx>,
-) -> Option<errors::UnusedAssignSuggestion> {
+) -> Option<diagnostics::UnusedAssignSuggestion> {
     use rustc_hir as hir;
     use rustc_hir::intravisit::{self, Visitor};
 
@@ -316,7 +316,7 @@ fn annotate_mut_binding_to_immutable_binding<'tcx>(
         Some(mut_ty.ty.span.shrink_to_lo())
     };
 
-    return Some(errors::UnusedAssignSuggestion {
+    return Some(diagnostics::UnusedAssignSuggestion {
         ty_span,
         pre,
         // Span of the `mut` before the binding.
@@ -939,7 +939,7 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
                         .split(&brace_name)
                         .any(|c| matches!(c.chars().next(), Some('}' | ':')))
                 })
-                .map(|&(lit, _)| errors::UnusedVariableStringInterp { lit })
+                .map(|&(lit, _)| diagnostics::UnusedVariableStringInterp { lit })
                 .collect::<Vec<_>>()
         };
 
@@ -997,16 +997,16 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
                 }
 
                 let sugg = if from_macro {
-                    errors::UnusedVariableSugg::NoSugg { span: def_span, name }
+                    diagnostics::UnusedVariableSugg::NoSugg { span: def_span, name }
                 } else {
                     let typo = maybe_suggest_typo();
-                    errors::UnusedVariableSugg::TryPrefix { spans: vec![def_span], name, typo }
+                    diagnostics::UnusedVariableSugg::TryPrefix { spans: vec![def_span], name, typo }
                 };
                 tcx.emit_node_span_lint(
                     lint::builtin::UNUSED_VARIABLES,
                     hir_id,
                     def_span,
-                    errors::UnusedVariable {
+                    diagnostics::UnusedVariable {
                         name,
                         string_interp: maybe_suggest_literal_matching_name(name),
                         sugg,
@@ -1056,7 +1056,7 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
                     lint::builtin::UNUSED_VARIABLES,
                     hir_id,
                     def_span,
-                    errors::UnusedVarAssignedOnly { name, typo },
+                    diagnostics::UnusedVarAssignedOnly { name, typo },
                 );
                 continue;
             }
@@ -1067,7 +1067,7 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
             let any_shorthand = introductions.iter().any(|intro| intro.is_shorthand);
 
             let sugg = if any_shorthand {
-                errors::UnusedVariableSugg::TryIgnore {
+                diagnostics::UnusedVariableSugg::TryIgnore {
                     name: name.to_ident_string(),
                     shorthands: introductions
                         .iter()
@@ -1085,20 +1085,20 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
                         .collect(),
                 }
             } else if from_macro {
-                errors::UnusedVariableSugg::NoSugg { span: def_span, name }
+                diagnostics::UnusedVariableSugg::NoSugg { span: def_span, name }
             } else if !introductions.is_empty() {
                 let typo = maybe_suggest_typo();
-                errors::UnusedVariableSugg::TryPrefix { name, typo, spans: spans.clone() }
+                diagnostics::UnusedVariableSugg::TryPrefix { name, typo, spans: spans.clone() }
             } else {
                 let typo = maybe_suggest_typo();
-                errors::UnusedVariableSugg::TryPrefix { name, typo, spans: vec![def_span] }
+                diagnostics::UnusedVariableSugg::TryPrefix { name, typo, spans: vec![def_span] }
             };
 
             tcx.emit_node_span_lint(
                 lint::builtin::UNUSED_VARIABLES,
                 hir_id,
                 spans,
-                errors::UnusedVariable {
+                diagnostics::UnusedVariable {
                     name,
                     string_interp: maybe_suggest_literal_matching_name(name),
                     sugg,
@@ -1147,7 +1147,7 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
                         .rfind(|(_, overwrite_location)| {
                             location.is_predecessor_of(*overwrite_location, self.body)
                         })
-                        .map(|&(overwrite_span, _)| errors::UnusedAssignOverwrite {
+                        .map(|&(overwrite_span, _)| diagnostics::UnusedAssignOverwrite {
                             assigned_span: source_info.span,
                             overwrite_span,
                             name,
@@ -1190,20 +1190,20 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
                             lint::builtin::UNUSED_ASSIGNMENTS,
                             hir_id,
                             source_info.span,
-                            errors::UnusedAssign { name, overwrite, help, suggestion },
+                            diagnostics::UnusedAssign { name, overwrite, help, suggestion },
                         )
                     }
                     AccessKind::Param => tcx.emit_node_span_lint(
                         lint::builtin::UNUSED_ASSIGNMENTS,
                         hir_id,
                         source_info.span,
-                        errors::UnusedAssignPassed { name },
+                        diagnostics::UnusedAssignPassed { name },
                     ),
                     AccessKind::Capture => tcx.emit_node_span_lint(
                         lint::builtin::UNUSED_ASSIGNMENTS,
                         hir_id,
                         decl_span,
-                        errors::UnusedCaptureMaybeCaptureRef { name },
+                        diagnostics::UnusedCaptureMaybeCaptureRef { name },
                     ),
                 }
             }
diff --git a/compiler/rustc_mir_transform/src/pass_manager.rs b/compiler/rustc_mir_transform/src/pass_manager.rs
@@ -9,7 +9,7 @@ use rustc_session::Session;
 use tracing::trace;
 
 use crate::lint::lint_body;
-use crate::{errors, validate};
+use crate::{diagnostics, validate};
 
 thread_local! {
     /// Maps MIR pass names to a snake case form to match profiling naming style
@@ -255,14 +255,14 @@ fn run_passes_inner<'tcx>(
 
     let mut unknown_found = false;
     for &name in named_passes.difference(&*crate::PASS_NAMES) {
-        tcx.dcx().emit_warn(errors::UnknownPassName { name });
+        tcx.dcx().emit_warn(diagnostics::UnknownPassName { name });
         unknown_found = true;
     }
 
     if unknown_found {
         let mut valid_pass_names = crate::PASS_NAMES.iter().copied().collect::<Vec<_>>();
         valid_pass_names.sort();
-        tcx.dcx().emit_note(errors::ValidPassNames { valid_passes: valid_pass_names.into() });
+        tcx.dcx().emit_note(diagnostics::ValidPassNames { valid_passes: valid_pass_names.into() });
     }
 
     // Verify that no passes are missing from the `declare_passes` invocation

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ impl<'tcx> MirLint<'tcx> for CheckForceInline {`
`26`	`26`	`if let Err(reason) =`
`27`	`27`	`is_inline_valid_on_fn(tcx, def_id).and_then(\|_\| is_inline_valid_on_body(tcx, body))`
`28`	`28`	`{`
`29`		`- tcx.dcx().emit_err(crate::errors::InvalidForceInline {`
	`29`	`+ tcx.dcx().emit_err(crate::diagnostics::InvalidForceInline {`
`30`	`30`	`attr_span,`
`31`	`31`	`callee_span: tcx.def_span(def_id),`
`32`	`32`	`callee: tcx.def_path_str(def_id),`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ use rustc_middle::ty::{self, EarlyBinder, GenericArgsRef, Ty, TyCtxt};`
`7`	`7`	`use rustc_session::lint::builtin::FUNCTION_ITEM_REFERENCES;`
`8`	`8`	`use rustc_span::{Span, Spanned, sym};`
`9`	`9`
`10`		`-use crate::errors;`
	`10`	`+use crate::diagnostics;`
`11`	`11`
`12`	`12`	`pub(super) struct FunctionItemReferences;`
`13`	`13`
`@@ -179,7 +179,7 @@ impl<'tcx> FunctionItemRefChecker<'_, 'tcx> {`
`179`	`179`	`FUNCTION_ITEM_REFERENCES,`
`180`	`180`	`lint_root,`
`181`	`181`	`span,`
`182`		`- errors::FnItemRef { span, sugg, ident },`
	`182`	`+ diagnostics::FnItemRef { span, sugg, ident },`
`183`	`183`	`);`
`184`	`184`	`}`
`185`	`185`	`}`