Skip to content

Commit bdd19d0

Browse files
committed
clarity that the neon extension is present
1 parent 52525bd commit bdd19d0

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

tests/ui/asm/cortex-r82.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ use minicore::*;
2222
* A `/* */` comment indicates that the extension is being tested in the ISA level codegen test
2323
* (`tests/ui/asm/aarch64v8r.rs`)
2424
*
25+
* Note that as we use the hard-float `aarch64v8r-unknown-none` target as the base, the neon
26+
* extension is present (`NEON_FPm=1`). This affects which R82-specific extensions are enabled
27+
* (see "when `NEON_FPm == 1`" note in Cortex-R82 Processor Technical Reference Manual)
28+
*
2529
* ## References:
2630
*
2731
* - Arm Cortex-R82 Processor Technical Reference Manual Revision r3p1 (102670_0301_06_en Issue 6)
@@ -55,7 +59,7 @@ pub fn mandatory_extensions() {
5559
// FEAT_nTLBPA
5660
/* FEAT_CRC32 */
5761
/* FEAT_LSE */
58-
feat_rdm();
62+
feat_rdm(); // mandatory given that NEON_FPm=1
5963
/* FEAT_HPDS */
6064
/* FEAT_PAN */
6165
// FEAT_HAFDBS
@@ -68,20 +72,20 @@ pub fn mandatory_extensions() {
6872
/* FEAT_Debugv8p2 */
6973
/* FEAT_ASMv8p2 */
7074
// FEAT_IESB
71-
feat_fp16();
75+
feat_fp16(); // mandatory given that NEON_FPm=1
7276
// FEAT_PCSRv8p2
73-
feat_dotprod();
74-
feat_fhm();
77+
feat_dotprod(); // mandatory given that NEON_FPm=1
78+
feat_fhm(); // mandatory given that NEON_FPm=1
7579
feat_dpb2();
7680
/* FEAT_PAuth */
7781
// FEAT_PACQARMA3
7882
// FEAT_PAuth2
7983
// FEAT_FPAC
8084
// FEAT_FPACCOMBINE
8185
// FEAT_CONSTPACFIELD
82-
feat_jscvt();
86+
feat_jscvt(); // mandatory given that NEON_FPm=1
8387
/* FEAT_LRCPC */
84-
feat_fcma();
88+
feat_fcma(); // mandatory given that NEON_FPm=1
8589
// FEAT_DoPD
8690
// FEAT_SEL2
8791
/* FEAT_S2FWB */

0 commit comments

Comments
 (0)