Skip to content

Commit c179e66

Browse files
committed
fix comments
1 parent c652d9d commit c179e66

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

  • compiler/rustc_trait_selection/src/traits

compiler/rustc_trait_selection/src/traits/mod.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -300,14 +300,10 @@ fn do_normalize_predicates<'tcx>(
300300
Ok(predicates) => Ok(predicates),
301301
Err(fixup_err) => {
302302
// If we encounter a fixup error, it means that some type
303-
// variable wound up unconstrained. I actually don't know
304-
// if this can happen, and I certainly don't expect it to
305-
// happen often, but if it did happen it probably
306-
// represents a legitimate failure due to some kind of
307-
// unconstrained variable.
308-
//
309-
// @lcnr: Let's still ICE here for now. I want a test case
310-
// for that.
303+
// variable wound up unconstrained. That can happen for
304+
// ill-formed impls, so we delay a bug here instead of
305+
// immediately ICEing and let type checking report the
306+
// actual user-facing errors.
311307
Err(tcx.dcx().span_delayed_bug(
312308
span,
313309
format!("inference variables in normalized parameter environment: {fixup_err}"),

0 commit comments

Comments
 (0)