reduce unreachable-code churn after todo!()

Author: llogiq

compiler/rustc_borrowck/src/places_conflict.rs

@@ -286,7 +286,8 @@ fn place_components_conflict<'tcx>(
 
 // Given that the bases of `elem1` and `elem2` are always either equal
 // or disjoint (and have the same type!), return the overlap situation
-// between `elem1` and `elem2`.
+// between `elem1` and `elem2`
+#[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
 fn place_projection_conflict<'tcx>(
     tcx: TyCtxt<'tcx>,
     body: &Body<'tcx>,

compiler/rustc_borrowck/src/universal_regions.rs

@@ -373,6 +373,7 @@ impl<'tcx> UniversalRegions<'tcx> {
     /// that this region imposes on others. The methods in this file
     /// handle the part about dumping the inference context internal
     /// state.
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     pub(crate) fn annotate(&self, tcx: TyCtxt<'tcx>, err: &mut Diag<'_, ()>) {
         match self.defining_ty {
             DefiningTy::Closure(def_id, args) => {

compiler/rustc_builtin_macros/src/autodiff.rs

@@ -501,6 +501,7 @@ mod llvm_enzyme {
     // ```
     // std::intrinsics::autodiff(source as fn(..) -> .., diff, (args))
     // ```
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     fn call_autodiff(
         ecx: &ExtCtxt<'_>,
         primal: Ident,

compiler/rustc_codegen_cranelift/src/debuginfo/unwind.rs

@@ -25,6 +25,7 @@ pub(crate) struct UnwindContext {
 }
 
 impl UnwindContext {
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     pub(crate) fn new(module: &mut dyn Module, pic_eh_frame: bool) -> Self {
         let endian = match module.isa().endianness() {
             Endianness::Little => RunTimeEndian::Little,

compiler/rustc_codegen_cranelift/src/intrinsics/llvm_x86.rs

@@ -7,6 +7,7 @@ use crate::inline_asm::{CInlineAsmOperand, codegen_inline_asm_inner};
 use crate::intrinsics::*;
 use crate::prelude::*;
 
+#[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
 pub(super) fn codegen_x86_llvm_intrinsic_call<'tcx>(
     fx: &mut FunctionCx<'_, '_, 'tcx>,
     intrinsic: &str,

compiler/rustc_codegen_cranelift/src/value_and_place.rs

@@ -180,6 +180,7 @@ impl<'tcx> CValue<'tcx> {
         }
     }
 
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     pub(crate) fn value_field(
         self,
         fx: &mut FunctionCx<'_, '_, 'tcx>,
@@ -522,6 +523,7 @@ impl<'tcx> CPlace<'tcx> {
         self.write_cvalue_maybe_transmute(fx, from, "write_cvalue_transmute");
     }
 
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     fn write_cvalue_maybe_transmute(
         self,
         fx: &mut FunctionCx<'_, '_, 'tcx>,

compiler/rustc_codegen_gcc/src/type_of.rs

@@ -56,6 +56,7 @@ impl<'gcc, 'tcx> CodegenCx<'gcc, 'tcx> {
     }
 }
 
+#[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
 fn uncached_gcc_type<'gcc, 'tcx>(
     cx: &CodegenCx<'gcc, 'tcx>,
     layout: TyAndLayout<'tcx>,
@@ -177,6 +178,7 @@ pub trait LayoutGccExt<'tcx> {
 }
 
 impl<'tcx> LayoutGccExt<'tcx> for TyAndLayout<'tcx> {
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     fn is_gcc_immediate(&self) -> bool {
         match self.backend_repr {
             BackendRepr::Scalar(_) | BackendRepr::SimdVector { .. } => true,

compiler/rustc_const_eval/src/interpret/validity.rs

@@ -872,6 +872,7 @@ impl<'rt, 'tcx, M: Machine<'tcx>> ValidityVisitor<'rt, 'tcx, M> {
     /// at that type. Return `true` if the type is indeed primitive.
     ///
     /// Note that not all of these have `FieldsShape::Primitive`, e.g. wide references.
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     fn try_visit_primitive(
         &mut self,
         value: &PlaceTy<'tcx, M::Provenance>,

compiler/rustc_expand/src/expand.rs

@@ -1935,6 +1935,7 @@ impl InvocationCollectorNode for ast::Pat {
             _ => unreachable!(),
         }
     }
+    #[cfg_attr(not(bootstrap), allow(todo_macro_calls))]
     fn as_target(&self) -> Target {
         todo!();
     }

compiler/rustc_hir_analysis/src/coherence/builtin.rs

@@ -625,7 +625,7 @@ pub(crate) fn coerce_shared_info<'tcx>(
         span,
         Unnormalized::new_wip(trait_ref.args.type_at(1)),
     ) else {
-        todo!("something went wrong with structurally_normalize_ty");
+        panic!("something went wrong with structurally_normalize_ty");
     };
 
     let param_env = tcx.param_env(impl_did);