Rollup merge of #158060 - zedddie:gsoc-batch-10-meow, r=Kivooeo

jhpratt · web-flow · commit e4b9a03ece83 · 2026-06-24T00:40:25.000-04:00
Reorganize `tests/ui/issues` [10/N] Part of [GSoC'26 project](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Project.3A.20Reorganizing.20tests.2Fui.2Fissues) r? Kivooeo @Teapot4195
diff --git a/tests/ui/array-slice-vec/eval-array-expr.rs b/tests/ui/array-slice-vec/eval-array-expr.rs
@@ -0,0 +1,12 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/23354>.
+//! Check expr in [expr; N] is always being evaluated.
+//!
+//! This used to trigger an LLVM assertion during compilation
+//@ run-fail
+//@ error-pattern:panic evaluated
+//@ needs-subprocess
+
+#[allow(unused_variables)]
+fn main() {
+    let x = [panic!("panic evaluated"); 2];
+}
diff --git a/tests/ui/array-slice-vec/eval-empty-array-expr.rs b/tests/ui/array-slice-vec/eval-empty-array-expr.rs
@@ -1,3 +1,5 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/23354>.
+//! Check expr in [expr; N] is always being evaluated.
 //@ run-fail
 //@ error-pattern:panic evaluated
 //@ needs-subprocess
diff --git a/tests/ui/associated-types/associated-type-unconstrained-lifetime.rs b/tests/ui/associated-types/associated-type-unconstrained-lifetime.rs
@@ -0,0 +1,32 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/22886>.
+//! Test that associated type's inner state cannot be observed past
+//! borrow end via saved reference.
+//!
+//! This was possible as trait implementation with unconstrained lifetime
+//! allowed to use any lifetime for associated type, which introduced
+//! soundness holes.
+//!
+//! Fixed by prohibiting use of unconstrained lifetimes on associated types
+//! in <https://github.com/rust-lang/rust/pull/24461>.
+//!
+//! Related <https://github.com/rust-lang/rust/issues/22077>.
+
+fn crash_please() {
+    let mut iter = Newtype(Some(Box::new(0)));
+    let saved = iter.next().unwrap();
+    println!("{}", saved);
+    iter.0 = None;
+    println!("{}", saved);
+}
+
+struct Newtype(Option<Box<usize>>);
+
+impl<'a> Iterator for Newtype { //~ ERROR E0207
+    type Item = &'a Box<usize>;
+
+    fn next(&mut self) -> Option<&Box<usize>> {
+        self.0.as_ref()
+    }
+}
+
+fn main() { }
diff --git a/tests/ui/associated-types/associated-type-unconstrained-lifetime.stderr b/tests/ui/associated-types/associated-type-unconstrained-lifetime.stderr
@@ -1,5 +1,5 @@
 error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
-  --> $DIR/issue-22886.rs:13:6
+  --> $DIR/associated-type-unconstrained-lifetime.rs:24:6
    |
 LL | impl<'a> Iterator for Newtype {
    |      ^^ unconstrained lifetime parameter
diff --git a/tests/ui/cast/dyn-any-to-fn-with-missing-generics.rs b/tests/ui/cast/dyn-any-to-fn-with-missing-generics.rs
@@ -1,3 +1,4 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/23024>.
 use std::any::Any;
 
 fn main()
diff --git a/tests/ui/cast/dyn-any-to-fn-with-missing-generics.stderr b/tests/ui/cast/dyn-any-to-fn-with-missing-generics.stderr
@@ -1,5 +1,5 @@
 error[E0658]: the precise format of `Fn`-family traits' type parameters is subject to change
-  --> $DIR/issue-23024.rs:8:39
+  --> $DIR/dyn-any-to-fn-with-missing-generics.rs:9:39
    |
 LL |     println!("{:?}",(vfnfer[0] as dyn Fn)(3));
    |                                       ^^ help: use parenthetical notation instead: `Fn() -> ()`
@@ -9,7 +9,7 @@ LL |     println!("{:?}",(vfnfer[0] as dyn Fn)(3));
    = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date
 
 error[E0107]: missing generics for trait `Fn`
-  --> $DIR/issue-23024.rs:8:39
+  --> $DIR/dyn-any-to-fn-with-missing-generics.rs:9:39
    |
 LL |     println!("{:?}",(vfnfer[0] as dyn Fn)(3));
    |                                       ^^ expected 1 generic argument
diff --git a/tests/ui/dst/match-dst-struct.rs b/tests/ui/dst/match-dst-struct.rs
@@ -1,5 +1,6 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/23261>.
+//! Matching on a DST struct should not trigger an LLVM assertion.
 //@ run-pass
-// Matching on a DST struct should not trigger an LLVM assertion.
 
 struct Foo<T: ?Sized> {
     a: i32,
diff --git a/tests/ui/higher-ranked/leak-check/trait-object-assoc-type-bound-unsatisfied.rs b/tests/ui/higher-ranked/leak-check/trait-object-assoc-type-bound-unsatisfied.rs
@@ -1,3 +1,5 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/22872>.
+
 trait Wrap<'b> {
     fn foo(&'b mut self);
 }
diff --git a/tests/ui/higher-ranked/leak-check/trait-object-assoc-type-bound-unsatisfied.stderr b/tests/ui/higher-ranked/leak-check/trait-object-assoc-type-bound-unsatisfied.stderr
@@ -1,12 +1,12 @@
 error[E0277]: `<P as Process<'_>>::Item` is not an iterator
-  --> $DIR/issue-22872.rs:20:40
+  --> $DIR/trait-object-assoc-type-bound-unsatisfied.rs:22:40
    |
 LL |     let _: Box<dyn for<'b> Wrap<'b>> = Box::new(Wrapper(process));
    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ `<P as Process<'_>>::Item` is not an iterator
    |
    = help: the trait `Iterator` is not implemented for `<P as Process<'_>>::Item`
 note: required for `Wrapper<P>` to implement `for<'b> Wrap<'b>`
-  --> $DIR/issue-22872.rs:7:13
+  --> $DIR/trait-object-assoc-type-bound-unsatisfied.rs:9:13
    |
 LL | impl<'b, P> Wrap<'b> for Wrapper<P>
    |             ^^^^^^^^     ^^^^^^^^^^
diff --git a/tests/ui/inference/downcast-fn-ptr-placeholder.rs b/tests/ui/inference/downcast-fn-ptr-placeholder.rs
@@ -1,3 +1,6 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/23041>.
+//! Previously ICEd with cat_expr error, fixed by delaying bug.
+
 use std::any::Any;
 fn main()
 {
diff --git a/tests/ui/inference/downcast-fn-ptr-placeholder.stderr b/tests/ui/inference/downcast-fn-ptr-placeholder.stderr
@@ -1,5 +1,5 @@
 error[E0282]: type annotations needed
-  --> $DIR/issue-23041.rs:6:22
+  --> $DIR/downcast-fn-ptr-placeholder.rs:9:22
    |
 LL |     b.downcast_ref::<fn(_)->_>();
    |                      ^^^^^^^^ cannot infer type of the type parameter `T` declared on the method `downcast_ref`
diff --git a/tests/ui/issues/issue-22886.rs b/tests/ui/issues/issue-22886.rs
diff --git a/tests/ui/issues/issue-23311.rs b/tests/ui/issues/issue-23311.rs
diff --git a/tests/ui/issues/issue-23354-2.rs b/tests/ui/issues/issue-23354-2.rs
diff --git a/tests/ui/macros/trait-bound-not-parsed-as-matcher.rs b/tests/ui/macros/trait-bound-not-parsed-as-matcher.rs
@@ -1,3 +1,5 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/22814>.
+
 //@ check-pass
 trait Test {}
 
diff --git a/tests/ui/pattern/match-array-against-slice.rs b/tests/ui/pattern/match-array-against-slice.rs
@@ -0,0 +1,11 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/23311>.
+//! Test that we do not ICE when pattern matching an array against a slice.
+//@ run-pass
+
+fn main() {
+    match "foo".as_bytes() {
+        b"food" => (),
+        &[b'f', ..] => (),
+        _ => ()
+    }
+}
diff --git a/tests/ui/typeck/match-boxed-fn-entry-type-inference.rs b/tests/ui/typeck/match-boxed-fn-entry-type-inference.rs
@@ -1,3 +1,5 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/22781>.
+
 //@ check-pass
 #![allow(unused_variables)]
 use std::collections::HashMap;
diff --git a/tests/ui/unsized/unsized-slice-element.rs b/tests/ui/unsized/unsized-slice-element.rs
@@ -1,3 +1,5 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/22874>.
+
 struct Table {
     rows: [[String]],
     //~^ ERROR the size for values of type
diff --git a/tests/ui/unsized/unsized-slice-element.stderr b/tests/ui/unsized/unsized-slice-element.stderr
@@ -1,5 +1,5 @@
 error[E0277]: the size for values of type `[String]` cannot be known at compilation time
-  --> $DIR/issue-22874.rs:2:11
+  --> $DIR/unsized-slice-element.rs:4:11
    |
 LL |     rows: [[String]],
    |           ^^^^^^^^^^ doesn't have a size known at compile-time
@@ -8,7 +8,7 @@ LL |     rows: [[String]],
    = note: slice and array elements must have `Sized` type
 
 error[E0277]: the size for values of type `[String]` cannot be known at compilation time
-  --> $DIR/issue-22874.rs:7:6
+  --> $DIR/unsized-slice-element.rs:9:6
    |
 LL |     &table.rows[0]
    |      ^^^^^^^^^^ doesn't have a size known at compile-time

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+//! Regression test for <https://github.com/rust-lang/rust/issues/23354>.`
	`2`	`+//! Check expr in [expr; N] is always being evaluated.`
`1`	`3`	`//@ run-fail`
`2`	`4`	`//@ error-pattern:panic evaluated`
`3`	`5`	`//@ needs-subprocess`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
`2`		`- --> $DIR/issue-22886.rs:13:6`
	`2`	`+ --> $DIR/associated-type-unconstrained-lifetime.rs:24:6`
`3`	`3`	`\|`
`4`	`4`	`LL \| impl<'a> Iterator for Newtype {`
`5`	`5`	`\| ^^ unconstrained lifetime parameter`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+//! Regression test for <https://github.com/rust-lang/rust/issues/23024>.`
`1`	`2`	`use std::any::Any;`
`2`	`3`
`3`	`4`	`fn main()`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error[E0658]: the precise format of `Fn`-family traits' type parameters is subject to change
`2`		`- --> $DIR/issue-23024.rs:8:39`
	`2`	`+ --> $DIR/dyn-any-to-fn-with-missing-generics.rs:9:39`
`3`	`3`	`\|`
`4`	`4`	`LL \| println!("{:?}",(vfnfer[0] as dyn Fn)(3));`
`5`	`5`	\| ^^ help: use parenthetical notation instead: `Fn() -> ()`
`@@ -9,7 +9,7 @@ LL \| println!("{:?}",(vfnfer[0] as dyn Fn)(3));`
`9`	`9`	`= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date`
`10`	`10`
`11`	`11`	error[E0107]: missing generics for trait `Fn`
`12`		`- --> $DIR/issue-23024.rs:8:39`
	`12`	`+ --> $DIR/dyn-any-to-fn-with-missing-generics.rs:9:39`
`13`	`13`	`\|`
`14`	`14`	`LL \| println!("{:?}",(vfnfer[0] as dyn Fn)(3));`
`15`	`15`	`\| ^^ expected 1 generic argument`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+//! Regression test for <https://github.com/rust-lang/rust/issues/22872>.`
	`2`	`+`
`1`	`3`	`trait Wrap<'b> {`
`2`	`4`	`fn foo(&'b mut self);`
`3`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`	`1`	error[E0277]: `<P as Process<'_>>::Item` is not an iterator
`2`		`- --> $DIR/issue-22872.rs:20:40`
	`2`	`+ --> $DIR/trait-object-assoc-type-bound-unsatisfied.rs:22:40`
`3`	`3`	`\|`
`4`	`4`	`LL \| let _: Box<dyn for<'b> Wrap<'b>> = Box::new(Wrapper(process));`
`5`	`5`	\| ^^^^^^^^^^^^^^^^^^^^^^^^^^ `<P as Process<'_>>::Item` is not an iterator
`6`	`6`	`\|`
`7`	`7`	= help: the trait `Iterator` is not implemented for `<P as Process<'_>>::Item`
`8`	`8`	note: required for `Wrapper<P>` to implement `for<'b> Wrap<'b>`
`9`		`- --> $DIR/issue-22872.rs:7:13`
	`9`	`+ --> $DIR/trait-object-assoc-type-bound-unsatisfied.rs:9:13`
`10`	`10`	`\|`
`11`	`11`	`LL \| impl<'b, P> Wrap<'b> for Wrapper<P>`
`12`	`12`	`\| ^^^^^^^^ ^^^^^^^^^^`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
	`1`	`+//! Regression test for <https://github.com/rust-lang/rust/issues/23041>.`
	`2`	`+//! Previously ICEd with cat_expr error, fixed by delaying bug.`
	`3`	`+`
`1`	`4`	`use std::any::Any;`
`2`	`5`	`fn main()`
`3`	`6`	`{`