Don't use field initializers for libc::timespec

This create conflict if the timespec of a target has additional fields.
Use libc::timespec::default() instead

Author: thesummer

library/std/src/sys/fs/unix.rs

@@ -1872,7 +1872,12 @@ fn file_time_to_timespec(time: Option<SystemTime>) -> io::Result<libc::timespec>
             io::ErrorKind::InvalidInput,
             "timestamp is too small to set as a file time",
         )),
-        None => Ok(libc::timespec { tv_sec: 0, tv_nsec: libc::UTIME_OMIT as _ }),
+        None => Ok({
+            let mut ts = libc::timespec::default();
+            ts.tv_sec = 0;
+            ts.tv_nsec = libc::UTIME_OMIT as _;
+            ts
+        }),
     }
 }
 

library/std/src/sys/pal/unix/time.rs

@@ -1,3 +1,4 @@
+use core::mem;
 use core::num::niche_types::Nanoseconds;
 
 use crate::io;
@@ -6,8 +7,12 @@ use crate::time::Duration;
 const NSEC_PER_SEC: u64 = 1_000_000_000;
 
 #[allow(dead_code)] // Used for pthread condvar timeouts
-pub const TIMESPEC_MAX: libc::timespec =
-    libc::timespec { tv_sec: <libc::time_t>::MAX, tv_nsec: 1_000_000_000 - 1 };
+pub const TIMESPEC_MAX: libc::timespec = {
+    let mut ts = unsafe { mem::zeroed::<libc::timespec>() };
+    ts.tv_sec = <libc::time_t>::MAX;
+    ts.tv_nsec = 1_000_000_000 - 1;
+    ts
+};
 
 // This additional constant is only used when calling
 // `libc::pthread_cond_timedwait`.
@@ -164,9 +169,11 @@ impl Timespec {
 
     #[allow(dead_code)]
     pub fn to_timespec(&self) -> Option<libc::timespec> {
-        Some(libc::timespec {
-            tv_sec: self.tv_sec.try_into().ok()?,
-            tv_nsec: self.tv_nsec.as_inner().try_into().ok()?,
+        Some({
+            let mut ts = libc::timespec::default();
+            ts.tv_sec = self.tv_sec.try_into().ok()?;
+            ts.tv_nsec = self.tv_nsec.as_inner().try_into().ok()?;
+            ts
         })
     }
 

library/std/src/sys/thread/unix.rs

@@ -570,10 +570,10 @@ pub fn sleep(dur: Duration) {
     // nanosleep will fill in `ts` with the remaining time.
     unsafe {
         while secs > 0 || nsecs > 0 {
-            let mut ts = libc::timespec {
-                tv_sec: cmp::min(libc::time_t::MAX as u64, secs) as libc::time_t,
-                tv_nsec: nsecs,
-            };
+            let mut ts = libc::timespec::default();
+            ts.tv_sec = cmp::min(libc::time_t::MAX as u64, secs) as libc::time_t;
+            ts.tv_nsec = nsecs;
+
             secs -= ts.tv_sec as u64;
             let ts_ptr = &raw mut ts;
             let r = nanosleep(ts_ptr, ts_ptr);

library/std/src/sys/time/unsupported.rs

@@ -1,5 +1,3 @@
-use crate::time::Duration;
-
 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug, Hash)]
 pub struct Instant(Duration);