Skip to content

Commit fc6f81c

Browse files
author
Ariel Ben-Yehuda
committed
EnforcableMitigation => DeniedPartialMitigation
1 parent b9d09b0 commit fc6f81c

7 files changed

Lines changed: 65 additions & 65 deletions

File tree

compiler/rustc_metadata/src/creader.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use rustc_middle::ty::data_structures::IndexSet;
2525
use rustc_middle::ty::{TyCtxt, TyCtxtFeed};
2626
use rustc_proc_macro::bridge::client::ProcMacro;
2727
use rustc_session::Session;
28-
use rustc_session::config::enforcable_mitigations::EnforcableMitigationLevel;
28+
use rustc_session::config::enforcable_mitigations::DeniedPartialMitigationLevel;
2929
use rustc_session::config::{
3030
CrateType, ExtendedTargetModifierInfo, ExternLocation, Externs, OptionsTargetModifiers,
3131
TargetModifier,
@@ -458,7 +458,7 @@ impl CStore {
458458

459459
pub fn report_session_incompatibilities(&self, tcx: TyCtxt<'_>, krate: &Crate) {
460460
self.report_incompatible_target_modifiers(tcx, krate);
461-
self.report_incompatible_enforcable_mitigations(tcx, krate);
461+
self.report_incompatible_denied_partial_mitigations(tcx, krate);
462462
self.report_incompatible_async_drop_feature(tcx, krate);
463463
}
464464

@@ -483,8 +483,8 @@ impl CStore {
483483
}
484484
}
485485

486-
pub fn report_incompatible_enforcable_mitigations(&self, tcx: TyCtxt<'_>, krate: &Crate) {
487-
let my_mitigations = tcx.sess.gather_enabled_enforcable_mitigations();
486+
pub fn report_incompatible_denied_partial_mitigations(&self, tcx: TyCtxt<'_>, krate: &Crate) {
487+
let my_mitigations = tcx.sess.gather_enabled_denied_partial_mitigations();
488488
let mut my_mitigations: BTreeMap<_, _> =
489489
my_mitigations.iter().map(|mitigation| (mitigation.kind, mitigation)).collect();
490490
for skipped_mitigation in tcx.sess.opts.allowed_partial_mitigations(tcx.sess.edition()) {
@@ -496,12 +496,12 @@ impl CStore {
496496
if data.is_proc_macro_crate() {
497497
continue;
498498
}
499-
let their_mitigations = data.enabled_enforcable_mitigations();
499+
let their_mitigations = data.enabled_denied_partial_mitigations();
500500
for my_mitigation in my_mitigations.values() {
501501
let their_mitigation = their_mitigations
502502
.iter()
503503
.find(|mitigation| mitigation.kind == my_mitigation.kind)
504-
.map_or(EnforcableMitigationLevel::Enabled(false), |m| m.level);
504+
.map_or(DeniedPartialMitigationLevel::Enabled(false), |m| m.level);
505505
if their_mitigation < my_mitigation.level {
506506
let errors = errors_per_mitigation.entry(my_mitigation.kind).or_insert(0);
507507
if *errors >= MAX_ERRORS_PER_MITIGATION {

compiler/rustc_metadata/src/rmeta/decoder.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ use rustc_proc_macro::bridge::client::ProcMacro;
3030
use rustc_serialize::opaque::MemDecoder;
3131
use rustc_serialize::{Decodable, Decoder};
3232
use rustc_session::config::TargetModifier;
33-
use rustc_session::config::enforcable_mitigations::EnforcableMitigation;
33+
use rustc_session::config::enforcable_mitigations::DeniedPartialMitigation;
3434
use rustc_session::cstore::{CrateSource, ExternCrate};
3535
use rustc_span::hygiene::HygieneDecodeContext;
3636
use rustc_span::{
@@ -82,7 +82,7 @@ pub(crate) type CrateNumMap = IndexVec<CrateNum, CrateNum>;
8282
pub(crate) type TargetModifiers = Vec<TargetModifier>;
8383

8484
/// The set of enforcable mitigations (RFC 3855) that are currently enabled for this crate
85-
pub(crate) type EnforcableMitigations = Vec<EnforcableMitigation>;
85+
pub(crate) type DeniedPartialMitigations = Vec<DeniedPartialMitigation>;
8686

8787
pub(crate) struct CrateMetadata {
8888
/// The primary crate data - binary metadata blob.
@@ -965,11 +965,11 @@ impl CrateRoot {
965965
self.target_modifiers.decode(metadata)
966966
}
967967

968-
pub(crate) fn decode_enforcable_mitigations<'a>(
968+
pub(crate) fn decode_denied_partial_mitigations<'a>(
969969
&self,
970970
metadata: &'a MetadataBlob,
971-
) -> impl ExactSizeIterator<Item = EnforcableMitigation> {
972-
self.enforcable_mitigations.decode(metadata)
971+
) -> impl ExactSizeIterator<Item = DeniedPartialMitigation> {
972+
self.denied_partial_mitigations.decode(metadata)
973973
}
974974
}
975975

@@ -1959,8 +1959,8 @@ impl CrateMetadata {
19591959
self.root.decode_target_modifiers(&self.blob).collect()
19601960
}
19611961

1962-
pub(crate) fn enabled_enforcable_mitigations(&self) -> EnforcableMitigations {
1963-
self.root.decode_enforcable_mitigations(&self.blob).collect()
1962+
pub(crate) fn enabled_denied_partial_mitigations(&self) -> DeniedPartialMitigations {
1963+
self.root.decode_denied_partial_mitigations(&self.blob).collect()
19641964
}
19651965

19661966
/// Keep `new_extern_crate` if it looks better in diagnostics

compiler/rustc_metadata/src/rmeta/encoder.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use rustc_middle::ty::codec::TyEncoder;
2727
use rustc_middle::ty::fast_reject::{self, TreatParams};
2828
use rustc_middle::{bug, span_bug};
2929
use rustc_serialize::{Decodable, Decoder, Encodable, Encoder, opaque};
30-
use rustc_session::config::enforcable_mitigations::EnforcableMitigation;
30+
use rustc_session::config::enforcable_mitigations::DeniedPartialMitigation;
3131
use rustc_session::config::{CrateType, OptLevel, TargetModifier};
3232
use rustc_span::hygiene::HygieneEncodeContext;
3333
use rustc_span::{
@@ -716,8 +716,8 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
716716
// `SourceFiles` we actually need to encode.
717717
let source_map = stat!("source-map", || self.encode_source_map());
718718
let target_modifiers = stat!("target-modifiers", || self.encode_target_modifiers());
719-
let enforcable_mitigations =
720-
stat!("enforced-mitigations", || self.encode_enabled_enforcable_mitigations());
719+
let denied_partial_mitigations =
720+
stat!("enforced-mitigations", || self.encode_enabled_denied_partial_mitigations());
721721

722722
let root = stat!("final", || {
723723
let attrs = tcx.hir_krate_attrs();
@@ -763,7 +763,7 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
763763
foreign_modules,
764764
source_map,
765765
target_modifiers,
766-
enforcable_mitigations,
766+
denied_partial_mitigations,
767767
traits,
768768
impls,
769769
incoherent_impls,
@@ -2098,10 +2098,10 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
20982098
self.lazy_array(tcx.sess.opts.gather_target_modifiers())
20992099
}
21002100

2101-
fn encode_enabled_enforcable_mitigations(&mut self) -> LazyArray<EnforcableMitigation> {
2101+
fn encode_enabled_denied_partial_mitigations(&mut self) -> LazyArray<DeniedPartialMitigation> {
21022102
empty_proc_macro!(self);
21032103
let tcx = self.tcx;
2104-
self.lazy_array(tcx.sess.gather_enabled_enforcable_mitigations())
2104+
self.lazy_array(tcx.sess.gather_enabled_denied_partial_mitigations())
21052105
}
21062106

21072107
fn encode_lib_features(&mut self) -> LazyArray<(Symbol, FeatureStability)> {

compiler/rustc_metadata/src/rmeta/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ use rustc_middle::ty::fast_reject::SimplifiedType;
3434
use rustc_middle::ty::{self, Ty, TyCtxt, UnusedGenericParams};
3535
use rustc_middle::util::Providers;
3636
use rustc_serialize::opaque::FileEncoder;
37-
use rustc_session::config::enforcable_mitigations::EnforcableMitigation;
37+
use rustc_session::config::enforcable_mitigations::DeniedPartialMitigation;
3838
use rustc_session::config::{SymbolManglingVersion, TargetModifier};
3939
use rustc_session::cstore::{CrateDepKind, ForeignModule, LinkagePreference, NativeLib};
4040
use rustc_span::edition::Edition;
@@ -284,7 +284,7 @@ pub(crate) struct CrateRoot {
284284

285285
source_map: LazyTable<u32, Option<LazyValue<rustc_span::SourceFile>>>,
286286
target_modifiers: LazyArray<TargetModifier>,
287-
enforcable_mitigations: LazyArray<EnforcableMitigation>,
287+
denied_partial_mitigations: LazyArray<DeniedPartialMitigation>,
288288

289289
compiler_builtins: bool,
290290
needs_allocator: bool,

compiler/rustc_metadata/src/rmeta/parameterized.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ trivially_parameterized_over_tcx! {
118118
rustc_middle::ty::adjustment::CoerceUnsizedInfo,
119119
rustc_middle::ty::fast_reject::SimplifiedType,
120120
rustc_session::config::TargetModifier,
121-
rustc_session::config::enforcable_mitigations::EnforcableMitigation,
121+
rustc_session::config::enforcable_mitigations::DeniedPartialMitigation,
122122
rustc_session::cstore::ForeignModule,
123123
rustc_session::cstore::LinkagePreference,
124124
rustc_session::cstore::NativeLib,

compiler/rustc_session/src/options.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ mod desc {
883883
"either a boolean (`yes`, `no`, `on`, `off`, etc), or `nll` (default: `nll`)";
884884
pub(crate) const parse_align: &str = "a number that is a power of 2 between 1 and 2^29";
885885
pub(crate) const parse_allow_partial_mitigations: &str =
886-
super::enforcable_mitigations::EnforcableMitigationKind::KINDS;
886+
super::enforcable_mitigations::DeniedPartialMitigationKind::KINDS;
887887
}
888888

889889
pub mod parse {

compiler/rustc_session/src/options/enforcable_mitigations.rs

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -10,66 +10,66 @@ use crate::config::Options;
1010
use crate::options::CFGuard;
1111

1212
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Encodable, BlobDecodable)]
13-
pub enum EnforcableMitigationLevel {
13+
pub enum DeniedPartialMitigationLevel {
1414
// Enabled(false) should be the bottom of the Ord hierarchy
1515
Enabled(bool),
1616
StackProtector(StackProtector),
1717
}
1818

19-
impl EnforcableMitigationLevel {
19+
impl DeniedPartialMitigationLevel {
2020
pub fn level_str(&self) -> &'static str {
2121
match self {
22-
EnforcableMitigationLevel::StackProtector(StackProtector::All) => "=all",
23-
EnforcableMitigationLevel::StackProtector(StackProtector::Basic) => "=basic",
24-
EnforcableMitigationLevel::StackProtector(StackProtector::Strong) => "=strong",
22+
DeniedPartialMitigationLevel::StackProtector(StackProtector::All) => "=all",
23+
DeniedPartialMitigationLevel::StackProtector(StackProtector::Basic) => "=basic",
24+
DeniedPartialMitigationLevel::StackProtector(StackProtector::Strong) => "=strong",
2525
// currently `=disabled` should not appear
26-
EnforcableMitigationLevel::Enabled(false) => "=disabled",
27-
EnforcableMitigationLevel::StackProtector(StackProtector::None)
28-
| EnforcableMitigationLevel::Enabled(true) => "",
26+
DeniedPartialMitigationLevel::Enabled(false) => "=disabled",
27+
DeniedPartialMitigationLevel::StackProtector(StackProtector::None)
28+
| DeniedPartialMitigationLevel::Enabled(true) => "",
2929
}
3030
}
3131
}
3232

33-
impl std::fmt::Display for EnforcableMitigationLevel {
33+
impl std::fmt::Display for DeniedPartialMitigationLevel {
3434
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
3535
match self {
36-
EnforcableMitigationLevel::StackProtector(StackProtector::All) => {
36+
DeniedPartialMitigationLevel::StackProtector(StackProtector::All) => {
3737
write!(f, "all")
3838
}
39-
EnforcableMitigationLevel::StackProtector(StackProtector::Basic) => {
39+
DeniedPartialMitigationLevel::StackProtector(StackProtector::Basic) => {
4040
write!(f, "basic")
4141
}
42-
EnforcableMitigationLevel::StackProtector(StackProtector::Strong) => {
42+
DeniedPartialMitigationLevel::StackProtector(StackProtector::Strong) => {
4343
write!(f, "strong")
4444
}
45-
EnforcableMitigationLevel::Enabled(true) => {
45+
DeniedPartialMitigationLevel::Enabled(true) => {
4646
write!(f, "enabled")
4747
}
48-
EnforcableMitigationLevel::StackProtector(StackProtector::None)
49-
| EnforcableMitigationLevel::Enabled(false) => {
48+
DeniedPartialMitigationLevel::StackProtector(StackProtector::None)
49+
| DeniedPartialMitigationLevel::Enabled(false) => {
5050
write!(f, "disabled")
5151
}
5252
}
5353
}
5454
}
5555

56-
impl From<bool> for EnforcableMitigationLevel {
56+
impl From<bool> for DeniedPartialMitigationLevel {
5757
fn from(value: bool) -> Self {
58-
EnforcableMitigationLevel::Enabled(value)
58+
DeniedPartialMitigationLevel::Enabled(value)
5959
}
6060
}
6161

62-
impl From<StackProtector> for EnforcableMitigationLevel {
62+
impl From<StackProtector> for DeniedPartialMitigationLevel {
6363
fn from(value: StackProtector) -> Self {
64-
EnforcableMitigationLevel::StackProtector(value)
64+
DeniedPartialMitigationLevel::StackProtector(value)
6565
}
6666
}
6767

68-
pub struct EnforcableMitigationKindParseError;
68+
pub struct DeniedPartialMitigationKindParseError;
6969

7070
#[derive(Copy, Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, Encodable, BlobDecodable)]
7171
pub struct MitigationEnablement {
72-
pub kind: EnforcableMitigationKind,
72+
pub kind: DeniedPartialMitigationKind,
7373
pub enabled: bool,
7474
}
7575

@@ -82,58 +82,58 @@ macro_rules! intersperse {
8282
macro_rules! enforced_mitigations {
8383
([$self:ident] enum $kind:ident {$(($name:ident, $text:expr, $since:ident, $code:expr)),*}) => {
8484
#[derive(Copy, Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, Encodable, BlobDecodable)]
85-
pub enum EnforcableMitigationKind {
85+
pub enum DeniedPartialMitigationKind {
8686
$($name),*
8787
}
8888

89-
impl std::fmt::Display for EnforcableMitigationKind {
89+
impl std::fmt::Display for DeniedPartialMitigationKind {
9090
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
9191
match self {
92-
$(EnforcableMitigationKind::$name => write!(f, $text)),*
92+
$(DeniedPartialMitigationKind::$name => write!(f, $text)),*
9393
}
9494
}
9595
}
9696

97-
impl EnforcableMitigationKind {
97+
impl DeniedPartialMitigationKind {
9898
pub(crate) const KINDS: &'static str = concat!("comma-separated list of mitigation kinds (available: ",
9999
intersperse!(", ", ($(concat!("`", $text, "`")),*)), ")");
100100
}
101101

102-
impl FromStr for EnforcableMitigationKind {
103-
type Err = EnforcableMitigationKindParseError;
102+
impl FromStr for DeniedPartialMitigationKind {
103+
type Err = DeniedPartialMitigationKindParseError;
104104

105-
fn from_str(v: &str) -> Result<EnforcableMitigationKind, EnforcableMitigationKindParseError> {
105+
fn from_str(v: &str) -> Result<DeniedPartialMitigationKind, DeniedPartialMitigationKindParseError> {
106106
match v {
107-
$($text => Ok(EnforcableMitigationKind::$name)),*
107+
$($text => Ok(DeniedPartialMitigationKind::$name)),*
108108
,
109-
_ => Err(EnforcableMitigationKindParseError),
109+
_ => Err(DeniedPartialMitigationKindParseError),
110110
}
111111
}
112112
}
113113

114114
#[allow(unused)]
115-
impl EnforcableMitigationKind {
115+
impl DeniedPartialMitigationKind {
116116
pub fn enforced_since(&self) -> Edition {
117117
match self {
118118
// Should change the enforced-since edition of StackProtector to 2015
119119
// (all editions) when `-C stack-protector` is stabilized.
120-
$(EnforcableMitigationKind::$name => Edition::$since),*
120+
$(DeniedPartialMitigationKind::$name => Edition::$since),*
121121
}
122122
}
123123
}
124124

125125
impl Options {
126-
pub fn all_enforced_mitigations(&self) -> impl Iterator<Item = EnforcableMitigationKind> {
127-
[$(EnforcableMitigationKind::$name),*].into_iter()
126+
pub fn all_enforced_mitigations(&self) -> impl Iterator<Item = DeniedPartialMitigationKind> {
127+
[$(DeniedPartialMitigationKind::$name),*].into_iter()
128128
}
129129
}
130130

131131
impl Session {
132-
pub fn gather_enabled_enforcable_mitigations(&$self) -> Vec<EnforcableMitigation> {
132+
pub fn gather_enabled_denied_partial_mitigations(&$self) -> Vec<DeniedPartialMitigation> {
133133
let mut mitigations = [
134134
$(
135-
EnforcableMitigation {
136-
kind: EnforcableMitigationKind::$name,
135+
DeniedPartialMitigation {
136+
kind: DeniedPartialMitigationKind::$name,
137137
level: From::from($code),
138138
}
139139
),*
@@ -147,25 +147,25 @@ macro_rules! enforced_mitigations {
147147

148148
enforced_mitigations! {
149149
[self]
150-
enum EnforcableMitigationKind {
150+
enum DeniedPartialMitigationKind {
151151
(StackProtector, "stack-protector", EditionFuture, self.stack_protector()),
152152
(ControlFlowGuard, "control-flow-guard", EditionFuture, self.opts.cg.control_flow_guard == CFGuard::Checks)
153153
}
154154
}
155155

156156
/// Enforced mitigations, see [RFC 3855](https://github.com/rust-lang/rfcs/pull/3855)
157157
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Encodable, BlobDecodable)]
158-
pub struct EnforcableMitigation {
159-
pub kind: EnforcableMitigationKind,
160-
pub level: EnforcableMitigationLevel,
158+
pub struct DeniedPartialMitigation {
159+
pub kind: DeniedPartialMitigationKind,
160+
pub level: DeniedPartialMitigationLevel,
161161
}
162162

163163
impl Options {
164164
// Return the list of mitigations that are allowed to be partial
165165
pub fn allowed_partial_mitigations(
166166
&self,
167167
edition: Edition,
168-
) -> impl Iterator<Item = EnforcableMitigationKind> {
168+
) -> impl Iterator<Item = DeniedPartialMitigationKind> {
169169
let mut result: BTreeSet<_> = self
170170
.all_enforced_mitigations()
171171
.filter(|mitigation| mitigation.enforced_since() > edition)

0 commit comments

Comments
 (0)