UI tests that execute don't include the stdout/err of the executed program in the error message if they fail

[khuey]

If the test executes, we get a new ProcRes from executing the test and we call get_output on that to get the output to pass into check_all_error_patterns.

rust/src/tools/compiletest/src/runtest/ui.rs

Line 130 in 3d86494

let output_to_check = if let WillExecute::Yes = should_run {

We continue to pass in the old ProcRes though, so if the test fails, we don't actually print the output we failed to match against. This makes these rather annoying to debug.

[jyn514]

@rustbot label E-easy E-help-wanted

[ilyaaay]

@jyn514 Hi. I want to take this issue.

[jyn514]

@ilyaaay go for it :) see https://rustc-dev-guide.rust-lang.org/rustbot.html#issue-claiming for instructions on how to claim the issue

[ilyaaay]

@rustbot claim

[jieyouxu]

I might be missing something, isn't this //@ check-run-results?

[jyn514]

@jieyouxu that makes the stdout a requirement for the test to pass. this issue is about printing the stdout when the test fails.