Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>` by WaffleLapkin · Pull Request #134021 · rust-lang/rust

WaffleLapkin · 2024-12-08T05:07:27Z

Revival of #124108

bors · 2025-02-06T00:52:13Z

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin · 2025-12-08T14:17:19Z

@scottmcm anything I can do to move this forward?

Mark-Simulacrum

I guess this also needs rebasing + FCP, maybe starting with the FCP makes sense since it's not obvious to me this is worth it (especially if it needs an edition change...)

View changes since this review

theemathas · 2026-06-20T23:33:28Z

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-157814-crater-rollup/retry-regressed-list.txt

craterbot · 2026-06-20T23:33:32Z

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build 83ec5b3
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-06-22T12:45:52Z

🚧 Experiment pr-134021 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-06-22T15:05:39Z

🎉 Experiment pr-134021 is completed!
📊 4 regressed and 0 fixed (14685 total)
📊 607 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-134021/retry-regressed-list.txt ↩

programmerjake · 2026-06-22T17:08:04Z

it looks like static-array 0.5 (the latest version) regressed because boxed_array.into_iter()'s type changed, all the others look like experimental code so are less significant.

WaffleLapkin · 2026-06-23T10:56:33Z

I don't think static-array is used much if at all, so I ~~don't~~ think this can be merged as-is.

(I did submit a PR fixing the issue though: WhyAreAllTheseTaken/static-array#1)

BurntSushi · 2026-06-23T11:16:29Z

@WaffleLapkin I assume you mean it can be merged as-is?

I agree it isn't used much. It does have one dependent though that seems to be active. So I think we should be cautious here.

cc @WhyAreAllTheseTaken see WhyAreAllTheseTaken/static-array#1

WhyAreAllTheseTaken · 2026-06-23T14:50:00Z

@WaffleLapkin I assume you mean it can be merged as-is?

I agree it isn't used much. It does have one dependent though that seems to be active. So I think we should be cautious here.

cc @WhyAreAllTheseTaken see WhyAreAllTheseTaken/static-array#1

I have published a new release to crates.io (0.5.1) with the pull request merged that should resolve the issue.

BurntSushi · 2026-06-23T15:11:46Z

@rfcbot resolve crater

rust-rfcbot · 2026-06-23T15:12:06Z

🔔 This is now entering its final comment period, as per the review above. 🔔

programmerjake · 2026-06-23T16:11:43Z

@WaffleLapkin I assume you mean it can be merged as-is?
I agree it isn't used much. It does have one dependent though that seems to be active. So I think we should be cautious here.
cc @WhyAreAllTheseTaken see WhyAreAllTheseTaken/static-array#1

I have published a new release to crates.io (0.5.1) with the pull request merged that should resolve the issue.

unfortunately that was an incomplete fix: https://github.com/WhyAreAllTheseTaken/static-array/pull/1/changes#r3461196266
the PR missed at least one other a_boxed_array.into_iter() call.

WaffleLapkin · 2026-06-24T14:03:33Z

@WaffleLapkin I assume you mean it can be merged as-is?

@BurntSushi yes, that is what I meant 🤦🏻

WhyAreAllTheseTaken · 2026-06-25T11:31:57Z

@WaffleLapkin I assume you mean it can be merged as-is?
I agree it isn't used much. It does have one dependent though that seems to be active. So I think we should be cautious here.
cc @WhyAreAllTheseTaken see WhyAreAllTheseTaken/static-array#1

I have published a new release to crates.io (0.5.1) with the pull request merged that should resolve the issue.

unfortunately that was an incomplete fix: https://github.com/WhyAreAllTheseTaken/static-array/pull/1/changes#r3461196266 the PR missed at least one other a_boxed_array.into_iter() call.

static-array 0.5.2 is now released which includes WhyAreAllTheseTaken/static-array#3 which should fix the issue.

Mark-Simulacrum · 2026-06-28T16:15:41Z

@bors squash msg="Implement IntoIterator for [&[mut]] Box<[T; N], A>"

Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>

rust-bors · 2026-06-28T16:16:01Z

🔨 6 commits were squashed into 8842949.

rustbot assigned scottmcm Dec 8, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2024

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the box-arr-into-iter2 branch from 6f3a44b to 576e704 Compare December 10, 2024 01:04

This comment has been minimized.

Sign in to view

tgross35 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 13, 2024

WaffleLapkin marked this pull request as ready for review December 16, 2024 19:24

tgross35 added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Dec 19, 2024

scottmcm reviewed Feb 24, 2025

View reviewed changes

Comment thread library/alloc/src/boxed/iter.rs

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2025

This comment was marked as resolved.

Sign in to view

rustbot assigned Mark-Simulacrum and unassigned scottmcm Feb 8, 2026

Mark-Simulacrum requested changes Feb 14, 2026

View reviewed changes

Comment thread library/alloc/src/boxed/iter.rs Outdated

Comment thread library/alloc/src/boxed/iter.rs Outdated

Comment thread library/alloc/src/boxed/iter.rs Outdated

Comment thread tests/ui/iterators/into-iter-on-arrays-lint.stderr

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026

WaffleLapkin force-pushed the box-arr-into-iter2 branch from 6bcd9c3 to 72ea626 Compare March 10, 2026 11:02

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the box-arr-into-iter2 branch from 72ea626 to 366152c Compare March 10, 2026 11:50

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the box-arr-into-iter2 branch 2 times, most recently from 33ce55c to a26c96f Compare March 10, 2026 15:10

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 20, 2026

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 22, 2026

WaffleLapkin mentioned this pull request Jun 23, 2026

fix compilation in future rust versions WhyAreAllTheseTaken/static-array#1

Merged

WhyAreAllTheseTaken mentioned this pull request Jun 23, 2026

Use <Box<[T; N]> as IntoIterator>::IntoIter to avoid an expensive copy when calling into_iter on HeapArray. WhyAreAllTheseTaken/static-array#2

Open

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jun 23, 2026

stepancheg reviewed Jun 27, 2026

View reviewed changes

Comment thread library/alloc/src/boxed/iter.rs Outdated

Mark-Simulacrum reviewed Jun 28, 2026

View reviewed changes

Comment thread library/alloc/src/boxed/iter.rs Outdated

This comment has been minimized.

Sign in to view

Implement for

8842949

Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>

rust-bors Bot force-pushed the box-arr-into-iter2 branch from d1e622f to 8842949 Compare June 28, 2026 16:16

Uh oh!

Uh oh!

Conversation

WaffleLapkin commented Dec 8, 2024 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Feb 6, 2025

Uh oh!

Uh oh!

WaffleLapkin commented Dec 8, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

theemathas commented Jun 20, 2026

Uh oh!

craterbot commented Jun 20, 2026

Uh oh!

craterbot commented Jun 22, 2026

Uh oh!

craterbot commented Jun 22, 2026

Footnotes

Uh oh!

programmerjake commented Jun 22, 2026

Uh oh!

WaffleLapkin commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BurntSushi commented Jun 23, 2026

Uh oh!

WhyAreAllTheseTaken commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BurntSushi commented Jun 23, 2026

Uh oh!

rust-rfcbot commented Jun 23, 2026

Uh oh!

programmerjake commented Jun 23, 2026

Uh oh!

WaffleLapkin commented Jun 24, 2026

Uh oh!

WhyAreAllTheseTaken commented Jun 25, 2026

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum commented Jun 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

WaffleLapkin commented Dec 8, 2024 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading

WaffleLapkin commented Jun 23, 2026 •

edited

Loading

WhyAreAllTheseTaken commented Jun 23, 2026 •

edited

Loading