Skip to content

Add better default spans for the Ty impl of QueryKey#154846

Open
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:ty-def-span
Open

Add better default spans for the Ty impl of QueryKey#154846
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:ty-def-span

Conversation

@Zoxc
Copy link
Copy Markdown
Contributor

@Zoxc Zoxc commented Apr 5, 2026

This add default spans for Ty in its implementation of QueryKey. This is useful so we can get spans for the layout_of query which shows up in cycle errors.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 5, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 5, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
JohnTitor
JohnTitor approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once you fix the failure above

View changes since this review

@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2026
@Zoxc
Copy link
Copy Markdown
Contributor Author

Zoxc commented Apr 10, 2026

Maybe this could just use characteristic_def_id_of_type if we're aiming to remove DefId from ty::Alias. @WaffleLapkin @lcnr Would there be a way to find the DefId / Span associated with the alias if that happens?

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 13, 2026

most aliases will still have an associated DefId, we just want to be able to add ones which don't in the future

@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 4, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zoxc @rustbot @rust-log-analyzer @lcnr @JohnTitor