BufWriter: Note non-obvious safety assumption in BorrowedBuf::set_init usage.#155315
Closed
briansmith wants to merge 1 commit intorust-lang:mainfrom
Closed
BufWriter: Note non-obvious safety assumption in BorrowedBuf::set_init usage.#155315briansmith wants to merge 1 commit intorust-lang:mainfrom
BufWriter: Note non-obvious safety assumption in BorrowedBuf::set_init usage.#155315briansmith wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
briansmith
force-pushed
the
b/bufwriter-realloc-comment
branch
from
d2dc330 to
f28483b
Compare
briansmith
commented
Apr 14, 2026
Contributor
Author
|
PR #155321 is an alternative that makes the logic obviously sound, with some performance risk. |
briansmith
force-pushed
the
b/bufwriter-realloc-comment
branch
2 times, most recently
from
2f20b86 to
5bd2ff3
Compare
Contributor
Author
I updated this PR to document the safety conditions more clearly, and to add comments to I think if PR #155321 can be merged, that is a better alternative. |
briansmith
force-pushed
the
b/bufwriter-realloc-comment
branch
from
5bd2ff3 to
f579d23
Compare
briansmith
force-pushed
the
b/bufwriter-realloc-comment
branch
from
f579d23 to
45459a3
Compare
Contributor
Author
|
Closing in favor of #155321. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC #78485, #117693.