Replace jemalloc bootstrap options with override-allocator#155617
Replace jemalloc bootstrap options with override-allocator#155617Zoxc wants to merge 1 commit intorust-lang:mainfrom
jemalloc bootstrap options with override-allocator#155617Conversation
|
The Miri subtree was changed cc @rust-lang/miri Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu Some changes occurred in src/tools/clippy cc @rust-lang/clippy This PR modifies If appropriate, please update This PR modifies If appropriate, please update The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
0213b60 to
0946ab6
Compare
This comment has been minimized.
This comment has been minimized.
0946ab6 to
fc5ac40
Compare
This comment has been minimized.
This comment has been minimized.
fc5ac40 to
11c97bb
Compare
|
Just renaming this doesn't make sense on its own; the config and the feature handling would have to be split. |
|
The idea was to not expose control over which allocator gets used, so you couldn't specify mimalloc on Linux for example. Do we want to support more than one (on a specific target)? |
|
@rustbot reroll |
|
We'll want different approaches on Linux, macOS and Windows to override the C / Rust allocators. Having a single Cargo feature seems like it will result in less I'd like some feedback on the direction to take here so I can start working on macOS and Windows PRs on top of this. |
|
I feel like there are specific things that we want to do per the selected allocator ( On the other hand, we will either have to try to build all of the allocators on CI to ensure that they still at least build, or risk that the unused OS/allocator combos might go stale and break. |
11c97bb to
ff48fdf
Compare
jemalloc bootstrap options to override-allocatorjemalloc bootstrap options with override-allocator
ff48fdf to
6097bef
Compare
I want to make use of
mimallocon Windows so this renamesjemallocbootstrap options tooverride-allocatorso we can reuse the same flag for this purpose.