Rollup of 21 pull requests by JonathanBrouwer · Pull Request #155979 · rust-lang/rust

JonathanBrouwer · 2026-04-29T21:51:43Z

Successful merges:

miri subtree update #155966 (miri subtree update)
resolve: Extend ambiguous_import_visibilities deprecation lint to glob-vs-glob ambiguities #154149 (resolve: Extend ambiguous_import_visibilities deprecation lint to glob-vs-glob ambiguities)
simd_reduce_min/max: remove float support #155189 (simd_reduce_min/max: remove float support)
Add a missing GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi #155562 (Add a missing GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi)
rustc_middle: Implement the partial_cmp operation for DefIds #155608 (rustc_middle: Implement the partial_cmp operation for DefIds)
When archive format is wrong produce an error instead of ICE #155721 (When archive format is wrong produce an error instead of ICE)
privacy: share effective visibility initialization #155794 (privacy: share effective visibility initialization)
c-variadic: more precise compatibility check in const-eval #155832 (c-variadic: more precise compatibility check in const-eval)
std_detect: support detecting more features on aarch64 Windows #155856 (std_detect: support detecting more features on aarch64 Windows)
Suggest [const] Trait bounds in more places #155861 (Suggest [const] Trait bounds in more places)
dlltool: Set the working directory to workaround --temp-prefix bug #155899 (dlltool: Set the working directory to workaround --temp-prefix bug)
Update with new LLVM 22 target for wasm32-wali-linux-musl target #155916 (Update with new LLVM 22 target for wasm32-wali-linux-musl target)
remap OUT_DIR paths to fix build script path leakage in crate metadata. #155935 (remap OUT_DIR paths to fix build script path leakage in crate metadata. )
use the new //@ needs-asm-mnemonic: ret more #155950 (use the new //@ needs-asm-mnemonic: ret more)
ci(free-disk-space): remove more tools and fix warnings #155958 (ci(free-disk-space): remove more tools and fix warnings)
bump curl-sys and openssl-sys to support OpenSSL 4.0.x #155711 (bump curl-sys and openssl-sys to support OpenSSL 4.0.x)
Add AcceptContext::expect_key_value #155831 (Add AcceptContext::expect_key_value)
Avoid misleading return-type note for foreign Fn callees #155877 (Avoid misleading return-type note for foreign Fn callees)
Update opt_ast_lowering_delayed_lints query to allow "stealing" lints, allowing to use FnOnce instead of Fn #155949 (Update opt_ast_lowering_delayed_lints query to allow "stealing" lints, allowing to use FnOnce instead of Fn)
Make FlatMapInPlaceVec an unsafe trait. #155951 (Make FlatMapInPlaceVec an unsafe trait.)
Fix doc_cfg feature for extern items #155967 (Fix doc_cfg feature for extern items)

The previously pinned versions of openssl-sys and curl-sys are not compatible with OpenSSL 4.0.x. - `curl-sys`: 0.4.84+curl-8.17.0 -> 0.4.87+curl-8.19.0 - `openssl-sys`: 0.9.111 -> 0.9.114

Wire IsProcessorFeaturePresent for the PF_ARM_* constants exposed in Windows SDK 26100 (Win11 24H2): fp16 PF_ARM_V82_FP16_INSTRUCTIONS_AVAILABLE (67) i8mm PF_ARM_V82_I8MM_INSTRUCTIONS_AVAILABLE (66) bf16 PF_ARM_V86_BF16_INSTRUCTIONS_AVAILABLE (68) sha3 PF_ARM_SHA3 (64) AND PF_ARM_SHA512 (65) lse2 PF_ARM_LSE2_AVAILABLE (62) f32mm PF_ARM_SVE_F32MM_INSTRUCTIONS_AVAILABLE (58) f64mm PF_ARM_SVE_F64MM_INSTRUCTIONS_AVAILABLE (59) Also derive `rdm` from FEAT_DotProd. There is no PF_ARM_RDM_* constant; FEAT_DotProd is an optional v8.2-A feature only present on cores that implement at least v8.1-A, and v8.1-A with AdvSIMD mandates FEAT_RDM (Arm ARM K.a §D17.2.91). AdvSIMD is universal on Windows-on-ARM. See PR description for full rationale and .NET 10 precedent. All eight feature names have been stable in `is_aarch64_feature_detected!` on Linux/Darwin/BSD since Rust 1.60.

…pport Add `stat` and `lstat` shims for all Unixes

…g satisfied

…x2var_epi64 Implement `_mm512_permutex2var_epi64` shim

…tifacts

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>

Make FileMetadata track Unix-specific fields as optional data. Advertise STATX_* bits only for metadata that is actually available. Add libc-fs coverage for statx on file paths, file descriptors, and AT_EMPTY_PATH on pipes

…ts, allowing to use `FnOnce` instead of `Fn`

Because the memory safety of `FlatMapInPlace::flat_map_in_place` depends on `FlatMapInPlaceVec` impls behaving correctly.

shims: improve Linux statx

…tcp-proto Allow setting `IPPROTO_TCP` as protocol in `socket` syscall

And use it in `partial_cmp` implementation for visibilities

@JoJoDeveloping

This PR tries to address rust-lang/unsafe-code-guidelines#584 (comment). It is part of a bachelor thesis supervised by @JoJoDeveloping and @RalfJung, for more information, see: https://github.com/user-attachments/files/26537277/Project_Description.pdf. This implements the checking for implicit writes for Tree Borrows. It is disabled by default but can be enabled using the `-Zmiri-tree-borrows-implicit-writes` flag. When it is enabled, Miri inserts a write for all mutable borrows on function entry. This enables the optimization implemented here: rust-lang#155207

tree borrows: implicit writes

JonathanBrouwer · 2026-04-29T21:52:19Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

For debugging help: this rollup consists of:

12 PRs which already passed full CI (but github did a github): Rollup of 12 pull requests #155964
and 9 new PRs: Rollup of 10 pull requests #155975

rust-bors · 2026-04-29T21:52:22Z

📌 Commit d550bd5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 21 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

rust-bors · 2026-04-30T01:13:50Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 19m 42s
Pushing a021a77 to main...

github-actions · 2026-04-30T01:17:05Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c935696 (parent) -> a021a77 (this PR)

Test differences

Show 79 test diffs

Stage 1

[run-make] tests/run-make/archive-corrupt-error: [missing] -> pass (J5)
[run-make] tests/run-make/archive-format-error: [missing] -> pass (J5)
[run-make] tests/run-make/raw-dylib-whitespace: [missing] -> ignore (ignored when dlltool for the current architecture is not present) (J5)
[rustdoc-html] tests/rustdoc-html/doc-cfg/extern-items.rs: [missing] -> pass (J5)
[codegen] tests/codegen-llvm/cffi/c-variadic-naked.rs: ignore (only executed when the architecture is x86_64) -> ignore (skipping test as target does not have ret mnemonic) (J6)

Stage 2

[run-make] tests/run-make/archive-format-error: [missing] -> pass (J0)
[codegen] tests/codegen-llvm/cffi/c-variadic-naked.rs: ignore (only executed when the architecture is x86_64) -> ignore (skipping test as target does not have ret mnemonic) (J1)
[codegen] tests/codegen-llvm/naked-fn/aligned.rs: ignore (ignored when the architecture is arm (no "ret" mnemonic)) -> ignore (skipping test as target does not have ret mnemonic) (J1)
[codegen] tests/codegen-llvm/naked-fn/min-function-alignment.rs: ignore (ignored when the architecture is arm (no "ret" mnemonic)) -> ignore (skipping test as target does not have ret mnemonic) (J1)
[run-make] tests/run-make/raw-dylib-whitespace: [missing] -> pass (J2)
[run-make] tests/run-make/archive-corrupt-error: [missing] -> ignore (ignored when cross-compiling) (J3)
[run-make] tests/run-make/archive-format-error: [missing] -> ignore (only executed when the operating system is linux) (J4)
[run-make] tests/run-make/archive-format-error: [missing] -> ignore (ignored when cross-compiling) (J7)
[run-make] tests/run-make/raw-dylib-whitespace: [missing] -> ignore (ignored when dlltool for the current architecture is not present) (J8)
[run-make] tests/run-make/archive-corrupt-error: [missing] -> pass (J9)
[codegen] tests/codegen-llvm/cffi/c-variadic-naked.rs: ignore (only executed when the architecture is x86_64) -> pass (J10)
[rustdoc-html] tests/rustdoc-html/doc-cfg/extern-items.rs: [missing] -> pass (J11)

Additionally, 62 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a021a7796f66600f46013d6c8d1dfc9e8d7f4a92 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 2h 58m -> 1h 43m (-41.9%)
dist-x86_64-illumos: 2h 39m -> 1h 47m (-32.7%)
dist-ohos-aarch64: 1h 48m -> 1h 15m (-30.3%)
dist-ohos-x86_64: 1h 47m -> 1h 17m (-27.7%)
dist-ohos-armv7: 1h 37m -> 1h 11m (-26.9%)
dist-x86_64-freebsd: 1h 59m -> 1h 28m (-25.7%)
dist-android: 22m 53s -> 28m 7s (+22.9%)
armhf-gnu: 1h 11m -> 1h 28m (+22.8%)
dist-x86_64-msvc-alt: 2h 49m -> 2h 10m (-22.7%)
dist-aarch64-llvm-mingw: 2h 3m -> 1h 36m (-21.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-04-30T01:19:19Z

☀️ Try build successful (CI)
Build commit: 7bfe66b (7bfe66bd713a13d63a3ae5d676a68b6a89e0481a, parent: c935696dd07ca51e6fba2f6579919eea2a50863b)

rust-timer · 2026-04-30T01:20:01Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#154149	resolve: Extend `ambiguous_import_visibilities` deprecation…	`1545f4a9fa592fdf43e69d5017841d29bfa0f302` (link)
#155189	simd_reduce_min/max: remove float support	`9d9b5d81f31455d8281d282ff1496af169ffb9ad` (link)
#155562	Add a missing `GenericTypeVisitable`, and avoid having inte…	`96e227ae0f5caf5507ebc82f03bc2e6ef2a96b12` (link)
#155608	rustc_middle: Implement the `partial_cmp` operation for `De…	`78f4a5f27143c459cf33eb169d056dd1e35c8f74` (link)
#155711	bump curl-sys and openssl-sys to support OpenSSL 4.0.x	`89354276c4b0929f2517d93af6f6d00dd2eca3c3` (link)
#155721	When archive format is wrong produce an error instead of ICE	`dfbb869be352dea466c05da787cbbc19e23e54e5` (link)
#155794	privacy: share effective visibility initialization	`71f495b6afcc32d927255af861caecc55da734ea` (link)
#155831	Add `AcceptContext::expect_key_value`	`769f8fca20a62feb4d1eeb0fa3e8bec7e6d8a127` (link)
#155832	c-variadic: more precise compatibility check in const-eval	`6c09fff50b790206adc4256416ffaf3fea05b9f1` (link)
#155856	std_detect: support detecting more features on aarch64 Wind…	`c87ecb3512adf30c4bd56070fe94777901effe99` (link)
#155861	Suggest `[const] Trait` bounds in more places	`528a12a7519955229813ce0ff87de9b434866c2d` (link)
#155877	Avoid misleading return-type note for foreign `Fn` callees	`ec7fc34f5861f58568a9803b6fbdbe0f728255dc` (link)
#155899	`dlltool`: Set the working directory to workaround `--temp-…	`caa3ab65012b9fba9feb89e449d69b387898bde7` (link)
#155916	Update with new LLVM 22 target for `wasm32-wali-linux-musl`…	`be9512b22b779d9fccf31a2652a8c72e85c270dd` (link)
#155935	remap OUT_DIR paths to fix build script path leakage in cra…	`c7b08580225cb5de4de103c7b46d1a0307a7d1d1` (link)
#155949	Update `opt_ast_lowering_delayed_lints` query to allow "ste…	`bd590a93643ab7722354498b67bf7c21131d2084` (link)
#155950	use the new `//@ needs-asm-mnemonic: ret` more	`0259567cafe56530ecb533c2e614cf792e797267` (link)
#155951	Make `FlatMapInPlaceVec` an unsafe trait.	`a14ea7015a9193746c47bbd6a9db06c948933bc1` (link)
#155958	ci(free-disk-space): remove more tools and fix warnings	`5e1cd1c73e1a3ce96b3cfccd42292abae7be70d6` (link)
#155966	miri subtree update	`9db6a9d0d062f8de610216c384f04485fd919da9` (link)
#155967	Fix `doc_cfg` feature for extern items	`4fc61e7d8f37c571dbe7676a625a670fe04d53af` (link)

previous master: c935696dd0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-04-30T01:54:47Z

Finished benchmarking commit (a021a77): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.3%, 0.5%]	12
Improvements ✅ (primary)	-0.6%	[-1.7%, -0.1%]	33
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-0.6%	[-1.7%, -0.1%]	33

Max RSS (memory usage)

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 487.214s -> 480.95s (-1.29%)
Artifact size: 390.94 MiB -> 390.98 MiB (0.01%)

JonathanBrouwer · 2026-04-30T08:35:38Z

Perf is explained by #155794 and #154149

heitbaum and others added 30 commits April 24, 2026 01:08

bump curl-sys and openssl-sys to support OpenSSL 4.0.x

be93271

The previously pinned versions of openssl-sys and curl-sys are not compatible with OpenSSL 4.0.x. - `curl-sys`: 0.4.84+curl-8.17.0 -> 0.4.87+curl-8.19.0 - `openssl-sys`: 0.9.111 -> 0.9.114

borrowck: avoid misleading return-type note for foreign Fn callees

4de0d24

add stat and lstat shims for Linux and all other Unixes

ef8e0c9

minor adjustments

8f298e2

Merge pull request rust-lang#4934 from enricobolzonello/lstat-stat-su…

aebbc55

…pport Add `stat` and `lstat` shims for all Unixes

Suggest const destruct bounds on Drop impls when they are missing

89cfc22

Suggest various missing trait bounds on HostEffect clauses not bein…

61e876f

…g satisfied

Update with new LLVM 22 target for wasm32-wali-linux-target

8b3f6db

Add _mm512_permutex2var_epi64 shim

fdb1e26

Merge pull request rust-lang#4963 from elichai/elichai/_mm512_permute…

74109af

…x2var_epi64 Implement `_mm512_permutex2var_epi64` shim

bootstrap: remap OUT_DIR paths to fix build script path leakage in ar…

e743a4d

…tifacts

Apply suggestion from @bjorn3

26ce8a9

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>

Impl GenericTypeVisitable for FnSigKind

3022538

shims/unix: improve Linux statx metadata handling

ce559d2

Make FileMetadata track Unix-specific fields as optional data. Advertise STATX_* bits only for metadata that is actually available. Add libc-fs coverage for statx on file paths, file descriptors, and AT_EMPTY_PATH on pipes

Update opt_ast_lowering_delayed_lints query to allow "stealing" lin…

fffc4b5

…ts, allowing to use `FnOnce` instead of `Fn`

use the new //@ needs-asm-mnemonic: ret more

44b9251

Fix passing paths with space into dlltool

23c7bf0

Test that raw-dylib works with whitespace paths

6d20c98

Make FlatMapInPlaceVec an unsafe trait.

a940270

Because the memory safety of `FlatMapInPlace::flat_map_in_place` depends on `FlatMapInPlaceVec` impls behaving correctly.

privacy: share effective visibility initialization

89e272c

ci(free-disk-space): remove more tools and fix warnings

e5493ea

feat: allow setting IPPROTO_TCP as protocol in socket syscall

ade1a24

Merge pull request rust-lang#4913 from bourumir-wyngs/bw/statx

e0a3f69

shims: improve Linux statx

Merge pull request rust-lang#4986 from WhySoBad/network-socket-allow-…

a87cc71

…tcp-proto Allow setting `IPPROTO_TCP` as protocol in `socket` syscall

simd_reduce_min/max: remove float support

ad7ddbc

When archive format is wrong produce an error instead of ICE

b784a1c

rustc_middle: Implement the partial_cmp operation for DefIds

66202c8

And use it in `partial_cmp` implementation for visibilities

Merge pull request rust-lang#4947 from quiode/tb-strong-mode

e637e42

tree borrows: implicit writes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot mentioned this pull request Apr 29, 2026

Make retags an implicit part of typed copies #154341

Open

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2026

rust-bors Bot merged commit a021a77 into rust-lang:main Apr 30, 2026
13 checks passed

rustbot added this to the 1.97.0 milestone Apr 30, 2026

This was referenced Apr 30, 2026

-Zstaticlib-hide-internal-symbols and Zstaticlib-rename-internal-symbols: hide/rename internal symbols in staticlibs #155338

Open

experiment: single owner query #155678

Draft

Eliminate lifting #155921

Closed

rustbot added the perf-regression Performance regression. label Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 21 pull requests#155979

Rollup of 21 pull requests#155979
rust-bors[bot] merged 56 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-fjLaCRP

JonathanBrouwer commented Apr 29, 2026

Uh oh!

JonathanBrouwer commented Apr 29, 2026

Uh oh!

rust-bors Bot commented Apr 29, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Apr 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Stage 1

Stage 2

Uh oh!

rust-bors Bot commented Apr 30, 2026

Uh oh!

rust-timer commented Apr 30, 2026

Uh oh!

rust-timer commented Apr 30, 2026

Uh oh!

JonathanBrouwer commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

JonathanBrouwer commented Apr 29, 2026

Uh oh!

JonathanBrouwer commented Apr 29, 2026

Uh oh!

rust-bors Bot commented Apr 29, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Apr 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-bors Bot commented Apr 30, 2026

Uh oh!

rust-timer commented Apr 30, 2026

Uh oh!

rust-timer commented Apr 30, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants