Allow to use Diagnostic directly in SharedContext::emit_lint

[GuillaumeGomez]

Part of #153099.

r? @JonathanBrouwer

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to diagnostic attributes.

cc @mejrs

[JonathanBrouwer]

@bors try @rust-timer queue

[JonathanBrouwer]

r=me if perf is not negative

View changes since this review

[rust-bors]

☀️ Try build successful (CI)
Build commit: 8877e4f (8877e4f2e94ab82536c27e35dec342f51f88eb28, parent: f53b654a8882fd5fc036c4ca7a4ff41ce32497a6)

[rust-timer]

Finished benchmarking commit (8877e4f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.0%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[0.9%, 3.4%]	4
Regressions ❌ (secondary)	3.1%	[2.8%, 3.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[0.9%, 3.4%]	4

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 487.787s -> 493.362s (1.14%)
Artifact size: 390.97 MiB -> 390.96 MiB (-0.00%)

[JonathanBrouwer]

@bors r+ rollup

[rust-bors]

📌 Commit f51cf63 has been approved by JonathanBrouwer

It is now in the queue for this repository.