Rollup of 14 pull requests by JonathanBrouwer · Pull Request #157303 · rust-lang/rust

JonathanBrouwer · 2026-06-02T11:20:57Z

Successful merges:

mark the 'import linkage' statics as unnamed_addr #156467 (mark the 'import linkage' statics as unnamed_addr)
Couple of diagnostics improvements for EII #156923 (Couple of diagnostics improvements for EII)
Enable Enzyme for aarch64-apple-darwin #157240 (Enable Enzyme for aarch64-apple-darwin)
Privacy: tweak macros + more tests #157244 (Privacy: tweak macros + more tests)
miri subtree update #157276 (miri subtree update)
Use a ArrayVec in CastTarget #157130 (Use a ArrayVec in CastTarget)
Add regression test for issue #144888 #157131 (Add regression test for issue ICE: unhandled node Crate(Mod #144888)
Move feature gating to the new attr parsing infrastructure #157195 (Move feature gating to the new attr parsing infrastructure)
rustdoc: Fix trait impl ordering #157233 (rustdoc: Fix trait impl ordering)
tests: adapt for LLVM codegen change #157256 (tests: adapt for LLVM codegen change)
Update books #157265 (Update books)
triagebot.toml: add LawnGnome to libs reviewers #157277 (triagebot.toml: add LawnGnome to libs reviewers)
Clean up attribute target checking diagnostics #157291 (Clean up attribute target checking diagnostics)
Remove unused import from a test #157301 (Remove unused import from a test)

An EII declaration should not result in a crate not being considered unused. A crate which defines an EII will only get removed from the crate graph if the implementation also gets removed. This is not the case in the opposite way, which is why crates containing EII implementations are not considered unused.

This matches the error message for missing #[panic_handler].

…tor-box enforce noalias on custom allocator Box by default

…ted)

windows shims: avoid representing directories as paths

Shim the LoongArch CRC intrinsics

This updates the rust-version file to 8f02e85.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@8f02e85 Filtered ref: rust-lang/miri@f11795e Upstream diff: rust-lang/rust@1f8e04d...8f02e85 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

flock tests: cover the case of asking for both locks on the same file handle

Add support for level-triggered epoll

This updates the rust-version file to 6368fd5.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@6368fd5 Filtered ref: rust-lang/miri@2046455 Upstream diff: rust-lang/rust@8f02e85...6368fd5 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

200ms is an eternity and slows down test execution

Signed-off-by: acegikmoo <rubairakib11@gmail.com>

reduce sleep time in various tests

support prctl on Linux (not just Android)

the aarch64 variant of pclmulqdq, using carryless_mul for polynomial multiplication in GF(2)

…uwer Rollup of 14 pull requests Successful merges: - #156467 (mark the 'import linkage' statics as unnamed_addr) - #156923 (Couple of diagnostics improvements for EII) - #157240 (Enable Enzyme for aarch64-apple-darwin) - #157244 (Privacy: tweak macros + more tests) - #157276 (miri subtree update) - #157130 (Use a `ArrayVec` in `CastTarget`) - #157131 (Add regression test for issue #144888) - #157195 (Move feature gating to the new attr parsing infrastructure) - #157233 (rustdoc: Fix trait impl ordering) - #157256 (tests: adapt for LLVM codegen change) - #157265 (Update books) - #157277 (triagebot.toml: add LawnGnome to libs reviewers) - #157291 (Clean up attribute target checking diagnostics) - #157301 (Remove unused import from a test)

rust-bors · 2026-06-02T12:24:28Z

💔 Test for cdbc8d6 failed: CI. Failed job:

auto - dist-x86_64-netbsd (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-02T12:44:40Z

@bors retry

rust-bors · 2026-06-02T15:56:19Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 23s
Pushing 48f976c to main...

github-actions · 2026-06-02T15:59:22Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4f84d9f (parent) -> 48f976c (this PR)

Test differences

Show 21 test diffs

Stage 1

[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64-llvm-pre-23: [missing] -> pass (J0)
[ui] tests/ui/definition-reachable/field-access.rs: [missing] -> pass (J0)
[ui] tests/ui/definition-reachable/transitive.rs: [missing] -> pass (J0)
[ui] tests/ui/eii/unused_extern_crate.rs: [missing] -> pass (J0)
[ui] tests/ui/privacy/effective-visibilities-macro-2.rs: [missing] -> pass (J0)
[ui] tests/ui/privacy/effective-visibilities-macro.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/unhandled-crate-mod-issue-144888.rs: [missing] -> pass (J0)
[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J1)
[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J6)

Stage 2

[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J2)
[ui] tests/ui/definition-reachable/field-access.rs: [missing] -> pass (J3)
[ui] tests/ui/definition-reachable/transitive.rs: [missing] -> pass (J3)
[ui] tests/ui/eii/unused_extern_crate.rs: [missing] -> pass (J3)
[ui] tests/ui/privacy/effective-visibilities-macro-2.rs: [missing] -> pass (J3)
[ui] tests/ui/privacy/effective-visibilities-macro.rs: [missing] -> pass (J3)
[ui] tests/ui/traits/unhandled-crate-mod-issue-144888.rs: [missing] -> pass (J3)
[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64: pass -> ignore (ignored when the LLVM version 22.1.6 is older than 23.0.0) (J4)
[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J5)
[assembly] tests/assembly-llvm/simd-bitmask.rs#aarch64-llvm-pre-23: [missing] -> pass (J7)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 48f976c7131e76b6a1ba6ba316c90d97ffdfe184 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-msvc-1: 1h 52m -> 2h 47m (+49.4%)
x86_64-gnu-gcc-core-tests: 14m 3s -> 7m 55s (-43.6%)
dist-i686-msvc: 2h 10m -> 1h 25m (-34.5%)
dist-x86_64-freebsd: 1h 35m -> 1h 3m (-34.0%)
dist-apple-various: 1h 22m -> 1h 49m (+32.7%)
i686-gnu-nopt-1: 2h 26m -> 1h 39m (-31.7%)
x86_64-msvc-ext1: 1h 42m -> 2h 11m (+27.9%)
x86_64-gnu-llvm-22-3: 1h 57m -> 1h 28m (-24.9%)
x86_64-msvc-ext2: 1h 56m -> 1h 27m (-24.7%)
dist-x86_64-msvc-alt: 2h 52m -> 2h 10m (-24.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-02T16:00:36Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#156467	mark the 'import linkage' statics as unnamed_addr	`1d1c4bef72f84414e35659aaaa30889b8cc39e6c` (link)
#156923	Couple of diagnostics improvements for EII	`e66e70de9904f60a3207ffb68d7349bd4fad4e6e` (link)
#157130	Use a `ArrayVec` in `CastTarget`	`78559b63f99409cf000537c544d129da02ed970e` (link)
#157131	Add regression test for issue #144888	`8a8eb2c8cd5c4f840e1cb3dc54260a80a9fed98e` (link)
#157195	Move feature gating to the new attr parsing infrastructure	`d08251c3533d78b00d12ccbda78bca691be9deb8` (link)
#157233	rustdoc: Fix trait impl ordering	`0f41b4afb13b15888958eaf98a43d078a2f2b20b` (link)
#157240	Enable Enzyme for aarch64-apple-darwin	`2e18aa45d0b3d0edae5d85b072c4ab95654017c2` (link)
#157244	Privacy: tweak macros + more tests	`95d5059d5494e02c289bf2809fac375df458be22` (link)
#157256	tests: adapt for LLVM codegen change	`0a49595e7139ad0995b45780c9dc17e94c605b90` (link)
#157265	Update books	`dd61c5daac696c40c2c1810be99d5bed3393f525` (link)
#157276	miri subtree update	`3f540ea7b1c0c4666609597da5f2312f143d9618` (link)
#157277	triagebot.toml: add LawnGnome to libs reviewers	`a158874e972937097ce5fad0567bd988f3adbf0a` (link)
#157291	Clean up attribute target checking diagnostics	`1cf8c6f64d66540c62dc7f112154e4bacbcd4e0f` (link)
#157301	Remove unused import from a test	`8072016a527339338e0ca9801ccd8e739fc3f51e` (link)

previous master: 4f84d9fac4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-06-02T16:38:37Z

Finished benchmarking commit (48f976c): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	2
Regressions ❌ (secondary)	0.2%	[0.0%, 0.3%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.1%]	3
All ❌✅ (primary)	0.2%	[0.1%, 0.3%]	2

Max RSS (memory usage)

Results (primary 4.5%, secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.5%	[2.5%, 8.6%]	3
Regressions ❌ (secondary)	4.4%	[2.3%, 6.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.6%	[-9.6%, -1.7%]	5
All ❌✅ (primary)	4.5%	[2.5%, 8.6%]	3

Cycles

Results (primary 2.1%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	4.6%	[2.1%, 9.4%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-8.0%, -1.7%]	4
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 510.625s -> 510.698s (0.01%)
Artifact size: 400.75 MiB -> 400.57 MiB (-0.04%)

RalfJung and others added 30 commits May 11, 2026 21:19

mark the 'import linkage' statics as unnamed_addr

a36a97f

Add item kind to EII not found error

7edaa34

This matches the error message for missing #[panic_handler].

enforce noalias on custom allocator Box by default

973e303

Merge pull request rust-lang#5067 from RalfJung/noalias-custom-alloca…

b40e934

…tor-box enforce noalias on custom allocator Box by default

windows shims: avoid representing directories as paths

cd44d5f

Shim the LoongArch CRC intrinsics

d22cc82

aarch64 crc: better variable names

62cc075

add loongarch64-unknown-linux-gnu target to CI (not officially suppor…

d4442c0

…ted)

Merge pull request rust-lang#5069 from RalfJung/win-dir

53b3a84

windows shims: avoid representing directories as paths

Merge pull request rust-lang#5062 from Gelbpunkt/la64-crc

f737fc3

Shim the LoongArch CRC intrinsics

Prepare for merging from rust-lang/rust

9eea936

This updates the rust-version file to 8f02e85.

Merge pull request rust-lang#5072 from rust-lang/rustup-2026-05-28

617db62

Automatic Rustup

flock tests: cover the case of asking for both locks on the same file

97f91eb

Merge pull request rust-lang#5073 from RalfJung/flock-tests

8bacbc1

flock tests: cover the case of asking for both locks on the same file handle

Add support for level-triggered epoll

b465d66

Merge pull request rust-lang#5071 from WhySoBad/level-triggered-epoll

3504096

Add support for level-triggered epoll

Prepare for merging from rust-lang/rust

366be2e

This updates the rust-version file to 6368fd5.

fmt

b956f21

Merge pull request rust-lang#5077 from rust-lang/rustup-2026-05-30

07bd4cb

Automatic Rustup

Add regression test for unhandled Crate(Mod) ICE

55cb982

reduce sleep times in various tests

22cc43e

200ms is an eternity and slows down test execution

feat: Implement linkat syscall for hardlink support

c48dd01

Signed-off-by: acegikmoo <rubairakib11@gmail.com>

Merge pull request rust-lang#5079 from RalfJung/futex-timing

fa42565

reduce sleep time in various tests

support prctl on Linux (not just Android)

90d167f

Merge pull request rust-lang#5081 from RalfJung/prctl

029cc55

support prctl on Linux (not just Android)

add shim for neon.pmull64

58837e8

the aarch64 variant of pclmulqdq, using carryless_mul for polynomial multiplication in GF(2)

minor cleanup

8b35be8

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 2, 2026

rust-bors Bot merged commit 48f976c into rust-lang:main Jun 2, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 2, 2026

rustbot added the perf-regression Performance regression. label Jun 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 14 pull requests#157303

Rollup of 14 pull requests#157303
rust-bors[bot] merged 81 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-EWrtFmY

JonathanBrouwer commented Jun 2, 2026 •

edited by rustbot

Loading

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 2, 2026

Uh oh!

rust-timer commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 2, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 2, 2026

Uh oh!

rust-timer commented Jun 2, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

JonathanBrouwer commented Jun 2, 2026 •

edited by rustbot

Loading