Skip to content

Couple of work product cleanups#157444

Open
bjorn3 wants to merge 2 commits into
rust-lang:mainfrom
bjorn3:lto_refactors21
Open

Couple of work product cleanups#157444
bjorn3 wants to merge 2 commits into
rust-lang:mainfrom
bjorn3:lto_refactors21

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented Jun 4, 2026

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 4, 2026

The GCC codegen subtree was changed

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 4, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates

@bjorn3 bjorn3 mentioned this pull request Jun 4, 2026
Closed
13 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lqd
lqd approved these changes Jun 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lqd lqd left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me w/doc nit and example backend in tests fixed

View changes since this review

Comment thread compiler/rustc_incremental/src/persist/work_product.rs Outdated
@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the lto_refactors21 branch from 6cf8b80 to 19d28a9 Compare June 7, 2026 10:33
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 7, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3
Copy link
Copy Markdown
Member Author

bjorn3 commented Jun 7, 2026

@bors r=lqd

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026

📌 Commit 19d28a9 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157444 - bjorn3:lto_refactors21, r=lqd
0ea65ed 
Couple of work product cleanups

Part of rust-lang/compiler-team#908
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 7, 2026
Closed
@bjorn3
Copy link
Copy Markdown
Member Author

bjorn3 commented Jun 7, 2026

@bors r-

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026

This pull request was unapproved.

This PR was contained in a rollup (#157569), which was unapproved.

View changes since this unapproval

bjorn3 added 2 commits June 7, 2026 13:24
@bjorn3
Use WorkProductMap instead of FxIndexMap
9419bae 
This is an UnordMap internally. Iteration order for the work product map
should not matter aside from the place it is serialized where sorting by
WorkProductId is sufficient.
@bjorn3
Assert incr comp in copy_cgu_workproduct_to_incr_comp_cache_dir
f484629 
It was already only called when incr comp is enabled and this allows
cleaning up the callers a bit.
@bjorn3 bjorn3 force-pushed the lto_refactors21 branch from 19d28a9 to f484629 Compare June 7, 2026 13:24
@bjorn3
Copy link
Copy Markdown
Member Author

bjorn3 commented Jun 7, 2026

Fixed warning

@bors r=lqd

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026

📌 Commit f484629 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd approved these changes

Assignees

@jackh726 jackh726

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rustbot @rust-log-analyzer @lqd @jackh726