Skip to content

Move cross crate tests into the appropriate folder#157447

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
danieljofficial:move-tests-cross-crate
Jun 8, 2026
Merged

Move cross crate tests into the appropriate folder#157447
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
danieljofficial:move-tests-cross-crate

Conversation

@danieljofficial
Copy link
Copy Markdown
Contributor

@danieljofficial danieljofficial commented Jun 4, 2026 •
edited by rustbot
Loading

View all comments

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of 133895

try-job: armhf-gnu

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 4, 2026

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Jun 5, 2026

cc @zedddie to avoid gsoc work conflicts

@danieljofficial
Copy link
Copy Markdown
Contributor Author

danieljofficial commented Jun 5, 2026

cc @zedddie to avoid gsoc work conflicts

Noted.

jieyouxu
jieyouxu approved these changes Jun 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@bors r+ rollup

View changes since this review

Comment thread tests/ui/issues/issue-2170-exe.rs
Comment thread tests/ui/cross-crate/mut-ref-write-visible-after-unwind.rs Outdated
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 5, 2026

📌 Commit 2b55fda has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026
This was referenced Jun 5, 2026
Open
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157447 - danieljofficial:move-tests-cross-c…
5579661 
…rate, r=jieyouxu

Move cross crate tests into the appropriate folder

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of [133895](rust-lang#133895)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 5, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 5, 2026
@bors
Auto merge of #157481 - JonathanBrouwer:rollup-71vM6Uo, r=JonathanBro…
ec1be75 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #157467 (stdarch subtree update)
 - #156798 (delegation: do not always generate first argument)
 - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`)
 - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages)
 - #157447 (Move cross crate tests into the appropriate folder)
 - #157470 (Avoid ICE when emitting TargetMachine config errors)
 - #157474 (Forbid optimize(none) with inline(always) or inline.)
 - #157475 (Add a smoke test for the optimize attribute.)
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Jun 5, 2026

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157481 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 5, 2026

This pull request was unapproved.

This PR was contained in a rollup (#157481), which was unapproved.

View changes since this unapproval

@danieljofficial
Copy link
Copy Markdown
Contributor Author

danieljofficial commented Jun 5, 2026

💔 I suspect this PR failed tests as part of a rollup @bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157481 (comment)

I can't tell what might've caused this, locally the tests are passing. So I'm a bit confused about what I should change to fix this.

@jieyouxu

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 5, 2026
@bors
Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=<try>
4c58f6e 
Move cross crate tests into the appropriate folder


try-job: armhf-gnu
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Jun 5, 2026 

---- [ui] tests/ui/cross-crate/stable-symbol-hash-for-trait-object-projections.rs stdout ----

error: test did not exit with success! code=Some(127) so test would pass with `run-fail`
status: exit status: 127
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "1" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/auxiliary/libstable_symbol_hash_for_trait_object_projections.so"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/a", waiting for result
------------------------------------------
--- stderr -------------------------------
/tmp/work/test1271/a: error while loading shared libraries: libstable_symbol_hash_for_trait_object_projections.so: cannot open shared object file: No such file or directory
------------------------------------------

---- [ui] tests/ui/cross-crate/stable-symbol-hash-for-trait-object-projections.rs stdout end ----

@danieljofficial danieljofficial force-pushed the move-tests-cross-crate branch from 2b55fda to dc17feb Compare June 5, 2026 15:11
@rust-bors

This comment was marked as outdated.

Sign in to view
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2026
@jieyouxu

This comment was marked as outdated.

Sign in to view
@rust-bors rust-bors Bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 7, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Jun 7, 2026

The queue is starting to get huge, so
@bors rollup=iffy
So this gets merged earlier and is less likely to get kicked out with conflicts again

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157447 - danieljofficial:move-tests-cross-c…
570439c 
…rate, r=jieyouxu

Move cross crate tests into the appropriate folder

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of [133895](rust-lang#133895)

try-job: armhf-gnu
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157447 - danieljofficial:move-tests-cross-c…
4ffc261 
…rate, r=jieyouxu

Move cross crate tests into the appropriate folder

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of [133895](rust-lang#133895)

try-job: armhf-gnu
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157447 - danieljofficial:move-tests-cross-c…
411024b 
…rate, r=jieyouxu

Move cross crate tests into the appropriate folder

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of [133895](rust-lang#133895)

try-job: armhf-gnu
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 7, 2026
Closed
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026

💔 Test for 1456727 failed: CI

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157570 - JonathanBrouwer:rollup-dEcv5PD, r=JonathanBro…
42f153a 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #157447 (Move cross crate tests into the appropriate folder)
 - #145108 (Resolver: Batched Import Resolution)
 - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`)
 - #157289 (Add infallible primitive type lookups to template arg resolver)
 - #157540 (Cleanup and optimize `render_impls`)
 - #157543 (Reorganize `tests/ui/issues` [5/N])
 - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable)
 - #157323 (Document Repeat::last panic behavior)
 - #157545 (Suggest using comma to separate valid attribute list items)
 - #157559 (chore: Update annotate-snippets to 0.12.16)
rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157570 - JonathanBrouwer:rollup-dEcv5PD, r=JonathanBro…
d6819ac 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #157447 (Move cross crate tests into the appropriate folder)
 - #145108 (Resolver: Batched Import Resolution)
 - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`)
 - #157289 (Add infallible primitive type lookups to template arg resolver)
 - #157540 (Cleanup and optimize `render_impls`)
 - #157543 (Reorganize `tests/ui/issues` [5/N])
 - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable)
 - #157323 (Document Repeat::last panic behavior)
 - #157545 (Suggest using comma to separate valid attribute list items)
 - #157559 (chore: Update annotate-snippets to 0.12.16)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157447 - danieljofficial:move-tests-cross-c…
33d9981 
…rate, r=jieyouxu

Move cross crate tests into the appropriate folder

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of [133895](rust-lang#133895)

try-job: armhf-gnu
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2026
@jhpratt
Rollup merge of rust-lang#157447 - danieljofficial:move-tests-cross-c…
3b1cdb2 
…rate, r=jieyouxu

Move cross crate tests into the appropriate folder

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of [133895](rust-lang#133895)

try-job: armhf-gnu
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 7, 2026
Closed
@jhpratt jhpratt mentioned this pull request Jun 7, 2026
Closed
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026 •
edited
Loading

⌛ Testing commit 1e1560b with merge 12abfe6...

Workflow: https://github.com/rust-lang/rust/actions/runs/27105709820

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=jie…
12abfe6 
…youxu

Move cross crate tests into the appropriate folder



Hi, I've returned with a few more reorganized tests. 
r? @jieyouxu 
This is part of [133895](#133895)

try-job: armhf-gnu
@jhpratt jhpratt mentioned this pull request Jun 7, 2026
Merged
@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented Jun 7, 2026

yielding to encompassing rollup

@bors yield

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #157586.

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157586 - jhpratt:rollup-trnbzaA, r=jhpratt
6de1740 
Rollup of 25 pull requests

Successful merges:

 - #157447 (Move cross crate tests into the appropriate folder)
 - #145108 (Resolver: Batched Import Resolution)
 - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`)
 - #157224 (Manually unroll loop in `str::floor_char_boundary`)
 - #157289 (Add infallible primitive type lookups to template arg resolver)
 - #157540 (Cleanup and optimize `render_impls`)
 - #157444 (Couple of work product cleanups)
 - #157543 (Reorganize `tests/ui/issues` [5/N])
 - #153513 (Syntactically reject equality predicates)
 - #155797 (LineWriter: cap write_vectored newline scan to avoid quadratic write_all_vectored)
 - #156155 (macros: report unbound metavariables directly)
 - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable)
 - #156666 (Clarify meaning of ranges in pointer offset docs)
 - #157078 (Document equivalence of `highest_one` and `ilog2` methods on integers)
 - #157129 (ci: update download-artifact action to v8)
 - #157169 (triagebot: Update messages to direct changes to appropriate repositories)
 - #157323 (Document Repeat::last panic behavior)
 - #157370 (Clarify MaybeUninit::zeroed padding docs)
 - #157399 (Silence llbc's output by default to prevent rustc's linker output warning)
 - #157500 (Improve documentation of `align_of` and `Alignment`.)
 - #157545 (Suggest using comma to separate valid attribute list items)
 - #157559 (chore: Update annotate-snippets to 0.12.16)
 - #157560 (In `copy_nonoverlapping`, use `mul nuw nsw` to compute the byte size)
 - #157580 (Importing suggestion reported twice when reporting privacy error)
 - #157581 (Test fixup)
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026 •
edited
Loading

⌛ Testing commit 1e1560b with merge 2218429...

Workflow: https://github.com/rust-lang/rust/actions/runs/27105944494

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=jie…
2218429 
…youxu

Move cross crate tests into the appropriate folder



Hi, I've returned with a few more reorganized tests. 
r? @jieyouxu 
This is part of [133895](#133895)

try-job: armhf-gnu
@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented Jun 7, 2026

@bors yield

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 7, 2026

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #157586.

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157586 - jhpratt:rollup-trnbzaA, r=jhpratt
029c9e1 
Rollup of 25 pull requests

Successful merges:

 - #157447 (Move cross crate tests into the appropriate folder)
 - #145108 (Resolver: Batched Import Resolution)
 - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`)
 - #157224 (Manually unroll loop in `str::floor_char_boundary`)
 - #157289 (Add infallible primitive type lookups to template arg resolver)
 - #157540 (Cleanup and optimize `render_impls`)
 - #157444 (Couple of work product cleanups)
 - #157543 (Reorganize `tests/ui/issues` [5/N])
 - #153513 (Syntactically reject equality predicates)
 - #155797 (LineWriter: cap write_vectored newline scan to avoid quadratic write_all_vectored)
 - #156155 (macros: report unbound metavariables directly)
 - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable)
 - #156666 (Clarify meaning of ranges in pointer offset docs)
 - #157078 (Document equivalence of `highest_one` and `ilog2` methods on integers)
 - #157129 (ci: update download-artifact action to v8)
 - #157169 (triagebot: Update messages to direct changes to appropriate repositories)
 - #157323 (Document Repeat::last panic behavior)
 - #157370 (Clarify MaybeUninit::zeroed padding docs)
 - #157399 (Silence llbc's output by default to prevent rustc's linker output warning)
 - #157500 (Improve documentation of `align_of` and `Alignment`.)
 - #157545 (Suggest using comma to separate valid attribute list items)
 - #157559 (chore: Update annotate-snippets to 0.12.16)
 - #157560 (In `copy_nonoverlapping`, use `mul nuw nsw` to compute the byte size)
 - #157580 (Importing suggestion reported twice when reporting privacy error)
 - #157581 (Test fixup)
@rust-bors rust-bors Bot merged commit f465e61 into rust-lang:main Jun 8, 2026
12 of 14 checks passed
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 8, 2026
@rustbot rustbot added this to the 1.98.0 milestone Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

7 participants

@danieljofficial @rustbot @Kivooeo @JonathanBrouwer @jieyouxu @rust-log-analyzer @jhpratt