compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows#157488

Merged

rust-bors[bot] merged 1 commit into

rust-lang:mainfrom

jieyouxu:jieyouxu/fix/windows-subsystem-hack

Jun 7, 2026

Member

jieyouxu commented Jun 5, 2026 •

edited

Loading

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

rustbot assigned Kobzol

rustbot added A-compiletest A-testsuite S-waiting-on-author T-bootstrap labels

Collaborator

rustbot commented Jun 5, 2026

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

jieyouxu marked this pull request as ready for review

June 5, 2026 15:25

rustbot added S-waiting-on-review and removed S-waiting-on-author labels

Member Author

jieyouxu commented Jun 5, 2026 •

edited

Loading

I tested this locally on MSVC and MINGW64, seems to Work On My Machine ™️. Thanks @Walnut356 for the tip!

Without this, trying to run debuginfo tests w/ lldb (or gdb etc.) on MINGW / MSVC spawns a bunch of stacked windows.

Maybe there's a better way but I'm not finding one yet.

Member

Kobzol commented Jun 5, 2026 •

edited

Loading

I think that this approach is reasonable, and not even so hacky, as far as bootstrap/compiletest hacks usually go. Shouldn't it be only done on Windows though? Seems like now it is applied on all OSes.

Member Author

jieyouxu commented Jun 5, 2026

I think that this approach is reasonable, and not even so hacky, as far as bootstrap/compiletest hacks usually go. Shouldn't it be only done on Windows though? Seems like now it is applied on all OSes.

D'oh I meant to gate it behind windows but then forgor


          compiletest: inject #![windows_subsystem = "windows"] to debuginfo …

f25f4b4

…tests on Windows

So that we don't get a bunch of console windows spawned by the debugger
processes.

jieyouxu force-pushed the jieyouxu/fix/windows-subsystem-hack branch from eb0d8d4 to f25f4b4 Compare

June 5, 2026 15:53

Member Author

jieyouxu commented Jun 5, 2026

Just in case:
@bors try jobs=aarch64-msvc-1,x86_64-msvc-1

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157488 - jieyouxu:jieyouxu/fix/windows-subsystem-hack,…

1514cb6

… r=<try>

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows


try-job: aarch64-msvc-1
try-job: x86_64-msvc-1

Member Author

jieyouxu commented Jun 5, 2026

Pushed an update to gate the attr insertion on... Windows host only (d'oh).

Member Author

jieyouxu commented Jun 5, 2026

NB: Fulgen kindly suggested that we can use CommandExt::creation_flags (https://doc.rust-lang.org/std/os/windows/process/trait.CommandExt.html#tymethod.creation_flags) w/ CREATE_NO_WINDOW. I should check if we can use that instead of -Zcrate-attr.

@rustbot author

rustbot added S-waiting-on-author and removed S-waiting-on-review labels

Contributor

rust-bors Bot commented Jun 5, 2026

☀️ Try build successful (CI)
Build commit: 1514cb6 (1514cb62ddcaae1ed8132e53d8754b0b8c38fc6b, parent: 39ec825c441918a4ae623a9b8840d1ccd446dcff)

Member Author

jieyouxu commented Jun 5, 2026

Actually I thought about this: I think we can go with the -Zcrate-attr approach first, I'll look into the CommandExt approach in parallel. I rather not have all the annoying windows pop-up any time longer than necessary.

@rustbot review

rustbot added S-waiting-on-review and removed S-waiting-on-author labels

Member

Kobzol commented Jun 5, 2026

Thanks!

Contributor

rust-bors Bot commented Jun 5, 2026

📌 Commit f25f4b4 has been approved by Kobzol

It is now in the queue for this repository.

rust-bors Bot added S-waiting-on-bors and removed S-waiting-on-review labels

ShoyuVanilla added a commit to ShoyuVanilla/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

2d52708

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

ShoyuVanilla mentioned this pull request

Rollup of 3 pull requests #157520

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

7c7d28d

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

jhpratt mentioned this pull request

Rollup of 5 pull requests #157522

Closed

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157522 - jhpratt:rollup-scTvYPX, r=jhpratt

6d045f2

Rollup of 5 pull requests

Successful merges:

 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #156136 (Move tests box)
 - #157494 (Convert `QueryRegionConstraint` into a struct)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

26ccb97

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

JonathanBrouwer mentioned this pull request

Rollup of 8 pull requests #157525

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

16462b0

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

JonathanBrouwer mentioned this pull request

Rollup of 10 pull requests #157528

Closed

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157528 - JonathanBrouwer:rollup-GdcbzFn, r=JonathanBro…

5b4af39

…uwer

Rollup of 10 pull requests

Successful merges:

 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157289 (Add infallible primitive type lookups to template arg resolver)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

a2965da

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

JonathanBrouwer mentioned this pull request

Rollup of 10 pull requests #157530

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

5ca070d

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

JonathanBrouwer mentioned this pull request

Rollup of 17 pull requests #157536

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

c566ce0

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

JonathanBrouwer mentioned this pull request

Rollup of 17 pull requests #157541

Closed

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157541 - JonathanBrouwer:rollup-Kf94s03, r=JonathanBro…

179ed75

…uwer

Rollup of 17 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157541 - JonathanBrouwer:rollup-Kf94s03, r=JonathanBro…

20f0a86

…uwer

Rollup of 17 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157541 - JonathanBrouwer:rollup-Kf94s03, r=JonathanBro…

5e9b677

…uwer

Rollup of 17 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

f74cdd4

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

jhpratt mentioned this pull request

Rollup of 21 pull requests #157554

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#157488 - jieyouxu:jieyouxu/fix/windows-subs…

160651d

…ystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

This was referenced Jun 7, 2026

Rollup of 22 pull requests #157555

Closed

Rollup of 25 pull requests #157558

Merged

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #157558 - jhpratt:rollup-DWtXTfN, r=jhpratt

43a4909

Rollup of 25 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #156573 (Add unwinder_private_data_size for wasm64 target)
 - #156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
 - #156840 (Stabilize `PathBuf::into_string`)
 - #156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157380 (clarify compiler_fence (and fence) docs)
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)
 - #157531 (ci: bump x86_64-gnu base image to 26.04)
 - #157556 (Add `BTree::append()` change to 1.96.0 relnotes)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)

rust-bors Bot merged commit 48c69a9 into rust-lang:main

13 checks passed

rustbot added this to the 1.98.0 milestone

rust-timer added a commit that referenced this pull request


          Unrolled build for #157488

5b027f1

Rollup merge of #157488 - jieyouxu:jieyouxu/fix/windows-subsystem-hack, r=Kobzol

compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows

So that we don't get a bunch of console windows spawned by the debuggees.

r? @Kobzol (or bootstrap/compiler)

jieyouxu deleted the jieyouxu/fix/windows-subsystem-hack branch

June 7, 2026 10:22

pull Bot pushed a commit to asukaminato0721/rust-analyzer that referenced this pull request


          Auto merge of #157558 - jhpratt:rollup-DWtXTfN, r=jhpratt

5935dd5

Rollup of 25 pull requests

Successful merges:

 - rust-lang/rust#157251 (`rust-analyzer` subtree update)
 - rust-lang/rust#157533 (Subtree sync for rustc_codegen_cranelift)
 - rust-lang/rust#154742 (Add APIs for case folding to the standard library)
 - rust-lang/rust#155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - rust-lang/rust#156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
 - rust-lang/rust#157016 (add `extern "tail"` calling convention)
 - rust-lang/rust#157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - rust-lang/rust#157386 (Parse deprecated note links separately in rustc_resolve)
 - rust-lang/rust#157483 (fix windows-gnu TLS leak)
 - rust-lang/rust#157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - rust-lang/rust#157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - rust-lang/rust#157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - rust-lang/rust#156136 (Move tests box)
 - rust-lang/rust#156573 (Add unwinder_private_data_size for wasm64 target)
 - rust-lang/rust#156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
 - rust-lang/rust#156840 (Stabilize `PathBuf::into_string`)
 - rust-lang/rust#156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
 - rust-lang/rust#157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - rust-lang/rust#157380 (clarify compiler_fence (and fence) docs)
 - rust-lang/rust#157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - rust-lang/rust#157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - rust-lang/rust#157494 (Convert `QueryRegionConstraint` into a struct)
 - rust-lang/rust#157526 (std tests: skip a slow test on Miri)
 - rust-lang/rust#157531 (ci: bump x86_64-gnu base image to 26.04)
 - rust-lang/rust#157556 (Add `BTree::append()` change to 1.96.0 relnotes)

Failed merges:

 - rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest A-testsuite S-waiting-on-bors T-bootstrap