Skip to content

Convert QueryRegionConstraint into a struct#157494

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Human9000-bit:queryregionconstrains-as-struct
Jun 7, 2026
Merged

Convert QueryRegionConstraint into a struct#157494
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Human9000-bit:queryregionconstrains-as-struct

Conversation

@Human9000-bit
Copy link
Copy Markdown
Member

@Human9000-bit Human9000-bit commented Jun 5, 2026 •
edited
Loading

as per in fixme

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 5, 2026

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 5, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 5, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 21 candidates

ShoyuVanilla
ShoyuVanilla approved these changes Jun 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ShoyuVanilla ShoyuVanilla left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

View changes since this review

@ShoyuVanilla
Copy link
Copy Markdown
Member

ShoyuVanilla commented Jun 6, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 6, 2026

📌 Commit 36742d8 has been approved by ShoyuVanilla

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2026
ShoyuVanilla added a commit to ShoyuVanilla/rust that referenced this pull request Jun 6, 2026
@ShoyuVanilla
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
887ac3e 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@ShoyuVanilla ShoyuVanilla mentioned this pull request Jun 6, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 6, 2026
@jhpratt
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
af392d0 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@jhpratt jhpratt mentioned this pull request Jun 6, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026
@bors
Auto merge of #157522 - jhpratt:rollup-scTvYPX, r=jhpratt
6d045f2 
Rollup of 5 pull requests

Successful merges:

 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #156136 (Move tests box)
 - #157494 (Convert `QueryRegionConstraint` into a struct)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
85b3fd3 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 6, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
da0cdf1 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 6, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026
@bors
Auto merge of #157528 - JonathanBrouwer:rollup-GdcbzFn, r=JonathanBro…
5b4af39 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157289 (Add infallible primitive type lookups to template arg resolver)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
4e6f247 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 6, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
2510236 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 6, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
cc5d686 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 6, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026
@bors
Auto merge of #157541 - JonathanBrouwer:rollup-Kf94s03, r=JonathanBro…
179ed75 
…uwer

Rollup of 17 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)
rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026
@bors
Auto merge of #157541 - JonathanBrouwer:rollup-Kf94s03, r=JonathanBro…
20f0a86 
…uwer

Rollup of 17 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)
rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026
@bors
Auto merge of #157541 - JonathanBrouwer:rollup-Kf94s03, r=JonathanBro…
5e9b677 
…uwer

Rollup of 17 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2026
@jhpratt
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
84a11b0 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
@jhpratt jhpratt mentioned this pull request Jun 7, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2026
@jhpratt
Rollup merge of rust-lang#157494 - Human9000-bit:queryregionconstrain…
d60b0a1 
…s-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
This was referenced Jun 7, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157558 - jhpratt:rollup-DWtXTfN, r=jhpratt
43a4909 
Rollup of 25 pull requests

Successful merges:

 - #157251 (`rust-analyzer` subtree update)
 - #157533 (Subtree sync for rustc_codegen_cranelift)
 - #154742 (Add APIs for case folding to the standard library)
 - #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - #156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
 - #157016 (add `extern "tail"` calling convention)
 - #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - #157386 (Parse deprecated note links separately in rustc_resolve)
 - #157483 (fix windows-gnu TLS leak)
 - #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - #156136 (Move tests box)
 - #156573 (Add unwinder_private_data_size for wasm64 target)
 - #156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
 - #156840 (Stabilize `PathBuf::into_string`)
 - #156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
 - #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - #157380 (clarify compiler_fence (and fence) docs)
 - #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - #157494 (Convert `QueryRegionConstraint` into a struct)
 - #157526 (std tests: skip a slow test on Miri)
 - #157531 (ci: bump x86_64-gnu base image to 26.04)
 - #157556 (Add `BTree::append()` change to 1.96.0 relnotes)

Failed merges:

 - #155527 (Replace printables table with `unicode_data.rs` tables)
@rust-bors rust-bors Bot merged commit 2deeda4 into rust-lang:main Jun 7, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 7, 2026
rust-timer added a commit that referenced this pull request Jun 7, 2026
@rust-timer
Unrolled build for #157494
8e5a0ba 
Rollup merge of #157494 - Human9000-bit:queryregionconstrains-as-struct, r=ShoyuVanilla

Convert `QueryRegionConstraint` into a struct

as per in fixme
pull Bot pushed a commit to asukaminato0721/rust-analyzer that referenced this pull request Jun 7, 2026
@bors
Auto merge of #157558 - jhpratt:rollup-DWtXTfN, r=jhpratt
5935dd5 
Rollup of 25 pull requests

Successful merges:

 - rust-lang/rust#157251 (`rust-analyzer` subtree update)
 - rust-lang/rust#157533 (Subtree sync for rustc_codegen_cranelift)
 - rust-lang/rust#154742 (Add APIs for case folding to the standard library)
 - rust-lang/rust#155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
 - rust-lang/rust#156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
 - rust-lang/rust#157016 (add `extern "tail"` calling convention)
 - rust-lang/rust#157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
 - rust-lang/rust#157386 (Parse deprecated note links separately in rustc_resolve)
 - rust-lang/rust#157483 (fix windows-gnu TLS leak)
 - rust-lang/rust#157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
 - rust-lang/rust#157509 (remove solaris implementation for File::lock, it has the wrong semantics)
 - rust-lang/rust#157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
 - rust-lang/rust#156136 (Move tests box)
 - rust-lang/rust#156573 (Add unwinder_private_data_size for wasm64 target)
 - rust-lang/rust#156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
 - rust-lang/rust#156840 (Stabilize `PathBuf::into_string`)
 - rust-lang/rust#156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
 - rust-lang/rust#157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
 - rust-lang/rust#157380 (clarify compiler_fence (and fence) docs)
 - rust-lang/rust#157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
 - rust-lang/rust#157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
 - rust-lang/rust#157494 (Convert `QueryRegionConstraint` into a struct)
 - rust-lang/rust#157526 (std tests: skip a slow test on Miri)
 - rust-lang/rust#157531 (ci: bump x86_64-gnu base image to 26.04)
 - rust-lang/rust#157556 (Add `BTree::append()` change to 1.96.0 relnotes)

Failed merges:

 - rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Human9000-bit @rustbot @ShoyuVanilla @davidtwco