Rollup of 25 pull requests#157558
Merged
Merged
Conversation
Show `unsafe` in the signature help if applicable
Instead of failing to resolve them, which can be confusing.
`TyKind::Pat` is hit on stable through `core::num::NonZero*` types which use it internally. `TyKind::UnsafeBinder` isn't hit yet, but added for completeness, since has_drop_glue ends up being called on hover.
Handle TyKind::{Pat,UnsafeBinder} in has_drop_glue
Since they can be referenced without the enum, and this prevents autoimport of them.
So they can be autoimported for external crates.
Example
---
```rust
mod module {}
fn foo() { $0::bar }
```
**Before this PR**
```rust
mod module {}
fn foo() { module::::bar }
```
**After this PR**
```rust
mod module {}
fn foo() { module::bar }
```
Co-authored-by: Chayim Refael Friedman <chayimfr@gmail.com>
fix: no complete module colons before exists colons
fix: not complete same name inherent deref methods
Update generated lints
This updates the rust-version file to ba0949a.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@ba0949a Filtered ref: rust-lang/rust-analyzer@1abb476 Upstream diff: rust-lang/rust@8afb6a8...ba0949a This merge was created using https://github.com/rust-lang/josh-sync.
minor: sync from downstream
…fresh internal: Ignore workspace/diagnostic/refresh in slow tests
fix: only ref match non-unknown value items
Co-authored-by: WaterWhisperer <waterwhisperer24@qq.com>
feat(diagnostics): add handler for E0040
Example
---
```rust
macro_rules! id { ($($t:tt)*) => ($($t)*); }
fn foo(data: &i32) {}
fn main() {
let indent = 2i32;
id!(foo(i$0))
}
```
**Before this PR**
```
indent
```
**After this PR**
```
&indent
indent
```
fix: complete ref_match in macro
feat: add diagnostic for E0608
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 61d7280 (parent) -> 43a4909 (this PR) Test differencesShow 1460 test diffsStage 0
Stage 1
Stage 2
(and 134 additional test diffs) Additionally, 1226 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 43a4909ee98ed4d006d9d773f5d94dc58e34f846 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 61d7280f3c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jun 7, 2026
Open
Collaborator
|
Finished benchmarking commit (43a4909): comparison URL. Overall result: ❌ regressions - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 8.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.0%, secondary 1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 514.705s -> 516.093s (0.27%) |
Member
Author
|
The only PR that looks even vaguely perf-related is the MIR one, but that had a perf run done that didn't show anything meaningful. |
Contributor
|
The MIR one had quite a few changes since the last perf run. The Queue is mostly empty, we can try it out. I'll enque the MIR one and maybe some other one that looks suspicious. Maybe the rustc_resolve one? I'll check out a few more. |
Contributor
rustbot
added
the
perf-regression-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust-analyzersubtree update #157251 (rust-analyzersubtree update)Result::map_or_defaultandOption::map_or_default#156222 (StabilizeResult::map_or_defaultandOption::map_or_default)extern "tail"calling convention #157016 (addextern "tail"calling convention)#![windows_subsystem = "windows"]to debuginfo tests on Windows #157488 (compiletest: inject#![windows_subsystem = "windows"]to debuginfo tests on Windows)SyncView::{as_pin => as_pin_ref}#157521 (RenameSyncView::{as_pin => as_pin_ref})Rc::into_rawclickable inRc::increment_strong_countdoc #156783 (docs: makeRc::into_rawclickable inRc::increment_strong_countdoc)PathBuf::into_string#156840 (StabilizePathBuf::into_string)BUILTIN_ATTRIBUTE_MAP#157471 (Debug assert that parsed attributes are in theBUILTIN_ATTRIBUTE_MAP)errors.rsfile todiagnostics.rs(1/N) #157485 (Renameerrors.rsfile todiagnostics.rs(1/N))QueryRegionConstraintinto a struct #157494 (ConvertQueryRegionConstraintinto a struct)BTree::append()change to 1.96.0 relnotes #157556 (AddBTree::append()change to 1.96.0 relnotes)Failed merges:
unicode_data.rstables #155527 (Replace printables table withunicode_data.rstables)r? @ghost
Create a similar rollup