Skip to content

std: use OnceLock for SGX argument storage#158182

Open
joboet wants to merge 1 commit into
rust-lang:mainfrom
joboet:sgx_args_oncelock
Open

std: use OnceLock for SGX argument storage#158182
joboet wants to merge 1 commit into
rust-lang:mainfrom
joboet:sgx_args_oncelock

Conversation

@joboet

@joboet joboet commented Jun 20, 2026

Copy link
Copy Markdown
Member

Just like #158180, using a OnceLock is much better. Though I guess that in this case a static mut would be fine as well...

CC @jethrogb @raoulstrackx @aditijannu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2026
@rustbot

rustbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 12 candidates
  • Random selection from Darksonn, Mark-Simulacrum, clarfonthey, jhpratt

@clarfonthey

Copy link
Copy Markdown
Contributor

Looks reasonable, r=me if the SGX folks can also sign off on this.

@rust-bors

This comment has been minimized.

@joboet joboet force-pushed the sgx_args_oncelock branch from 7cf798c to 88a3c51 Compare June 28, 2026 21:11
@rustbot

rustbot commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants