Skip to content

Make let-else respect macro_rules expr metavariable grouping#158515

Draft
bb1yd wants to merge 1 commit into
rust-lang:mainfrom
bb1yd:let-else-detect-invisible-delimiter
Draft

Make let-else respect macro_rules expr metavariable grouping#158515
bb1yd wants to merge 1 commit into
rust-lang:mainfrom
bb1yd:let-else-detect-invisible-delimiter

Conversation

@bb1yd

@bb1yd bb1yd commented Jun 28, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #147899

@rustbot

rustbot commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 28, 2026
@rustbot

rustbot commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@bb1yd bb1yd changed the title make let-else respect macro_rules expr metavariable grouping Make let-else respect macro_rules expr metavariable grouping Jun 28, 2026
@bb1yd bb1yd marked this pull request as draft June 28, 2026 08:00
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

let-else does not respect macro_rules expr metavariable grouping

3 participants

@bb1yd @rustbot @jackh726