Skip to content

Avoid building rustdoc for tests without doctests#158561

Open
chenyukang wants to merge 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-158299-core-tests-rustdoc
Open

Avoid building rustdoc for tests without doctests#158561
chenyukang wants to merge 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-158299-core-tests-rustdoc

Conversation

@chenyukang

@chenyukang chenyukang commented Jun 29, 2026

Copy link
Copy Markdown
Member

Fixes #158299

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 29, 2026
@rustbot

rustbot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks simple enough! And I improved bootstrap's tracing (#158562) while trying to debug this in a simpler way, so a win-win :)

r? kobzol

View changes since this review

Comment thread src/bootstrap/src/core/builder/tests.rs
@rustbot rustbot assigned Kobzol and unassigned clubby789 Jun 29, 2026
@chenyukang chenyukang force-pushed the yukang-fix-158299-core-tests-rustdoc branch from c454ba9 to 69f0187 Compare June 29, 2026 13:03
@Kobzol

Kobzol commented Jun 29, 2026

Copy link
Copy Markdown
Member

Thank you! You can r=me once CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x test --tests library/core does more work than it needs to

4 participants