Skip to content

Commit 2f1e6b3

Browse files
Add perf triage for this week
1 parent 8fd6b63 commit 2f1e6b3

1 file changed

Lines changed: 88 additions & 0 deletions

File tree

triage/2026/2026-05-17.md

Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
# 2026-05-17 Triage Log
2+
3+
Fewer than usual PRs merged, mostly due to a shorter week than normal and some
4+
CI trouble. Overall a slightly positive week for performance.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [29b75901..281c97c3](https://perf.rust-lang.org/?start=29b7590130c83542a095cdf1323ed0f78eec2bb8&end=281c97c3240a9abd984ca0c6a2cd7389115e80d5&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 1.5%] | 6 |
14+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.0%, 0.3%] | 9 |
15+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.3%, -0.2%] | 30 |
16+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.4%, -0.0%] | 27 |
17+
| All ❌✅ (primary) | -0.3% | [-1.3%, 1.5%] | 36 |
18+
19+
20+
0 Regressions, 0 Improvements, 4 Mixed; 1 of them in rollups
21+
17 artifact comparisons made in total
22+
23+
#### Regressions
24+
25+
No strict regressions this (short) week.
26+
27+
#### Improvements
28+
29+
No strict improvements this (short) week.
30+
31+
#### Mixed
32+
33+
Rollup of 6 pull requests [#156506](https://github.com/rust-lang/rust/pull/156506) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2aabf3ce0569dd7c8c2d2a27944850056dcf2566&end=8b03437a8ffc8f8b01e62ef5fce82a37ada09b12&stat=instructions:u)
34+
35+
| (instructions:u) | mean | range | count |
36+
|:----------------------------------:|:-----:|:--------------:|:-----:|
37+
| Regressions ❌ <br /> (primary) | 1.4% | [1.4%, 1.4%] | 1 |
38+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.0%, 0.1%] | 3 |
39+
| Improvements ✅ <br /> (primary) | - | - | 0 |
40+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.0%, -0.1%] | 9 |
41+
| All ❌✅ (primary) | 1.4% | [1.4%, 1.4%] | 1 |
42+
43+
Kicked off perf builds of two of the contained PRs. It seems possible the
44+
regression is due to `#[inline]` additions in the `core::io` movement PRs,
45+
though.
46+
47+
Split the node_id_to_def_id table into a per-owner table [#138995](https://github.com/rust-lang/rust/pull/138995) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=800892799d7666fe1dc17abd862100a6cf273718&end=ff9a9ea07bdc74e9555126464b02be8ff277f521&stat=instructions:u)
48+
49+
| (instructions:u) | mean | range | count |
50+
|:----------------------------------:|:-----:|:--------------:|:-----:|
51+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 2 |
52+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.5%] | 5 |
53+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 8 |
54+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.3%, -0.0%] | 5 |
55+
| All ❌✅ (primary) | -0.1% | [-0.4%, 0.3%] | 10 |
56+
57+
Quite a bit of effort went into making this as neutral as possible, with the
58+
final status deemed warranted given future benefits. See also [this
59+
comment](https://github.com/rust-lang/rust/pull/138995#issuecomment-4406548798).
60+
61+
DestinationPropagation: compute liveness as ranges instead of traveling bitsets [#156218](https://github.com/rust-lang/rust/pull/156218) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=88ba7fbe0a6eda36e0adbfd0482856f3784031b9&end=d7f14d3d89c39b2c12ed4b9864a0eb2c205d20bc&stat=instructions:u)
62+
63+
| (instructions:u) | mean | range | count |
64+
|:----------------------------------:|:-----:|:--------------:|:-----:|
65+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
66+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 3 |
67+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.3%, -0.2%] | 18 |
68+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.0%] | 16 |
69+
| All ❌✅ (primary) | -0.5% | [-1.3%, 0.1%] | 19 |
70+
71+
tt-muncher is the only regression, and that too in doc + incr-unchanged builds.
72+
Not actually sure this code runs in any of those scenarios... so marking
73+
as triaged, no follow up needed, especially given the improvement overall.
74+
75+
rustdoc: properly support macros with multiple kinds [#152449](https://github.com/rust-lang/rust/pull/152449) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=be326a93323e9b929525b9298f43883ac66b3b2d&end=d3cd04068e406dd961c2fd666c049c3e38930e0a&stat=instructions:u)
76+
77+
| (instructions:u) | mean | range | count |
78+
|:----------------------------------:|:-----:|:--------------:|:-----:|
79+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
80+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
81+
| Improvements ✅ <br /> (primary) | - | - | 0 |
82+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
83+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.3%] | 1 |
84+
85+
> The impact is expected since we added some loops for iterating types for an
86+
> item (even though 99.9% of the time, there is only one type).
87+
88+
(https://github.com/rust-lang/rust/pull/152449#issuecomment-4468468588)

0 commit comments

Comments
 (0)