Skip to content

Commit 4bfa110

Browse files
lqdlqd
authored
Merge pull request #2418 from rust-lang/panstromek-patch-1
Add triage for 2026-03-02
2 parents 1026da5 + 06a788c commit 4bfa110

1 file changed

Lines changed: 167 additions & 0 deletions

File tree

‎triage/2026/2026-03-02.md‎

Lines changed: 167 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,167 @@
1+
# 2026-03-02 Triage Log
2+
3+
A positive week with a few nice improvements coming from query system cleanups.
4+
5+
Triage done by **@panstromek**.
6+
Revision range: [eeb94be7..ddd36bd5](https://perf.rust-lang.org/?start=eeb94be79adc9df7a09ad0b2421f16e60e6d932c&end=ddd36bd57051f796850345b76c17e9402e28a9e4&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
13+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.0%, 0.3%] | 3 |
14+
| Improvements ✅ <br /> (primary) | -0.8% | [-2.1%, -0.1%] | 141 |
15+
| Improvements ✅ <br /> (secondary) | -1.1% | [-6.6%, -0.1%] | 90 |
16+
| All ❌✅ (primary) | -0.8% | [-2.1%, 0.3%] | 142 |
17+
18+
19+
2 Regressions, 5 Improvements, 5 Mixed; 4 of them in rollups
20+
30 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Remove `const FLAGS`. [#152791](https://github.com/rust-lang/rust/pull/152791) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eeb94be79adc9df7a09ad0b2421f16e60e6d932c&end=b3869b94cd1ed4bfa2eb28f301535d5e9599c713&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.5%] | 17 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.6%] | 37 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.5%] | 17 |
33+
34+
Triaged by @nnethercote: "Perf regressions were minor and deemed worthwhile above for the simplicity improvements."
35+
36+
Rollup of 12 pull requests [#153074](https://github.com/rust-lang/rust/pull/153074) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=11ad63a942c380b83a1fbfe5f0ecb1caaad4c7c1&end=58745ca3b05afa82bd5720dd05f3854e674700e0&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:-----:|:--------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 1.9% | [0.2%, 4.9%] | 44 |
41+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 3.3%] | 25 |
42+
| Improvements ✅ <br /> (primary) | - | - | 0 |
43+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.4%] | 1 |
44+
| All ❌✅ (primary) | 1.9% | [0.2%, 4.9%] | 44 |
45+
46+
Already triaged by @JonathanBrouwer. Caused by https://github.com/rust-lang/rust/pull/152679, reverted in https://github.com/rust-lang/rust/pull/153095.
47+
48+
#### Improvements
49+
50+
Improve how `QueryCache`/`QueryState`/`QueryEngine` are stored [#152835](https://github.com/rust-lang/rust/pull/152835) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=859951e3c7c9d0322c39bad49221937455bdffcd&end=11ad63a942c380b83a1fbfe5f0ecb1caaad4c7c1&stat=instructions:u)
51+
52+
| (instructions:u) | mean | range | count |
53+
|:----------------------------------:|:-----:|:--------------:|:-----:|
54+
| Regressions ❌ <br /> (primary) | - | - | 0 |
55+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
56+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.1%] | 5 |
57+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 16 |
58+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.1%] | 5 |
59+
60+
61+
62+
Rollup of 7 pull requests [#153124](https://github.com/rust-lang/rust/pull/153124) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=69b78537fac74de40f009b076bcbbf54b77683ad&end=bb779a91568ac1ee0b8a9dcb6b69219ef30b18a3&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.4%, -0.1%] | 17 |
69+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.9%, -0.1%] | 20 |
70+
| All ❌✅ (primary) | -0.2% | [-0.4%, -0.1%] | 17 |
71+
72+
73+
Rollup of 2 pull requests [#153139](https://github.com/rust-lang/rust/pull/153139) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bb779a91568ac1ee0b8a9dcb6b69219ef30b18a3&end=25396cf54981afd1fa5a7406658b45033106a0d3&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:--------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
79+
| Improvements ✅ <br /> (primary) | -2.0% | [-4.8%, -0.2%] | 42 |
80+
| Improvements ✅ <br /> (secondary) | -0.9% | [-3.2%, -0.2%] | 25 |
81+
| All ❌✅ (primary) | -2.0% | [-4.8%, -0.2%] | 42 |
82+
83+
84+
Revert "Simplify internals of `{Rc,Arc}::default`" [#153108](https://github.com/rust-lang/rust/pull/153108) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=25396cf54981afd1fa5a7406658b45033106a0d3&end=6a979b3e32522049d0acb4a47f7ae44b7c8abfd5&stat=instructions:u)
85+
86+
| (instructions:u) | mean | range | count |
87+
|:----------------------------------:|:-----:|:--------------:|:-----:|
88+
| Regressions ❌ <br /> (primary) | - | - | 0 |
89+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
90+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.7%, -0.3%] | 6 |
91+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.6%, -0.6%] | 1 |
92+
| All ❌✅ (primary) | -0.4% | [-0.7%, -0.3%] | 6 |
93+
94+
95+
Improve the forcing/promotion functions in `DepKindVTable` [#153122](https://github.com/rust-lang/rust/pull/153122) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=024757fea5c9ac50d7cc81f5f3a686d0a3a3cf9e&end=28b5c1cc084d3d21168f034b39c23193a9a7f127&stat=instructions:u)
96+
97+
| (instructions:u) | mean | range | count |
98+
|:----------------------------------:|:-----:|:--------------:|:-----:|
99+
| Regressions ❌ <br /> (primary) | - | - | 0 |
100+
| Regressions ❌ <br /> (secondary) | 1.9% | [1.9%, 1.9%] | 1 |
101+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.7%, -0.3%] | 102 |
102+
| Improvements ✅ <br /> (secondary) | -1.2% | [-6.5%, -0.2%] | 68 |
103+
| All ❌✅ (primary) | -0.8% | [-1.7%, -0.3%] | 102 |
104+
105+
106+
#### Mixed
107+
108+
Rollup of 13 pull requests [#153116](https://github.com/rust-lang/rust/pull/153116) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1ed488274bec5bf5cfe6bf7a1cc089abcc4ebd68&end=f02672cb8bffef88934d31d9044257a4d11e5d1f&stat=instructions:u)
109+
110+
| (instructions:u) | mean | range | count |
111+
|:----------------------------------:|:-----:|:--------------:|:-----:|
112+
| Regressions ❌ <br /> (primary) | 0.5% | [0.3%, 1.0%] | 4 |
113+
| Regressions ❌ <br /> (secondary) | 2.6% | [0.3%, 5.9%] | 5 |
114+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.5%, -0.5%] | 1 |
115+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
116+
| All ❌✅ (primary) | 0.3% | [-0.5%, 1.0%] | 5 |
117+
118+
Already triaged by @JonathanBrouwer, caused by https://github.com/rust-lang/rust/pull/149978, will be addressed by https://github.com/rust-lang/rust/pull/153157.
119+
120+
Prepare NonNull for pattern types [#152702](https://github.com/rust-lang/rust/pull/152702) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f54d591c3116ee7f8ce9321ddeca286810cc142&end=3a70d0349fa378a10c3748f1a48742e61505020f&stat=instructions:u)
121+
122+
| (instructions:u) | mean | range | count |
123+
|:----------------------------------:|:-----:|:--------------:|:-----:|
124+
| Regressions ❌ <br /> (primary) | 0.5% | [0.4%, 0.6%] | 3 |
125+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.5%] | 1 |
126+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.2%] | 3 |
127+
| Improvements ✅ <br /> (secondary) | -1.1% | [-1.1%, -1.1%] | 1 |
128+
| All ❌✅ (primary) | 0.1% | [-0.5%, 0.6%] | 6 |
129+
130+
Slightly worse than pre-merge results, but looks somewhat expected - some tiny regressions in LLVM, a bit of codegen unit shuffling.
131+
132+
refactor(mgca): Change `DefKind::Const` and `DefKind::AssocConst` to have a `is_type_const` flag [#153050](https://github.com/rust-lang/rust/pull/153050) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ba1567989ee7774a1fb53aa680a8e4e8daa0f519&end=38c0de8dcb14d42290042521be9958d37f3fa390&stat=instructions:u)
133+
134+
| (instructions:u) | mean | range | count |
135+
|:----------------------------------:|:-----:|:--------------:|:-----:|
136+
| Regressions ❌ <br /> (primary) | - | - | 0 |
137+
| Regressions ❌ <br /> (secondary) | 0.0% | [0.0%, 0.0%] | 1 |
138+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.8%, -0.2%] | 17 |
139+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.7%, -0.0%] | 10 |
140+
| All ❌✅ (primary) | -0.5% | [-0.8%, -0.2%] | 17 |
141+
142+
Tiny regression in `include-blob` stress test, overall positive.
143+
144+
Optimize dependency file search [#153131](https://github.com/rust-lang/rust/pull/153131) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=80381278a08582356c13b0f52af92d27c567c230&end=e7d90c695a39426baf5ae705de2f9570a72229de&stat=instructions:u)
145+
146+
| (instructions:u) | mean | range | count |
147+
|:----------------------------------:|:-----:|:--------------:|:-----:|
148+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
149+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
150+
| Improvements ✅ <br /> (primary) | - | - | 0 |
151+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.2%] | 7 |
152+
| All ❌✅ (primary) | 0.1% | [0.1%, 0.1%] | 1 |
153+
154+
Triaged by @Kobzol (author): "The regression seems like noise. Tiny wins on large-workspace, matching pre-merge run."
155+
156+
Re-add `#[inline]` to `Eq::assert_fields_are_eq` [#153157](https://github.com/rust-lang/rust/pull/153157) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e7d90c695a39426baf5ae705de2f9570a72229de&end=ddd36bd57051f796850345b76c17e9402e28a9e4&stat=instructions:u)
157+
158+
| (instructions:u) | mean | range | count |
159+
|:----------------------------------:|:-----:|:--------------:|:-----:|
160+
| Regressions ❌ <br /> (primary) | - | - | 0 |
161+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 3 |
162+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.8%, -0.3%] | 4 |
163+
| Improvements ✅ <br /> (secondary) | -3.0% | [-5.6%, -0.4%] | 4 |
164+
| All ❌✅ (primary) | -0.5% | [-0.8%, -0.3%] | 4 |
165+
166+
Net positive, addresses previous regression from https://github.com/rust-lang/rust/pull/153116. Small regression in `derive` stress tests.
167+

0 commit comments

Comments
 (0)