Skip to content

Commit 890574c

Browse files
authored
Merge pull request #2431 from DanielEScherzer/rollup-never-comment
comparison_summary.rs: update comment when not adding rollup=never
2 parents 0b732e0 + ba13f0a commit 890574c

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

site/src/github/comparison_summary.rs

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,13 +352,21 @@ fn try_run_body(is_regression: bool, deserves_attention: bool) -> String {
352352
""
353353
};
354354

355+
// If perf does not deserve attention, don't say that the PR was automatically marked as not fit for rolling up
356+
// But point out that it can be manually marked as such
357+
let rollup_comment = if deserves_attention {
358+
"It's automatically marked not fit for rolling up. \
359+
Overriding is possible but disadvised: \
360+
it risks changing compiler perf."
361+
} else {
362+
"Consider adding rollup=never if this change is not fit for rolling up."
363+
};
364+
355365
let sign = if is_regression { "+" } else { "-" };
356366
format!(
357367
"
358368
Benchmarking means the PR may be perf-sensitive. \
359-
It's automatically marked not fit for rolling up. \
360-
Overriding is possible but disadvised: \
361-
it risks changing compiler perf.{next_steps}
369+
{rollup_comment}{next_steps}
362370
363371
{rollup_never}
364372
@rustbot label: -S-waiting-on-perf {sign}perf-regression",

0 commit comments

Comments
 (0)