Merge pull request #2472 from Kobzol/error-propagation

lqd · web-flow · commit 95b5f9903678 · 2026-05-11T17:52:00.000Z
Show error when comparison comment cannot be posted
diff --git a/site/src/github/comparison_summary.rs b/site/src/github/comparison_summary.rs
@@ -83,7 +83,12 @@ async fn calculate_metric_comparison(
     .await
     {
         Ok(Some(c)) => Ok(c),
-        _ => Err("ERROR categorizing benchmark run!".to_owned()),
+        Ok(None) => {
+            Err("Error occured while categorizing benchmark run (missing comparison).".to_string())
+        }
+        Err(error) => Err(format!(
+            "Error occured while categorizing benchmark run:\n\n```{error}```"
+        )),
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,12 @@ async fn calculate_metric_comparison(`
`83`	`83`	`.await`
`84`	`84`	`{`
`85`	`85`	`Ok(Some(c)) => Ok(c),`
`86`		`- _ => Err("ERROR categorizing benchmark run!".to_owned()),`
	`86`	`+ Ok(None) => {`
	`87`	`+ Err("Error occured while categorizing benchmark run (missing comparison).".to_string())`
	`88`	`+ }`
	`89`	`+ Err(error) => Err(format!(`
	`90`	+ "Error occured while categorizing benchmark run:\n\n```{error}```"
	`91`	`+ )),`
`87`	`92`	`}`
`88`	`93`	`}`
`89`	`94`