Skip to content

github-actions: pin actions to commit SHAs and fix zizmor security findings#2432

Open
Dorcas-BD wants to merge 1 commit intorust-lang:masterfrom
Dorcas-BD:fix/zizmor-non-behavior-changes
Open

github-actions: pin actions to commit SHAs and fix zizmor security findings#2432
Dorcas-BD wants to merge 1 commit intorust-lang:masterfrom
Dorcas-BD:fix/zizmor-non-behavior-changes

Conversation

@Dorcas-BD
Copy link
Copy Markdown
Contributor

Follow-up to #2428 (split as requested by @Kobzol ).

Fixes zizmor security findings that don't change CI behaviour.

Changes:

  • Pin all action references to commit SHAs to fix unpinned-uses
  • Add persist-credentials: false to all actions/checkout steps to fix artipacked
  • Move ${{ toJson(needs) }} to an env variable in the conclusion job to fix template-injection
  • Fix template-injection in nightly.yml by using ${RUSTC_PERF_VERSION} instead of ${{ env.RUSTC_PERF_VERSION }} in shell
  • Add name: to anonymous docker and conclusion jobs to fix anonymous-definition
  • Add explanatory comment to contents: write permission in nightly.yml to fix undocumented-permissions

Note: cache-poisoning findings are not addressed here and will be handled in a separate PR.

@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented Apr 29, 2026

@marcoieni Could you please configure renovatebot here to manage GHA versions, and automatically pin the current versions, to ensure that the commit SHAs are okay? Like we did in bors (IIRC).

@marcoieni
Copy link
Copy Markdown
Member

Done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants