codegen_cranelift: Fix backend limit diagnostics#1673
Merged
bjorn3 merged 3 commits intoJul 6, 2026
Merged
Conversation
bjorn3
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs rust-lang/rust#158827 (comment)
backend impl-limit and verifier errors were using an early diag context inside codegen. that made worker-thread fatals come out weird, and imo i prefer reporting them through the session dcx we already have.
passes the dcx into aot/jit compile_fn calls and uses it for cranelift backend-limit/verifier failures. i dropped the regression after ci showed it also runs under --use-backend llvm, where the sample compiles fine. idk if there is a nicer target-generic reproducer yet; ltm if there is.