Add a workaround for 128 bit switches#668
Merged
Merged
Conversation
056b3ae to
9137de1
Compare
antoyo
reviewed
May 9, 2025
antoyo
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot!
Nice work as always.
A few nitpicks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a libgccjit limitation, 128 bit switches are currently not supported.
As a workaround, this PR:
Effectively, we turn this:
Into this:
This is less efficient than a switch, but it only applies to previously unsupported edge case: 128 bit switches. So, the small perf penalty is acceptable in this case.
Besides that, this PR contains a regression test for this issue, and a few tiny changes to minicore.
Added support for the
black_boxintrinsic - it is strictly necessary for correct tests. Even now, MIR optimizations sometimes optimize the crash I test for away. Usingblack_boxguarantees we will not miss any issues in the future.Added copy impls for
i64,u128, andi128. Theu128impl was needed to properly test 128 bit switches. Adding one fori128too seemed reasonable.