Skip to content

Errored when inline asm contans null bytes#859

Merged
antoyo merged 5 commits intorust-lang:masterfrom
harin-ramesh:null-char-in-asm-issue
Mar 26, 2026
Merged

Errored when inline asm contans null bytes#859
antoyo merged 5 commits intorust-lang:masterfrom
harin-ramesh:null-char-in-asm-issue

Conversation

@harin-ramesh
Copy link
Copy Markdown
Contributor

@harin-ramesh harin-ramesh commented Feb 26, 2026

As per discussion in #838

Copy link
Copy Markdown
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
A small typo to fix:

View changes since this review

Comment thread src/errors.rs Outdated
Comment thread src/asm.rs Outdated
Copy link
Copy Markdown
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

View changes since this review

@antoyo
Copy link
Copy Markdown
Contributor

antoyo commented Feb 27, 2026

Does the error also happen with inline asm?
If so, could you please do the same check for inline asm?

@harin-ramesh
Copy link
Copy Markdown
Contributor Author

Error was happening for inline asm also, added checks and tests.

@antoyo antoyo merged commit 552fc2f into rust-lang:master Mar 26, 2026
40 of 42 checks passed
@antoyo
Copy link
Copy Markdown
Contributor

antoyo commented Mar 26, 2026

Sorry for the delay for reviewing.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants