Skip to content

Fix "Sync from rust 2026/03/13"#864

Closed
bjorn3 wants to merge 6 commits intorust-lang:sync_from_rust_2026_03_13from
bjorn3:sync_from_rust_2026_03_13_fixes
Closed

Fix "Sync from rust 2026/03/13"#864
bjorn3 wants to merge 6 commits intorust-lang:sync_from_rust_2026_03_13from
bjorn3:sync_from_rust_2026_03_13_fixes

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented Mar 23, 2026

This builds on top of #862. The first commit reverts the last commit of that PR.

@bjorn3 bjorn3 force-pushed the sync_from_rust_2026_03_13_fixes branch from deeb6bd to f2e4692 Compare March 23, 2026 09:57
- name: Run y.sh cargo build
run: |
./y.sh cargo build --manifest-path tests/hello-world/Cargo.toml
CARGO_PROFILE_DEV_LTO=no ./y.sh cargo build --manifest-path tests/hello-world/Cargo.toml
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we could remove the lto = "thin" for the dev profile in tests/hello-world/Cargo.toml.

@bjorn3 bjorn3 marked this pull request as ready for review March 23, 2026 11:00
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 23, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against sync_from_rust_2026_03_13. Please double check that you specified the right target!

@bjorn3 bjorn3 mentioned this pull request Mar 23, 2026
@antoyo antoyo force-pushed the sync_from_rust_2026_03_13 branch from cacf74a to 61a9f27 Compare March 26, 2026 15:56
@antoyo
Copy link
Copy Markdown
Contributor

antoyo commented Mar 26, 2026

Thanks for taking a look into this.
The sync is now done in #865.

@antoyo antoyo closed this Mar 26, 2026
@bjorn3 bjorn3 deleted the sync_from_rust_2026_03_13_fixes branch April 1, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants