Fix ICE when calling transmuted function pointers#873
Open
cijiugechu wants to merge 5 commits intorust-lang:masterfrom
Open
Fix ICE when calling transmuted function pointers#873cijiugechu wants to merge 5 commits intorust-lang:masterfrom
cijiugechu wants to merge 5 commits intorust-lang:masterfrom
Conversation
Cast function pointers to the ABI expected at the call site before emitting indirect calls so transmuted ZST arguments don't trip libgccjit's arity checks. Add a compile-only regression test for the ignored-argument case.
bjorn3
reviewed
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indirect calls could keep the original libgccjit function-pointer type after a transmute instead of the ABI-lowered type expected at the call site, so ZST-elided arguments made libgccjit see the wrong arity and ICE. Cast the callee to the call-site function-pointer type before emitting the indirect call so argument checking and codegen use the normalized signature.
Closes: #836