Skip to content

Lock down CI a little#66

Merged
aDotInTheVoid merged 4 commits into
rust-lang:trunkfrom
aDotInTheVoid:ci-sec
Jun 19, 2026
Merged

Lock down CI a little#66
aDotInTheVoid merged 4 commits into
rust-lang:trunkfrom
aDotInTheVoid:ci-sec

Conversation

@aDotInTheVoid

Copy link
Copy Markdown
Member

Now zizmor isn't unhappy (even if it has lots to say when the level is cranked up):

[nix-shell:~/dev/rust/rustdoc-types-contrib]$ zizmor .
 INFO zizmor: 🌈 zizmor v1.25.2
 INFO audit: zizmor: 🌈 completed ./.github/workflows/CI.yml
 INFO audit: zizmor: 🌈 completed ./.github/workflows/release.yml
No findings to report. Good job! (6 suppressed)

@aDotInTheVoid aDotInTheVoid merged commit 6f9c5c4 into rust-lang:trunk Jun 19, 2026
1 check passed
@aDotInTheVoid

Copy link
Copy Markdown
Member Author

CC @marcoieni who talked about doing this as the all hands "State of the Project" IIRC.

@marcoieni

Copy link
Copy Markdown
Member

That's great, thank you! Do you want me to setup renovate to keep the github actions up to date?

@aDotInTheVoid

Copy link
Copy Markdown
Member Author

Do you want me to setup renovate to keep the github actions up to date?

How important is that? I'm worried it's going to cause a load of churn/pr's for little benefit (especially with https://github.com/taiki-e/install-action/ which updates alot for each tool update).

But also, it's not up to me anymore, I've left T-Rustdoc: rust-lang/team#2523

@marcoieni

Copy link
Copy Markdown
Member

We documented why we recommend renovate in https://forge.rust-lang.org/infra/docs/renovate.html?highlight=renovate#about-dependency-updates

The setup that works for me is updating to breaking compatible versions every month, and get breaking changes PRs immediately. For example, for install-action you will only get one per month unless they go to v3

@aDotInTheVoid

Copy link
Copy Markdown
Member Author

mmmm, makes sense. Only doing one bump a month (for non breaking) seems pretty manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants