Commit 4a67e13
committed
Remove warning on explicit default config value in tests
This was added with f7a25a1, this was
to address an issue with the worthy goal[1]:
> It is probably worth auditing the tests and where they are not
deliberately testing an option, removing any options they set.
However, given the number of warnings this produces:
$ cargo test -- --nocapture |& grep -c 'Default value.*used explicitly'
236
I think this approach did not work, one could enforce this approach by
changing this to be an error, but I think there are valid cases to use
defaults, e.g. a reproduction of an issue relating to line length uses
the default `max_width`: it's simplest to add a test verifying the
behaviour with an explicit `max_width: 100` rather than adjusting the
reproduction.
Link: #1720 [1]1 parent 8636436 commit 4a67e13
1 file changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
776 | 776 | | |
777 | 777 | | |
778 | 778 | | |
779 | | - | |
780 | | - | |
781 | | - | |
782 | 779 | | |
783 | 780 | | |
784 | 781 | | |
| |||
0 commit comments