Skip to content

Commit 88ec076

Browse files
authored
Mirror rust-lang/rust review labels, enable triagebot shortcuts and review-changes-since functionality (#6773)
* triagebot: use the `S-waiting-on-{author,review}` label sets And configure triagebot review status label flipping. Instead of `pr-{not-reviewed,waiting-on-author,follow-up-review-pending}`, for two reasons: 1. Consistency with `rust-lang/rust`. The `S-*` status labels are the ones that `rust-lang/rust` uses. 2. I don't think the `not-reviewed` vs `follow-up-review-pending` distinction makes a lot of difference in practice. However, we can still keep the `pr-follow-up-review-pending` label, since that is previously manually applied anyway. * triagebot: allow users to relabel `S-*` and `C-*` labels Through `@rustbot label`. * triagebot: enable `review-changes-since` functionality Basically, a web-rendered version of `range-diff` to make review after force-pushes easier. * triagebot: enable `shortcut` functionality This allows PR reviewers and authors to easily use: ``` @rustbot ready # S-{waiting-on-author,blocked} -> S-waiting-on-review @rustbot author # S-{waiting-on-review,blocked} -> S-waiting-on-author @rustbot blocked # S-waiting-on-{author,review} -> S-blocked ```
1 parent 7b2cf02 commit 88ec076

1 file changed

Lines changed: 37 additions & 2 deletions

File tree

triagebot.toml

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,52 @@
88
[relabel]
99
allow-unauthenticated = [
1010
"needs-triage",
11+
"S-*",
12+
"C-*",
1113
]
1214

13-
[autolabel."pr-not-reviewed"]
14-
new_pr = true
15+
# ------------------------------------------------------------------------------
16+
# General autolabels
17+
# ------------------------------------------------------------------------------
1518

1619
[autolabel."needs-triage"]
1720
new_issue = true
1821
exclude_labels = [
1922
"C-tracking-issue",
2023
]
2124

25+
# ------------------------------------------------------------------------------
26+
# PR review
27+
# ------------------------------------------------------------------------------
28+
29+
[autolabel."S-waiting-on-review"]
30+
new_pr = true
31+
32+
[autolabel."S-waiting-on-author"]
33+
new_draft = true
34+
35+
[review-submitted]
36+
# This label is added when a "request changes" review is submitted.
37+
reviewed_label = "S-waiting-on-author"
38+
# These labels are removed when a "request changes" review is submitted.
39+
review_labels = ["S-waiting-on-review"]
40+
41+
[review-requested]
42+
# Those labels are removed when PR author requests a review from an assignee
43+
remove_labels = ["S-waiting-on-author"]
44+
# Those labels are added when PR author requests a review from an assignee
45+
add_labels = ["S-waiting-on-review"]
46+
47+
# Adds at the end of a review body a link to view the changes that happened
48+
# since the review
49+
# Documentation at: https://forge.rust-lang.org/triagebot/review-changes-since.html
50+
[review-changes-since]
51+
52+
# Allow reviewers and authors to easily flip between {`S-waiting-on-review`,
53+
# `S-waiting-on-author`, `S-blocked`}.
54+
# Documentation at: <https://forge.rust-lang.org/triagebot/shortcuts.html>
55+
[shortcut]
56+
2257
# ------------------------------------------------------------------------------
2358
# PR assignments
2459
# ------------------------------------------------------------------------------

0 commit comments

Comments
 (0)