Fix Issue 6470: Preserve Space after colon if followed by absolute path declaration (::)#6475
Open
FwP-IDN wants to merge 21 commits into
Open
Conversation
FwP-IDN
changed the title
FwP-IDN
changed the title
ytmimi
reviewed
Feb 17, 2025
Comment on lines
+2297
to
+2323
| result.push_str(colon_spaces(context.config)); | ||
| result.push_str(colon_spaces(context.config, false)); |
Contributor
There was a problem hiding this comment.
Can you explain why we can pass false here? It would also be helpful if you could add an explanation to the other call sites where you've passed false.
ytmimi
reviewed
Feb 17, 2025
ytmimi
reviewed
Feb 17, 2025
ytmimi
reviewed
Feb 17, 2025
jieyouxu
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6470