Format an empty file with 0 lines instead of 1 line#6567
Closed
tyilo wants to merge 4 commits intorust-lang:mainfrom
Closed
Format an empty file with 0 lines instead of 1 line#6567tyilo wants to merge 4 commits intorust-lang:mainfrom
tyilo wants to merge 4 commits intorust-lang:mainfrom
Conversation
jieyouxu
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tyilo
force-pushed
the
empty-file-0-lines
branch
from
0efeead to
842f3fd
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #6839) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
Closing since we merged #6839 |
rustbot
removed
the
S-waiting-on-review
Author
|
@ytmimi Sad that the new PR got priority over this one, but at least it's fixed 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the correct behavior.
Also see #5364