Bump clap-cargo and cargo_metadata versions.

[thunderseethe]

clap-cargo 0.12.0 -> 0.18.3
cargo_metadata 0.18 -> 0.23

Ran cargo test locally and all tests are passing.

[ytmimi]

Why are we updating these versions? The rational isn't clearly articulated in the PR description.

[ytmimi]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[ytmimi]

Also, just checking the tests isn't enough in my opinion. Are there any breaking changes mentioned in the changelogs for clap-cargo and cargo_metadata that would change behavior for rustfmt?

[thunderseethe]

Rationale is mostly around using more recent editions of the crate. I work in a mono repo, so rustfmt relying on older versions of the crate requires the rest of our rust code to rely on that same version. I'm also operating under the assumption these version bumps are innocuous. If we're concerned they could cause more substantial breakages, I can find a different workaround vs bumping the versions here.

I took a look at the changelogs for clap-cargo and cargo_metadata and the biggest changes appear to be shifts in MSRV with clap-cargo now requiring MSRV 1.86 (and cargo_metadata requiring MSRV 1.56). Possible this could be a problem for rustfmt given how widely used it is in the ecosystem. Does CI check for MSRV coverage?

[Manishearth]

Seems good to keep these up to date

View changes since this review

[Manishearth]

I went through the changelogs for the two crates and didn't find anything big.

Possible this could be a problem for rustfmt given how widely used it is in the ecosystem

Rustfmt isn't really used as a crate (I think it's no longer released on crates.io, even), so MSRV isn't a problem here.