Skip to content

Allow selecting next exercise with enter key#2384

Merged
mo8it merged 2 commits intorust-lang:mainfrom
senekor:senekor/kvvswrqlorup
Apr 25, 2026
Merged

Allow selecting next exercise with enter key#2384
mo8it merged 2 commits intorust-lang:mainfrom
senekor:senekor/kvvswrqlorup

Conversation

@senekor
Copy link
Copy Markdown
Contributor

@senekor senekor commented Apr 18, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@mo8it mo8it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that Enter is more intuitive. But then I would remove c. It should be added to the footer.

@mo8it
Copy link
Copy Markdown
Contributor

mo8it commented Apr 20, 2026

I remember now why I didn't choose Enter: I didn't know how to show it in the footer while staying consistent with the other keys. Maybe just Enter: continue at?

@senekor
Copy link
Copy Markdown
Contributor Author

senekor commented Apr 20, 2026

I think c is actually fine too. I'd guess there are two types of people: Some check the footer to find out what to do. Those will use c, as indicated. Others will hit enter blindly, assuming it'll work, because it's intuitive (that's me). Both are fine, and I don't think it would bother anyone that only one option shows up in the footer.

@mo8it
Copy link
Copy Markdown
Contributor

mo8it commented Apr 25, 2026

I don't like it when an option is not defined. If I hit enter, I want to be able to look up what exactly it does.
Could you then just add Enter/ to the footer?

@senekor
Copy link
Copy Markdown
Contributor Author

senekor commented Apr 25, 2026

Sure. There's also a unicode symbol, just like for the up and down arrows:
image

Although I'm not sure if all terminal fonts render this well. What do you prefer, symbol or just "Enter" ?

This will cause an (easy to fix) merge conflict with #2381, just to keep in mind.

@mo8it mo8it merged commit b06c843 into rust-lang:main Apr 25, 2026
7 checks passed
@senekor senekor deleted the senekor/kvvswrqlorup branch April 25, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants