intrinsic-test: remove redundant bit pattern consts

This isn't strictly optimal as it means that the 5/6/7 bit cases are less
likely to be tested with values at the edges (e.g. `0x7e` for 7 bits).

Author: davidtwco

crates/intrinsic-test/src/common/values.rs

@@ -110,39 +110,15 @@ pub fn test_values_array_length(ty: &IntrinsicType) -> u32 {
 pub fn bit_pattern_for_test_values_array(bits: u32, index: u32) -> u64 {
     let index = index as usize;
     match bits {
-        1 => BIT_PATTERNS_8[index % 2].into(),
-        2 => BIT_PATTERNS_8[index % 4].into(),
-        3 => BIT_PATTERNS_8[index % 8].into(),
-        4 => BIT_PATTERNS_8[index % 16].into(),
-        5 => BIT_PATTERNS_5[index % BIT_PATTERNS_5.len()].into(),
-        6 => BIT_PATTERNS_6[index % BIT_PATTERNS_6.len()].into(),
-        7 => BIT_PATTERNS_7[index % BIT_PATTERNS_7.len()].into(),
-        8 => BIT_PATTERNS_8[index % BIT_PATTERNS_8.len()].into(),
+        bits @ (1 | 2 | 3 | 4 | 5 | 6 | 7 | 8) => BIT_PATTERNS_8[index % (1 << bits)].into(),
         16 => BIT_PATTERNS_16[index % BIT_PATTERNS_16.len()].into(),
         32 => BIT_PATTERNS_32[index % BIT_PATTERNS_32.len()].into(),
         64 => BIT_PATTERNS_64[index % BIT_PATTERNS_64.len()],
         _ => unimplemented!("bit_pattern_for_test_values_array(bits: {bits}, ..)"),
     }
 }
 
-pub const BIT_PATTERNS_5: &[u8] = &[
-    0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
-    0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18, 0x019, 0x1a, 0x1b, 0x1c, 0x1d, 0x1e,
-    0x1f,
-];
-
-pub const BIT_PATTERNS_6: &[u8] = &[
-    0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
-    0x30, 0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38, 0x039, 0x3a, 0x3b, 0x3c, 0x3d, 0x3e,
-    0x3f,
-];
-
-pub const BIT_PATTERNS_7: &[u8] = &[
-    0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
-    0x70, 0x71, 0x72, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x079, 0x7a, 0x7b, 0x7c, 0x7d, 0x7e,
-    0x7f,
-];
-
+// Contains every possible 8-bit value in order
 pub const BIT_PATTERNS_8: &[u8] = &[
     0x0, 0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0x10, 0x11,
     0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18, 0x19, 0x1a, 0x1b, 0x1c, 0x1d, 0x1e, 0x1f, 0x20, 0x21,