Skip to content

Commit efc35fe

Browse files
committed
core_arch: remove redundant tests
Manually written tests for `vcopy_laneq`, `vget{,q}_{high,low,lane}`, `vcombine` and `vaddw_high` don't account for the expected differences in output for big endian intrinsics and given that they duplicate the testing of `intrinsic-test`, can be removed.
1 parent d3c6e0e commit efc35fe

3 files changed

Lines changed: 124 additions & 689 deletions

File tree

crates/core_arch/src/aarch64/neon/mod.rs

Lines changed: 0 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -611,54 +611,13 @@ mod tests {
611611
assert_eq!(r, e);
612612
}
613613

614-
#[simd_test(enable = "neon")]
615-
fn test_vget_high_f64() {
616-
let a = f64x2::new(1.0, 2.0);
617-
let e = f64x1::new(2.0);
618-
let r = f64x1::from(vget_high_f64(a.into()));
619-
assert_eq!(r, e);
620-
}
621-
622-
#[simd_test(enable = "neon")]
623-
fn test_vget_high_p64() {
624-
let a = u64x2::new(1, 2);
625-
let e = u64x1::new(2);
626-
let r = u64x1::from(vget_high_p64(a.into()));
627-
assert_eq!(r, e);
628-
}
629-
630-
#[simd_test(enable = "neon")]
631-
fn test_vget_low_f64() {
632-
let a = f64x2::new(1.0, 2.0);
633-
let e = f64x1::new(1.0);
634-
let r = f64x1::from(vget_low_f64(a.into()));
635-
assert_eq!(r, e);
636-
}
637-
638-
#[simd_test(enable = "neon")]
639-
fn test_vget_low_p64() {
640-
let a = u64x2::new(1, 2);
641-
let e = u64x1::new(1);
642-
let r = u64x1::from(vget_low_p64(a.into()));
643-
assert_eq!(r, e);
644-
}
645-
646614
#[simd_test(enable = "neon")]
647615
fn test_vget_lane_f64() {
648616
let v = f64x1::new(1.0);
649617
let r = vget_lane_f64::<0>(v.into());
650618
assert_eq!(r, 1.0);
651619
}
652620

653-
#[simd_test(enable = "neon")]
654-
fn test_vgetq_lane_f64() {
655-
let v = f64x2::new(0.0, 1.0);
656-
let r = vgetq_lane_f64::<1>(v.into());
657-
assert_eq!(r, 1.0);
658-
let r = vgetq_lane_f64::<0>(v.into());
659-
assert_eq!(r, 0.0);
660-
}
661-
662621
#[simd_test(enable = "neon")]
663622
fn test_vcopy_lane_s64() {
664623
let a = i64x1::new(1);
@@ -695,42 +654,6 @@ mod tests {
695654
assert_eq!(r, e);
696655
}
697656

698-
#[simd_test(enable = "neon")]
699-
fn test_vcopy_laneq_s64() {
700-
let a = i64x1::new(1);
701-
let b = i64x2::new(0, 0x7F_FF_FF_FF_FF_FF_FF_FF);
702-
let e = i64x1::new(0x7F_FF_FF_FF_FF_FF_FF_FF);
703-
let r = i64x1::from(vcopy_laneq_s64::<0, 1>(a.into(), b.into()));
704-
assert_eq!(r, e);
705-
}
706-
707-
#[simd_test(enable = "neon")]
708-
fn test_vcopy_laneq_u64() {
709-
let a = u64x1::new(1);
710-
let b = u64x2::new(0, 0xFF_FF_FF_FF_FF_FF_FF_FF);
711-
let e = u64x1::new(0xFF_FF_FF_FF_FF_FF_FF_FF);
712-
let r = u64x1::from(vcopy_laneq_u64::<0, 1>(a.into(), b.into()));
713-
assert_eq!(r, e);
714-
}
715-
716-
#[simd_test(enable = "neon")]
717-
fn test_vcopy_laneq_p64() {
718-
let a = u64x1::new(1);
719-
let b = u64x2::new(0, 0x7F_FF_FF_FF_FF_FF_FF_FF);
720-
let e = u64x1::new(0x7F_FF_FF_FF_FF_FF_FF_FF);
721-
let r = u64x1::from(vcopy_laneq_p64::<0, 1>(a.into(), b.into()));
722-
assert_eq!(r, e);
723-
}
724-
725-
#[simd_test(enable = "neon")]
726-
fn test_vcopy_laneq_f64() {
727-
let a = f64x1::from_array([1.]);
728-
let b = f64x2::from_array([0., 0.5]);
729-
let e = f64x1::from_array([0.5]);
730-
let r = f64x1::from(vcopy_laneq_f64::<0, 1>(a.into(), b.into()));
731-
assert_eq!(r, e);
732-
}
733-
734657
#[simd_test(enable = "neon")]
735658
fn test_vbsl_f64() {
736659
let a = u64x1::new(0x8000000000000000);

0 commit comments

Comments
 (0)