Skip to content

Commit f0b7c56

Browse files
authored
Merge pull request #2067 from rust-lang/rustc-pull
Rustc pull update
2 parents b5c4127 + cb3ceeb commit f0b7c56

6 files changed

Lines changed: 20 additions & 18 deletions

File tree

.github/workflows/main.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,9 @@ jobs:
9696
os: ubuntu-latest
9797
- tuple: loongarch64-unknown-linux-gnu
9898
os: ubuntu-latest
99-
- tuple: hexagon-unknown-linux-musl
100-
os: ubuntu-latest
99+
# hexagon doesn't build at the moment due to a libc issue.
100+
# - tuple: hexagon-unknown-linux-musl
101+
# os: ubuntu-latest
101102
- tuple: wasm32-wasip1
102103
os: ubuntu-latest
103104

@@ -209,11 +210,12 @@ jobs:
209210
tuple: amdgcn-amd-amdhsa
210211
os: ubuntu-latest
211212
norun: true
212-
- target:
213-
tuple: hexagon-unknown-linux-musl
214-
os: ubuntu-latest
215-
norun: true
216-
build_std: true
213+
# hexagon doesn't build at the moment due to a libc issue.
214+
# - target:
215+
# tuple: hexagon-unknown-linux-musl
216+
# os: ubuntu-latest
217+
# norun: true
218+
# build_std: true
217219

218220
steps:
219221
- uses: actions/checkout@v6

.github/workflows/rustc-pull.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ jobs:
1313
uses: rust-lang/josh-sync/.github/workflows/rustc-pull.yml@main
1414
with:
1515
github-app-id: ${{ vars.APP_CLIENT_ID }}
16+
pr-author: "workflows-stdarch[bot]"
1617
# https://rust-lang.zulipchat.com/#narrow/channel/208962-t-libs.2Fstdarch/topic/Subtree.20sync.20automation/with/528461782
1718
zulip-stream-id: 208962
1819
zulip-bot-email: "stdarch-ci-bot@rust-lang.zulipchat.com"

crates/core_arch/src/mips/msa.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9187,7 +9187,6 @@ mod tests {
91879187
core_arch::{mips::msa::*, simd::*},
91889188
mem,
91899189
};
9190-
use std::{f32, f64};
91919190
use stdarch_test::simd_test;
91929191

91939192
#[simd_test(enable = "msa")]

crates/core_arch/src/nvptx/packed.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ pub unsafe fn f16x2_neg(a: f16x2) -> f16x2 {
9999
#[cfg_attr(test, assert_instr(min.f16x2))]
100100
#[unstable(feature = "stdarch_nvptx", issue = "111199")]
101101
pub unsafe fn f16x2_min(a: f16x2, b: f16x2) -> f16x2 {
102-
simd_fmin(a, b)
102+
simd_minimum_number_nsz(a, b)
103103
}
104104

105105
/// Find the minimum of two values, NaNs pass through.
@@ -123,7 +123,7 @@ pub unsafe fn f16x2_min_nan(a: f16x2, b: f16x2) -> f16x2 {
123123
#[cfg_attr(test, assert_instr(max.f16x2))]
124124
#[unstable(feature = "stdarch_nvptx", issue = "111199")]
125125
pub unsafe fn f16x2_max(a: f16x2, b: f16x2) -> f16x2 {
126-
simd_fmax(a, b)
126+
simd_maximum_number_nsz(a, b)
127127
}
128128

129129
/// Find the maximum of two values, NaNs pass through.

crates/core_arch/src/x86/sse.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ pub fn _mm_min_ss(a: __m128, b: __m128) -> __m128 {
208208
#[cfg_attr(test, assert_instr(minps))]
209209
#[stable(feature = "simd_x86", since = "1.27.0")]
210210
pub fn _mm_min_ps(a: __m128, b: __m128) -> __m128 {
211-
// See the `test_mm_min_ps` test why this can't be implemented using `simd_fmin`.
211+
// See the `test_mm_min_ps` test why this can't be implemented using `simd_minimum_number_nsz`.
212212
unsafe { minps(a, b) }
213213
}
214214

@@ -234,7 +234,7 @@ pub fn _mm_max_ss(a: __m128, b: __m128) -> __m128 {
234234
#[cfg_attr(test, assert_instr(maxps))]
235235
#[stable(feature = "simd_x86", since = "1.27.0")]
236236
pub fn _mm_max_ps(a: __m128, b: __m128) -> __m128 {
237-
// See the `test_mm_min_ps` test why this can't be implemented using `simd_fmax`.
237+
// See the `test_mm_min_ps` test why this can't be implemented using `simd_maximum_number_nsz`.
238238
unsafe { maxps(a, b) }
239239
}
240240

@@ -2227,11 +2227,11 @@ mod tests {
22272227
let r = _mm_min_ps(a, b);
22282228
assert_eq_m128(r, _mm_setr_ps(-100.0, 5.0, 0.0, -10.0));
22292229

2230-
// `_mm_min_ps` can **not** be implemented using the `simd_min` rust intrinsic. `simd_min`
2231-
// is lowered by the llvm codegen backend to `llvm.minnum.v*` llvm intrinsic. This intrinsic
2232-
// doesn't specify how -0.0 is handled. Unfortunately it happens to behave different from
2233-
// the `minps` x86 instruction on x86. The `llvm.minnum.v*` llvm intrinsic equals
2234-
// `r1` to `a` and `r2` to `b`.
2230+
// `_mm_min_ps` can **not** be implemented using the `simd_minimum_number_nsz` rust
2231+
// intrinsic. That intrinsic is lowered by the llvm codegen backend to `llvm.minimumnum.v*`
2232+
// llvm intrinsic with the `nsz` attribute. The `nsz` attribute means -0.0 is handled
2233+
// non-deterministically. The `minps` x86 instruction however has a deterministic semantics
2234+
// for signed zeros.
22352235
let a = _mm_setr_ps(-0.0, 0.0, 0.0, 0.0);
22362236
let b = _mm_setr_ps(0.0, 0.0, 0.0, 0.0);
22372237
let r1 = _mm_min_ps(a, b).as_f32x4().to_bits();

rust-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
eda4fc7733ee89e484d7120cafbd80dcb2fce66e
1+
e4fdb554ad2c0270473181438e338c42b5b30b0c

0 commit comments

Comments
 (0)