for sse4a functions compare only the lower quadword#2191
Merged
Conversation
folkertdev
force-pushed
the
sse4a-compare-lower-quad
branch
from
July 16, 2026 09:51
5ca4167 to
bb1049f
Compare
the upper quadword is undefined
folkertdev
force-pushed
the
sse4a-compare-lower-quad
branch
from
July 17, 2026 08:59
bb1049f to
bd6e145
Compare
Contributor
|
Sorry for the late review |
sayantn
reviewed
Jul 18, 2026
| use stdarch_test::simd_test; | ||
|
|
||
| // Normally this requires SSE2, but for tests it does not matter whether we use the instruction. | ||
| fn _mm_cvtsi128_si64(a: __m128i) -> i64 { |
Contributor
There was a problem hiding this comment.
Not to hold the queue up, but why did you not use the sse2 function? sse4a does imply sse2
Contributor
Author
There was a problem hiding this comment.
Well we already import use crate::core_arch::x86::*; here but it couldn't find that function. Maybe some cfg is incorrect somewhere? Anyhow this worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2190
the upper quadword is undefined, see the issue.
r? sayantn
cc @nikic