From 7b34d4c95050ef36aa2aa75f4418d6c55477c212 Mon Sep 17 00:00:00 2001 From: Urgau Date: Tue, 7 Apr 2026 19:43:06 +0200 Subject: [PATCH 1/2] Only trigger on reviews and review comments, not normal comments --- src/handlers/review_changes_since.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/handlers/review_changes_since.rs b/src/handlers/review_changes_since.rs index d8c2e0af..bb287c66 100644 --- a/src/handlers/review_changes_since.rs +++ b/src/handlers/review_changes_since.rs @@ -49,6 +49,12 @@ pub(crate) async fn handle( .. }, ) = event + && ( + // review + event.comment.pr_review_state.is_some() + // review comments + || event.comment.pull_request_review_id.is_some() + ) { let issue_repo = event.issue.repository(); let pr_num = event.issue.number; @@ -58,8 +64,7 @@ pub(crate) async fn handle( let link = format!("https://{host}/gh-changes-since/{issue_repo}/{pr_num}/{base}..{head}"); - if event.comment.pull_request_review_id.is_none() && event.comment.pr_review_state.is_some() - { + if event.comment.pr_review_state.is_some() { // this is a review (not a review comment) { From 69b814e59e059b01b4ed9cca714af22ba64a447c Mon Sep 17 00:00:00 2001 From: Urgau Date: Tue, 7 Apr 2026 19:43:51 +0200 Subject: [PATCH 2/2] Add SCREAMING_CASE aliases for `PullRequestReviewState` --- src/github/issue.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/github/issue.rs b/src/github/issue.rs index c46cfaed..43984342 100644 --- a/src/github/issue.rs +++ b/src/github/issue.rs @@ -632,7 +632,7 @@ impl Issue { let review = client .json(client.get(&review_url)) .await - .context("unable to fetch review")?; + .with_context(|| format!("unable to fetch review ({review_id})"))?; Ok(review) } } @@ -663,10 +663,15 @@ pub struct Comment { #[derive(Debug, serde::Deserialize, Eq, PartialEq)] #[serde(rename_all = "snake_case")] pub enum PullRequestReviewState { + #[serde(alias = "APPROVED")] Approved, + #[serde(alias = "CHANGES_REQUESTED")] ChangesRequested, + #[serde(alias = "COMMENTED")] Commented, + #[serde(alias = "DISMISSED")] Dismissed, + #[serde(alias = "PENDING")] Pending, }