Retrieve team that handles a backport#2393
Merged
apiraino merged 1 commit intorust-lang:masterfrom May 6, 2026
Merged
Conversation
Urgau
reviewed
May 4, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
apiraino
force-pushed
the
get-team-backport-zulip-notif
branch
from
7b049be to
35fb295
Compare
Contributor
Author
|
applied suggestions and rebased. thanks! edit: I fixed a strange typo(?) in your suggestion, unsure where it comes from |
apiraino
force-pushed
the
get-team-backport-zulip-notif
branch
from
35fb295 to
f3b7cb5
Compare
Urgau
reviewed
May 5, 2026
apiraino
force-pushed
the
get-team-backport-zulip-notif
branch
from
f0f8272 to
a8e0c07
Compare
Urgau
reviewed
May 5, 2026
Co-authored-by: Urgau <3616612+Urgau@users.noreply.github.com>
apiraino
force-pushed
the
get-team-backport-zulip-notif
branch
from
5f86237 to
d671884
Compare
Urgau
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2391
This patch adds a call to the Zulip API to get the the stream name from where the message is sent. The stream name is then used to infer the team name that approve/decline a backport.
It's not easy to figure out in a reliable way which team approves a backport:
t-*labels of a PR? What if there are more than one?backport approve beta 123? Anybody can use@**triagebot**So unless I missed a better way to do it, I choose the third option. In the worst case the team name will be empty rather than wrong 🤷
r? @Urgau
thanks